rollout support patchPodTemplateMetadata #157
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #157 +/- ##
==========================================
- Coverage 43.67% 43.65% -0.03%
==========================================
Files 50 50
Lines 5259 5278 +19
==========================================
+ Hits 2297 2304 +7
- Misses 2575 2585 +10
- Partials 387 389 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
pkg/controller/batchrelease/control/canarystyle/deployment/canary.go
Outdated
Show resolved
Hide resolved
zmberg
force-pushed
the
patchPodTemplateMetadata
branch
2 times, most recently
from
6815f25 to
0b6156b
Compare
| delete(dTemplate.Annotations, k) | ||
| } | ||
| } | ||
| if util.EqualIgnoreHash(dTemplate, &dClone.Spec.Template) { |
There was a problem hiding this comment.
dClone is deepcopy twice here, can we make a modified EqualIgnoreHash func e.g. EqualIgnoreMetadata(template1, template2 *v1.PodTemplateSpec, labels []string, annotations []string)
| @@ -50,6 +50,10 @@ type ReleasePlan struct { | |||
| // FinalizingPolicy define the behavior of controller when phase enter Finalizing | |||
| // Defaults to "Immediate" | |||
| FinalizingPolicy FinalizingPolicyType `json:"finalizingPolicy,omitempty"` | |||
| // PatchPodTemplateMetadata indicates patch configuration(e.g. labels, annotations) to the canary deployment podTemplateSpec.metadata | |||
| // only support for canary deployment | |||
There was a problem hiding this comment.
is support for cloneset possible?
There was a problem hiding this comment.
This still depends on the scenario, there is no canary workload for cloneSet, so it may be necessary to look at the scenario later
zmberg
force-pushed
the
patchPodTemplateMetadata
branch
from
0b6156b to
746c2c0
Compare
Signed-off-by: liheng.zms <[email protected]>
zmberg
force-pushed
the
patchPodTemplateMetadata
branch
from
746c2c0 to
8b4aa86
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: furykerry The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: liheng.zms <[email protected]>
Ⅰ. Describe what this PR does
Rollout add patchPodTemplateMetadata field.
Rollout will add labels[alicloud.service.tag]=gray in workload.spec.template, then the microservices governance solutions MSE and Isito can identify which pod is base version and which is grey version.