Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced deployment scale down old unhealthy pods firstly #150

Merged
merged 2 commits into from
Jul 12, 2023

Conversation

veophi
Copy link
Member

@veophi veophi commented Jun 13, 2023

Ⅰ. Describe what this PR does

fixes #149

Ⅱ. Does this pull request fix one issue?

Ⅲ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2023

Codecov Report

Merging #150 (390aff5) into master (3578b39) will decrease coverage by 1.23%.
The diff coverage is 77.77%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master     #150      +/-   ##
==========================================
- Coverage   44.67%   43.44%   -1.23%     
==========================================
  Files          48       50       +2     
  Lines        5077     5361     +284     
==========================================
+ Hits         2268     2329      +61     
- Misses       2432     2635     +203     
- Partials      377      397      +20     
Flag Coverage Δ
unittests 43.44% <77.77%> (-1.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/controller/deployment/sync.go 45.76% <77.77%> (+1.26%) ⬆️

... and 16 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@veophi veophi changed the title Advanced deployment scale down old unhealthy pods first Advanced deployment scale down old unhealthy pods firstly Jun 13, 2023
@veophi veophi force-pushed the Fix-deployment-scale branch from 72d2d83 to 74080d2 Compare June 13, 2023 11:37
@veophi veophi force-pushed the Fix-deployment-scale branch 3 times, most recently from 22653a4 to 825504f Compare June 26, 2023 03:56
@veophi veophi force-pushed the Fix-deployment-scale branch from 825504f to a1fef3a Compare June 26, 2023 03:58
@kruise-bot kruise-bot added size/M and removed size/S labels Jul 10, 2023
@veophi veophi force-pushed the Fix-deployment-scale branch from 49a4d60 to 390aff5 Compare July 11, 2023 09:11
@zmberg
Copy link
Member

zmberg commented Jul 12, 2023

/lgtm

Copy link
Member

@furykerry furykerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@zmberg
Copy link
Member

zmberg commented Jul 12, 2023

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zmberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit 72e1c0b into openkruise:master Jul 12, 2023
Kuromesi pushed a commit to Kuromesi/rollouts that referenced this pull request Jul 17, 2023
…#150)

* advanced deployment scale down old unhealthy pods firstly

Signed-off-by: mingzhou.swx <[email protected]>

* add e2e for advanced deployment scale down old unhealthy pod first

Signed-off-by: mingzhou.swx <[email protected]>

---------

Signed-off-by: mingzhou.swx <[email protected]>
Co-authored-by: mingzhou.swx <[email protected]>
zmberg pushed a commit that referenced this pull request Jul 18, 2023
* advanced deployment scale down old unhealthy pods firstly

Signed-off-by: mingzhou.swx <[email protected]>

* add e2e for advanced deployment scale down old unhealthy pod first

Signed-off-by: mingzhou.swx <[email protected]>

---------

Signed-off-by: mingzhou.swx <[email protected]>
Co-authored-by: mingzhou.swx <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] available replicaset scale down in paused continuous release
5 participants