Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update k8s registry references #126

Merged

Conversation

asa3311
Copy link
Contributor

@asa3311 asa3311 commented Mar 8, 2023

Ⅰ. Describe what this PR does

Per kubernetes/k8s.io#4780, Kubernetes is migrating its image registry to registry.k8s.io, and this repository is impacted.

We have to update the references of k8s.gcr.io to registry.k8s.io by April 3rd to remain up-to-date.

Here's a quick search for k8s.gcr.io on this repo. [search result]. Note that there may be other valid references (like, in the form of generated code, etc) which we have to be aware of.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Special notes for reviews

@kruise-bot kruise-bot requested review from FillZpp and zmberg March 8, 2023 14:31
@kruise-bot
Copy link

Welcome @asa3311! It looks like this is your first PR to openkruise/rollouts 🎉

@codecov-commenter
Copy link

Codecov Report

Merging #126 (b5617bb) into master (2b48eba) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##           master     #126   +/-   ##
=======================================
  Coverage   44.66%   44.66%           
=======================================
  Files          47       47           
  Lines        4865     4865           
=======================================
  Hits         2173     2173           
  Misses       2335     2335           
  Partials      357      357           
Flag Coverage Δ
unittests 44.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@asa3311 asa3311 changed the title Update image_utils.go Update k8s registry references Mar 8, 2023
@veophi
Copy link
Member

veophi commented Mar 21, 2023

/lgtm

@furykerry
Copy link
Member

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furykerry, liangyuanpeng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit 77e4b8d into openkruise:master Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants