Rolling Deployment in partition-style #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veophi
force-pushed
the
rolling-deployment-in-partition-style
branch
2 times, most recently
from
dc47c06 to
07380e0
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #115 +/- ##
==========================================
- Coverage 44.74% 44.66% -0.08%
==========================================
Files 44 47 +3
Lines 4519 4865 +346
==========================================
+ Hits 2022 2173 +151
- Misses 2158 2335 +177
- Partials 339 357 +18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
veophi
force-pushed
the
rolling-deployment-in-partition-style
branch
from
07380e0 to
96b63c7
Compare
zmberg
reviewed
Jan 31, 2023
pkg/controller/batchrelease/control/partitionstyle/deployment/control.go
Show resolved
Hide resolved
zmberg
reviewed
Jan 31, 2023
pkg/controller/batchrelease/control/partitionstyle/deployment/control.go
Outdated
Show resolved
Hide resolved
pkg/controller/batchrelease/control/partitionstyle/deployment/control.go
Outdated
Show resolved
Hide resolved
pkg/controller/batchrelease/control/partitionstyle/deployment/control.go
Outdated
Show resolved
Hide resolved
pkg/controller/batchrelease/control/partitionstyle/deployment/control.go
Outdated
Show resolved
Hide resolved
veophi
force-pushed
the
rolling-deployment-in-partition-style
branch
2 times, most recently
from
7118c6b to
28e4afc
Compare
|
/lgtm |
furykerry
reviewed
Feb 8, 2023
| release, release.GetObjectKind().GroupVersionKind())) | ||
|
|
||
| // Disable the native deployment controller | ||
| d.Spec.Strategy = apps.DeploymentStrategy{Type: apps.RecreateDeploymentStrategyType} |
There was a problem hiding this comment.
webhook will also set strategy to recreate, is it necessary to duplicate the work here, or controller should duplicate the whole work here (also set pause=true) to avoid potential webhook failure
pkg/util/controller_finder.go
Outdated
| @@ -190,7 +271,6 @@ func (r *ControllerFinder) getDeployment(namespace string, ref *rolloutv1alpha1. | |||
| workload.InRolloutProgressing = true | |||
| // workload is continuous release, indicates rollback(v1 -> v2 -> v1) | |||
| // delete auto-generated labels | |||
| d := rc.object.DeepCopy() | ||
| strategy.Partition = ctx.DesiredPartition | ||
| d.Annotations[v1alpha1.DeploymentStrategyAnnotation] = util.DumpJSON(&strategy) | ||
| return rc.client.Patch(context.TODO(), d, client.MergeFrom(rc.object)) |
There was a problem hiding this comment.
can we use StrategicMergeFrom from native k8s objects
veophi
force-pushed
the
rolling-deployment-in-partition-style
branch
from
28e4afc to
e658912
Compare
veophi
force-pushed
the
rolling-deployment-in-partition-style
branch
from
e658912 to
2d834a5
Compare
veophi
force-pushed
the
rolling-deployment-in-partition-style
branch
from
2d834a5 to
2a52b0c
Compare
veophi
force-pushed
the
rolling-deployment-in-partition-style
branch
2 times, most recently
from
9986217 to
5eb80c6
Compare
zmberg
reviewed
Feb 9, 2023
veophi
force-pushed
the
rolling-deployment-in-partition-style
branch
from
5eb80c6 to
b5e93f1
Compare
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
veophi
force-pushed
the
rolling-deployment-in-partition-style
branch
from
b5e93f1 to
e5613dc
Compare
Signed-off-by: mingzhou.swx <[email protected]>
veophi
force-pushed
the
rolling-deployment-in-partition-style
branch
from
e5613dc to
55d9e02
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zmberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: mingzhou.swx [email protected]
Ⅰ. Describe what this PR does
We can rolling Deployment just like CloneSet/StatefulSet using
partition!Ⅱ. Does this pull request fix one issue?
fixes #15