Skip to content

Commit

Permalink
polish comments
Browse files Browse the repository at this point in the history
Signed-off-by: Megrez Lu <[email protected]>
  • Loading branch information
lujiajing1126 committed May 14, 2024
1 parent d6db4dd commit 8e02b8b
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 10 deletions.
5 changes: 2 additions & 3 deletions api/v1beta1/rollout_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -146,12 +146,11 @@ type TrafficRoutingStrategy struct {
//
// +optional
RequestHeaderModifier *gatewayv1beta1.HTTPRequestHeaderFilter `json:"requestHeaderModifier,omitempty"`
// Matches define conditions used for matching the incoming HTTP requests to canary service.
// Each match is independent, i.e. this rule will be matched if **any** one of the matches is satisfied.
// Matches define conditions used for matching incoming HTTP requests to the canary service.
// Each match is independent, i.e. this rule will be matched as long as **any** one of the matches is satisfied.
//
// For Gateway API, only a single match rule will be applied since Gateway API use ANDed rules if multiple
// ones are defined, i.e. the match will evaluate to true only if all conditions are satisfied.
// Header (for backwards-compatibility) > QueryParams
// And cannot support both weight and matches, if both are configured, then matches takes precedence.
Matches []HttpRouteMatch `json:"matches,omitempty"`
}
Expand Down
13 changes: 6 additions & 7 deletions config/crd/bases/rollouts.kruise.io_rollouts.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -623,14 +623,13 @@ spec:
properties:
matches:
description: "Matches define conditions used for matching
the incoming HTTP requests to canary service. Each
incoming HTTP requests to the canary service. Each
match is independent, i.e. this rule will be matched
if **any** one of the matches is satisfied. \n For
Gateway API, only a single match rule will be applied
since Gateway API use ANDed rules if multiple ones
are defined, i.e. the match will evaluate to true
only if all conditions are satisfied. Header (for
backwards-compatibility) > QueryParams And cannot
as long as **any** one of the matches is satisfied.
\n For Gateway API, only a single match rule will
be applied since Gateway API use ANDed rules if multiple
ones are defined, i.e. the match will evaluate to
true only if all conditions are satisfied. And cannot
support both weight and matches, if both are configured,
then matches takes precedence."
items:
Expand Down

0 comments on commit 8e02b8b

Please sign in to comment.