Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add kruise_manager_is_leader metric #917

Merged
merged 1 commit into from
Mar 3, 2022
Merged

add kruise_manager_is_leader metric #917

merged 1 commit into from
Mar 3, 2022

Conversation

hatowang
Copy link
Contributor

@hatowang hatowang commented Mar 3, 2022

Ⅰ. Describe what this PR does

add leader metric for kruise_manager.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@kruise-bot kruise-bot requested review from FillZpp and furykerry March 3, 2022 02:46
@kruise-bot kruise-bot added the size/L size/L: 100-499 label Mar 3, 2022
@kruise-bot
Copy link

Welcome @hatowang! It looks like this is your first PR to openkruise/kruise 🎉

@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2022

Codecov Report

Merging #917 (4c5fad6) into master (7722528) will decrease coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #917      +/-   ##
==========================================
- Coverage   49.37%   49.20%   -0.18%     
==========================================
  Files         119      119              
  Lines       11102    11102              
==========================================
- Hits         5482     5463      -19     
- Misses       4786     4799      +13     
- Partials      834      840       +6     
Flag Coverage Δ
unittests 49.20% <ø> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...roller/uniteddeployment/uniteddeployment_update.go 74.15% <0.00%> (-6.75%) ⬇️
...teddeployment/uniteddeployment_controller_utils.go 63.63% <0.00%> (-4.55%) ⬇️
pkg/controller/cloneset/cloneset_controller.go 50.57% <0.00%> (-2.29%) ⬇️
pkg/controller/uniteddeployment/revision.go 66.41% <0.00%> (-1.53%) ⬇️
...er/uniteddeployment/uniteddeployment_controller.go 70.44% <0.00%> (-1.48%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7722528...4c5fad6. Read the comment docs.

@FillZpp
Copy link
Member

FillZpp commented Mar 3, 2022

@hatowang Thanks. It seems the user name and email of your commit are not your github config (may be some private git config) and you did not signoff yourself.

Please first git config user.name "YOUR_GITHUB_NAME" and git config user.email "YOUR_GITHUB_EMAIL" in your local kruise repo. Then git commit -s --amend and force push again.

Signed-off-by: hatowang <[email protected]>

add leader metric for kruise_manager.
@hatowang
Copy link
Contributor Author

hatowang commented Mar 3, 2022

@hatowang Thanks. It seems the user name and email of your commit are not your github config (may be some private git config) and you did not signoff yourself.

Please first git config user.name "YOUR_GITHUB_NAME" and git config user.email "YOUR_GITHUB_EMAIL" in your local kruise repo. Then git commit -s --amend and force push again.

ok

Copy link
Member

@FillZpp FillZpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FillZpp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit 9e20bcd into openkruise:master Mar 3, 2022
ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024
add leader metric for kruise_manager.

Co-authored-by: wangyeyu.wyy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants