-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add kruise_manager_is_leader metric #917
Conversation
Welcome @hatowang! It looks like this is your first PR to openkruise/kruise 🎉 |
Codecov Report
@@ Coverage Diff @@
## master #917 +/- ##
==========================================
- Coverage 49.37% 49.20% -0.18%
==========================================
Files 119 119
Lines 11102 11102
==========================================
- Hits 5482 5463 -19
- Misses 4786 4799 +13
- Partials 834 840 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@hatowang Thanks. It seems the user name and email of your commit are not your github config (may be some private git config) and you did not signoff yourself. Please first |
Signed-off-by: hatowang <[email protected]> add leader metric for kruise_manager.
ok |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FillZpp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
add leader metric for kruise_manager. Co-authored-by: wangyeyu.wyy <[email protected]>
Ⅰ. Describe what this PR does
add leader metric for kruise_manager.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews