-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support StatefulSetAutoDeletePVC feature #882
Conversation
Codecov Report
@@ Coverage Diff @@
## master #882 +/- ##
==========================================
+ Coverage 49.46% 50.01% +0.55%
==========================================
Files 119 119
Lines 11312 11527 +215
==========================================
+ Hits 5595 5765 +170
- Misses 4856 4892 +36
- Partials 861 870 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
9d48b9c
to
8cdfa31
Compare
Signed-off-by: veophi <[email protected]>
Signed-off-by: veophi <[email protected]>
Signed-off-by: veophi <[email protected]>
eb91c7c
to
879fc99
Compare
Signed-off-by: veophi <[email protected]>
Signed-off-by: veophi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FillZpp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Add StatefulSetAutoDeletePVC feature gate * statefulset PersistentVolumeClaimDeletePolicy api change * controller change for statefulset auto-delete (implementation) * controller change for statefulset auto-delete (tests) * fix the underlying pollution to informer in statefulset controller Co-authored-by: Matthew Cary <[email protected]>
Ⅰ. Describe what this PR does
Cherry pick from kubernetes/kubernetes#99728.
Ⅱ. Does this pull request fix one issue?
fixes #813