Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add featureGate to enable restartPolicy onFailure for CloneSet #799

Conversation

FillZpp
Copy link
Member

@FillZpp FillZpp commented Nov 10, 2021

Signed-off-by: FillZpp [email protected]

Ⅰ. Describe what this PR does

Add featureGate to enable restartPolicy onFailure for CloneSet

Ⅱ. Does this pull request fix one issue?

fixes #794

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign fillzpp
You can assign the PR to them by writing /assign @fillzpp in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot added the size/L size/L: 100-499 label Nov 10, 2021
@FillZpp FillZpp force-pushed the add-featuregate-to-allow-no-always-restartPolicy-for-cloneset branch from aa6c432 to e404d3a Compare November 10, 2021 07:33
@FillZpp
Copy link
Member Author

FillZpp commented Dec 7, 2021

/hold

@FillZpp
Copy link
Member Author

FillZpp commented Dec 7, 2021

/woof

@kruise-bot
Copy link

@FillZpp: dog image

In response to this:

/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@FillZpp
Copy link
Member Author

FillZpp commented Feb 10, 2022

closed by #794

@FillZpp FillZpp closed this Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] CloneSet validating webhook requests pod with restartPolicy onFailure even though it is supported
2 participants