-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cloneset revision update #1549
Conversation
Welcome @qswksp! It looks like this is your first PR to openkruise/kruise 🎉 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1549 +/- ##
==========================================
+ Coverage 47.90% 47.97% +0.06%
==========================================
Files 162 162
Lines 23491 23491
==========================================
+ Hits 11254 11270 +16
+ Misses 11017 11005 -12
+ Partials 1220 1216 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
1c62367
to
f8898bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@qswksp Can you squash the commit? |
Signed-off-by: suhe <[email protected]>
233062c
to
13bf940
Compare
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zmberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: suhe <[email protected]>
Signed-off-by: suhe <[email protected]>
Signed-off-by: suhe <[email protected]>
Ⅰ. Describe what this PR does
#1545
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews