[Proposal] Add proposal for adding progressDeadlineSeconds in CloneSet #1520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hantmac
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1520 +/- ##
==========================================
+ Coverage 47.91% 49.41% +1.50%
==========================================
Files 162 183 +21
Lines 23491 18997 -4494
==========================================
- Hits 11256 9388 -1868
+ Misses 11014 8385 -2629
- Partials 1221 1224 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
furykerry
reviewed
Mar 14, 2024
docs/proposals/20240309-cloneset-support-progressDeadlineSeconds.md
Outdated
Show resolved
Hide resolved
hantmac
force-pushed
the
feat/cloneset-progressDeadlineSeconds-proposal
branch
from
79cb889 to
16eaf6c
Compare
|
@furykerry the proposal is read for review 😄 |
furykerry
reviewed
Jul 8, 2024
docs/proposals/20240309-cloneset-support-progressDeadlineSeconds.md
Outdated
Show resolved
Hide resolved
docs/proposals/20240309-cloneset-support-progressDeadlineSeconds.md
Outdated
Show resolved
Hide resolved
furykerry
reviewed
Jul 18, 2024
hantmac
force-pushed
the
feat/cloneset-progressDeadlineSeconds-proposal
branch
from
90bcde9 to
d01d64a
Compare
Thanks. Squashed. |
Signed-off-by: hantmac <[email protected]> more docs Signed-off-by: hantmac <[email protected]> fix mdl ci Signed-off-by: hantmac <[email protected]> complete the proposal Signed-off-by: hantmac <[email protected]> fix Signed-off-by: hantmac <[email protected]> update Signed-off-by: hantmac <[email protected]> fix typo Signed-off-by: hantmac <[email protected]> Bump crate-ci/typos from 1.22.9 to 1.23.1 (openkruise#1658) Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.22.9 to 1.23.1. - [Release notes](https://github.com/crate-ci/typos/releases) - [Changelog](https://github.com/crate-ci/typos/blob/master/CHANGELOG.md) - [Commits](crate-ci/typos@v1.22.9...v1.23.1) --- updated-dependencies: - dependency-name: crate-ci/typos dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Bump actions/upload-artifact from 4.3.3 to 4.3.4 (openkruise#1659) Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.3.3 to 4.3.4. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@6546280...0b2256b) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> changed the scorecard badge link to the standard format and updated the domain (openkruise#1657) Signed-off-by: harshitasao <[email protected]> fix typo Signed-off-by: hantmac <[email protected]>
hantmac
force-pushed
the
feat/cloneset-progressDeadlineSeconds-proposal
branch
from
b7541eb to
fa87578
Compare
|
@zmberg PTAL |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zmberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
Add proposal for support progressDeadlineSeconds in CloneSet
Ⅱ. Does this pull request fix one issue?
To fix #1468
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews