Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenSSF Scorecard #1445

Merged
merged 1 commit into from
Nov 22, 2023
Merged

OpenSSF Scorecard #1445

merged 1 commit into from
Nov 22, 2023

Conversation

zmberg
Copy link
Member

@zmberg zmberg commented Nov 6, 2023

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

Signed-off-by: liheng.zms <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #1445 (aa3f92f) into master (aafd16b) will increase coverage by 0.05%.
Report is 1 commits behind head on master.
The diff coverage is 81.08%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master    #1445      +/-   ##
==========================================
+ Coverage   48.32%   48.37%   +0.05%     
==========================================
  Files         154      154              
  Lines       21654    21679      +25     
==========================================
+ Hits        10464    10488      +24     
+ Misses      10040    10039       -1     
- Partials     1150     1152       +2     
Flag Coverage Δ
unittests 48.37% <81.08%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...er/imagelistpulljob/imagelistpulljob_controller.go 61.32% <81.08%> (+0.25%) ⬆️

... and 1 file with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link
Member

@furykerry furykerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@furykerry
Copy link
Member

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furykerry

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit 7bcaa1b into openkruise:master Nov 22, 2023
21 checks passed
ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants