Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix invalid image #1198

Merged
merged 1 commit into from
Mar 2, 2023
Merged

Conversation

chengleqi
Copy link
Contributor

Ⅰ. Describe what this PR does

Fix invalid image

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

I try the UnitedDeployment that has been repaired and it worked.
image

Ⅳ. Special notes for reviews

Signed-off-by: chengleqi <[email protected]>
@kruise-bot kruise-bot requested review from furykerry and zmberg March 1, 2023 08:51
@kruise-bot
Copy link

Welcome @chengleqi! It looks like this is your first PR to openkruise/kruise 🎉

@kruise-bot kruise-bot added the size/XS size/XS: 0-9 label Mar 1, 2023
@veophi
Copy link
Member

veophi commented Mar 1, 2023

/lgtm

@codecov-commenter
Copy link

Codecov Report

Merging #1198 (8b0a6ea) into master (1b3641d) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##           master    #1198   +/-   ##
=======================================
  Coverage   50.04%   50.04%           
=======================================
  Files         143      143           
  Lines       19906    19906           
=======================================
  Hits         9962     9962           
  Misses       8849     8849           
  Partials     1095     1095           
Flag Coverage Δ
unittests 50.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zmberg
Copy link
Member

zmberg commented Mar 2, 2023

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zmberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit e8c873a into openkruise:master Mar 2, 2023
@chengleqi chengleqi deleted the fix-invalid branch March 2, 2023 01:38
ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants