Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change Kruise leader election from configmap to configmapsleases #1193

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

YTGhost
Copy link
Contributor

@YTGhost YTGhost commented Feb 25, 2023

Ⅰ. Describe what this PR does

fixes #1184

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@kruise-bot
Copy link

Welcome @YTGhost! It looks like this is your first PR to openkruise/kruise 🎉

@kruise-bot kruise-bot added the size/S size/S 10-29 label Feb 25, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2023

Codecov Report

Merging #1193 (25947d3) into master (85a9542) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##           master    #1193   +/-   ##
=======================================
  Coverage   49.76%   49.76%           
=======================================
  Files         138      138           
  Lines       19554    19554           
=======================================
  Hits         9731     9731           
  Misses       8755     8755           
  Partials     1068     1068           
Flag Coverage Δ
unittests 49.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@YTGhost YTGhost force-pushed the change-leader-election branch from ab97599 to dc33a73 Compare February 25, 2023 15:58
@kruise-bot kruise-bot added size/M size/M: 30-99 and removed size/S size/S 10-29 labels Feb 25, 2023
@YTGhost YTGhost force-pushed the change-leader-election branch from dc33a73 to 99abfd3 Compare February 26, 2023 01:18
@YTGhost YTGhost force-pushed the change-leader-election branch from 99abfd3 to 25947d3 Compare February 26, 2023 13:17
@YTGhost
Copy link
Contributor Author

YTGhost commented Feb 26, 2023

@zmberg PTAL

@zmberg
Copy link
Member

zmberg commented Feb 27, 2023

/lgtm

@zmberg
Copy link
Member

zmberg commented Feb 27, 2023

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zmberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit e70c146 into openkruise:master Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] Change Kruise leader election from configmap to configmapsleases.
4 participants