Allow to mutate PVCTemplate of Advanced StatefulSet & CloneSet #1118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veophi
force-pushed
the
allow-mutate-pvc-template
branch
2 times, most recently
from
a4bb531 to
d4f1870
Compare
veophi
changed the title
furykerry
reviewed
Nov 16, 2022
Signed-off-by: mingzhou.swx <[email protected]>
veophi
force-pushed
the
allow-mutate-pvc-template
branch
from
d4f1870 to
e1d1457
Compare
|
@veophi I have a question that if controller should update controllerrevision to record the pvc template's change. |
|
@willise These actions are already in our planning, but this pr only allow users modify the pvcTemplate manually. |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: furykerry The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ppbits
pushed a commit
to ppbits/kruise
that referenced
this pull request
Apr 4, 2024
Co-authored-by: mingzhou.swx <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: mingzhou.swx [email protected]
Ⅰ. Describe what this PR does
Allow to mutate PVCTemplate of Advanced StatefulSet & CloneSet.