Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce update pod condition operations #1074

Merged
merged 1 commit into from
Sep 14, 2022
Merged

Reduce update pod condition operations #1074

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions pkg/util/inplaceupdate/inplace_update.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,10 @@ func (c *realControl) updateCondition(pod *v1.Pod, condition v1.PodCondition) er
return err
}

if hasEqualCondition(clone, &condition) {
return nil
}

util.SetPodCondition(clone, condition)
// We only update the ready condition to False, and let Kubelet update it to True
if condition.Status == v1.ConditionFalse {
Expand Down Expand Up @@ -408,3 +412,10 @@ func doPreCheckBeforeNext(pod *v1.Pod, preCheck *appspub.InPlaceUpdatePreCheckBe
}
return nil
}

func hasEqualCondition(pod *v1.Pod, newCondition *v1.PodCondition) bool {
oldCondition := util.GetCondition(pod, newCondition.Type)
isEqual := oldCondition != nil && oldCondition.Status == newCondition.Status &&
oldCondition.Reason == newCondition.Reason && oldCondition.Message == newCondition.Message
return isEqual
}