feat: add PersistentPodState custom workload support #1063

baxiaoshi · 2022-08-24T01:44:26Z

Ⅰ. Describe what this PR does

PPS(PersistentPodState) currently has support for standard statefulset and kruise's statefulSet. However, some companies will customize workloads(statefulset like) with stable identification pods, support such workloads, and add support for custom workloads to pps.

kruise-bot · 2022-08-24T01:44:42Z

Welcome @baxiaoshi! It looks like this is your first PR to openkruise/kruise 🎉

codecov-commenter · 2022-08-24T01:54:57Z

Codecov Report

Merging #1063 (6033887) into master (bdd3efb) will decrease coverage by 1.08%.
The diff coverage is 40.36%.

❗ Current head 6033887 differs from pull request most recent head 0f47468. Consider uploading reports for the commit 0f47468 to get more accurate results

@@            Coverage Diff             @@
##           master    #1063      +/-   ##
==========================================
- Coverage   50.36%   49.28%   -1.09%     
==========================================
  Files         125      137      +12     
  Lines       17637    19410    +1773     
==========================================
+ Hits         8883     9566     +683     
- Misses       7782     8790    +1008     
- Partials      972     1054      +82

Flag	Coverage Δ
unittests	`49.28% <40.36%> (-1.09%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/control/pubcontrol/pub_control.go	`26.21% <0.00%> (ø)`
pkg/control/pubcontrol/pub_control_utils.go	`52.02% <0.00%> (ø)`
pkg/control/sidecarcontrol/history_control.go	`0.00% <0.00%> (ø)`
...ontroller/daemonset/daemonset_predownload_image.go	`0.00% <0.00%> (ø)`
pkg/controller/daemonset/daemonset_update.go	`57.36% <0.00%> (-0.93%)`	⬇️
...troller/nodepodprobe/nodepodprobe_event_handler.go	`0.00% <0.00%> (ø)`
...tentpodstate/persistent_pod_state_event_handler.go	`0.00% <0.00%> (ø)`
...ler/podprobemarker/podprobemarker_event_handler.go	`0.00% <0.00%> (ø)`
...availablebudget/podunavailablebudget_controller.go	`39.22% <0.00%> (ø)`
...ller/podunavailablebudget/pub_pod_event_handler.go	`26.47% <0.00%> (ø)`
... and 54 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

furykerry · 2022-08-24T03:05:04Z

docs/proposals/20220824-persistentpodstate-custom-workload-support.md

+1）Get the APIResourceList  in the cluster through the ServerPreferredResources interface of the dynamic client. Because we can't distinguish those workloads, we can only watch all of them here, which will have a lot of unnecessary watch overhead.
+2）Find the corresponding workload by the reverse of the pod's ownerReferences. There is a time delay.
+
+It is recommended to use method 2 to get the owner's gvk by reverse lookup and create Informer if there is no watch before.


PPS rely on the ordinal maintenance of statefulset, and actually pps can works for statefulset-like workload how to ensure custom workload can provide similar capability and avoid incorrect usage? maybe adding a new config in kruise-configuration configmaps

Add PPS_Watch_Custom_Workload_WhiteList in kruise-configuration to declare the Workload that needs to be watched

furykerry

/lgtm

sonatype-lift · 2022-09-20T09:25:56Z

pkg/controller/persistentpodstate/persistent_pod_state_event_handler.go

+	}
+
+	// 2.add watch
+	for gvk, _ := range ownerReferencesGVK {


S1005: unnecessary assignment to the blank identifier

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-09-20T09:25:58Z

test/e2e/framework/persistent_pod_state_util.go

+	}
+
+	cli := s.createStatefulSetLikeCli(sts.Namespace)
+	data, err := cli.Get(context.TODO(), sts.Name, metav1.GetOptions{})


SA4006: this value of err is never used

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-09-20T09:25:59Z

pkg/controller/persistentpodstate/persistent_pod_state_event_handler.go

+	}
+
+	// 2.add watch
+	for gvk, _ := range ownerReferencesGVK {


gofmt: File is not gofmt-ed with -s

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-09-20T09:26:01Z

pkg/util/controllerfinder/controller_finder.go

@@ -90,6 +92,22 @@
 	UID types.UID `json:"uid" protobuf:"bytes,4,opt,name=uid,casttype=k8s.io/apimachinery/pkg/types.UID"`
 }



💬 2 similar findings have been found in this PR

U1000: type statefulSetLike is unused

🔎 Expand here to view all instances of this finding

File Path Line Number

pkg/util/controllerfinder/controller_finder.go 101

pkg/util/controllerfinder/controller_finder.go 107

Visit the Lift Web Console to find more details in your report.

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-09-20T09:26:03Z

pkg/controller/util/watch.go

@@ -0,0 +1,67 @@
+package util
+
+import (


💬 2 similar findings have been found in this PR

goimports: File is not goimports-ed

🔎 Expand here to view all instances of this finding

File Path Line Number

pkg/util/controllerfinder/controller_finder.go 20

pkg/controller/persistentpodstate/persistent_pod_state_event_handler.go 22

Visit the Lift Web Console to find more details in your report.

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

veophi · 2022-09-21T02:15:24Z

pkg/controller/util/watch.go

+		return false, nil
+	}
+
+	if _, ok := watcherMap.Load(gvk); ok {


plz swap this line with DiscoverGVK

sonatype-lift · 2022-09-27T01:57:23Z

pkg/util/controllerfinder/controller_finder.go

@@ -90,6 +93,22 @@ type ControllerReference struct {
 	UID types.UID `json:"uid" protobuf:"bytes,4,opt,name=uid,casttype=k8s.io/apimachinery/pkg/types.UID"`
 }

+type statefulSetLike struct {


💬 2 similar findings have been found in this PR

U1000: type statefulSetLike is unused

🔎 Expand here to view all instances of this finding

File Path Line Number

pkg/util/controllerfinder/controller_finder.go 102

pkg/util/controllerfinder/controller_finder.go 108

Visit the Lift Web Console to find more details in your report.

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-09-27T04:37:41Z

pkg/util/configuration/configuration.go

@@ -19,6 +19,7 @@ package configuration
 import (
 	"context"
 	"encoding/json"


💬 2 similar findings have been found in this PR

goimports: File is not goimports-ed

🔎 Expand here to view all instances of this finding

File Path Line Number

pkg/webhook/persistentpodstate/validating/persistent_create_update_handler.go 22

pkg/webhook/persistentpodstate/validating/persistent_validating_test.go 21

Visit the Lift Web Console to find more details in your report.

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-10-04T03:55:30Z

pkg/webhook/pod/mutating/persistent_pod_state.go

+
+	whiteList, err := configuration.GetPPSWatchWatchCustomWorkloadWhiteList(h.Client)
+	if err != nil {
+		err = fmt.Errorf("Failed to get persistent pod state config white list, error: %v\n", err.Error())


ST1005: error strings should not be capitalized

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-10-04T03:55:31Z

pkg/webhook/pod/mutating/persistent_pod_state.go

+
+	whiteList, err := configuration.GetPPSWatchWatchCustomWorkloadWhiteList(h.Client)
+	if err != nil {
+		err = fmt.Errorf("Failed to get persistent pod state config white list, error: %v\n", err.Error())


ST1005: error strings should not end with punctuation or newlines

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-10-05T02:04:13Z

pkg/webhook/pod/mutating/persistent_pod_state.go

+
+	whiteList, err := configuration.GetPPSWatchWatchCustomWorkloadWhiteList(h.Client)
+	if err != nil {
+		err = fmt.Errorf("failed to get persistent pod state config white list, error: %v\n", err.Error())


ST1005: error strings should not end with punctuation or newlines

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-10-11T04:17:15Z

pkg/webhook/pod/mutating/persistent_pod_state.go

@@ -17,11 +17,11 @@
 package mutating

 import (


goimports: File is not goimports-ed

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

zmberg · 2022-10-17T09:13:55Z

apis/apps/v1alpha1/persistent_pod_state_types.go

@@ -44,6 +48,9 @@ type PersistentPodStateSpec struct {
 	// current only support StatefulSet
 	TargetReference TargetReference `json:"targetRef"`

+	// Persist the annotations information of the pods that need to be saved
+	PersistentPodAnnotations []string `json:"persistentPodAnnotations,omitempty"`


// PersistentPodStateSpec defines the desired state of PersistentPodState type PersistentPodStateSpec struct { PersistentPodAnnotations []PersistentPodAnnotation `json:"persistentPodAnnotations,omitempty"` } type PersistentPodAnnotation struct { Key string `json:"key"` }

zmberg · 2022-10-21T06:00:36Z

pkg/controller/persistentpodstate/persistent_pod_state_event_handler.go

+			continue
+		}
+
+		_, err := util.AddWatcherDynamically(runtimeController, workloadHandler, gvk)


It is recommended not to implement the watch dynamic crd method in the event handler, but in reconcile, please refer to: https://github.com/openkruise/rollouts/blob/master/pkg/controller/batchrelease/ batchrelease_controller.go#L165

zmberg · 2022-10-21T06:07:27Z

pkg/controller/persistentpodstate/persistent_pod_state_event_handler.go

+	od, _ := json.Marshal(oWorkload)
+	nd, _ := json.Marshal(nWorkload)
+	klog.V(3).Infof("enqueueRequestForStatefulSetLike(%s) old workload", oWorkload.GetName(), string(od))
+	klog.V(3).Infof("enqueueRequestForStatefulSetLike(%s) new workload", oWorkload.GetName(), string(nd))


These two logs remove it, it is estimated that will brush the screen.

zmberg · 2022-10-21T06:10:19Z

pkg/controller/persistentpodstate/persistent_pod_state_event_handler.go

+		}
+	}
+
+	if nAnnotations[appsv1alpha1.AnnotationAutoGeneratePersistentPodState] == "true" &&


Can this be removed?

zmberg · 2022-10-21T06:11:23Z

pkg/util/configuration/configuration.go

@@ -20,6 +20,8 @@ import (
 	"context"
 	"encoding/json"

+	v1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+


go imports -ed

zmberg · 2022-10-21T06:18:25Z

pkg/webhook/persistentpodstate/validating/persistent_create_update_handler.go

-		allErrs = append(allErrs, field.Invalid(fldPath.Child("TargetReference"), spec.TargetReference, "TargetReference.Kind must be StatefulSet"))
+
+	apiVersion, kind := spec.TargetReference.APIVersion, spec.TargetReference.Kind
+	if spec.TargetReference.Kind != "StatefulSet" && !whiteList.ValidateAPIVersionAndKind(apiVersion, kind) {


I think not the native or kruise StatefulSet, all other CRD(e.g. other StatefulSet) should judge whiteList.

zmberg · 2022-10-21T06:18:49Z

pkg/webhook/persistentpodstate/validating/persistent_validating_test.go

@@ -20,6 +20,8 @@ import (
 	"context"
 	"testing"

+	corev1 "k8s.io/api/core/v1"
+


go imports -ed

zmberg · 2022-10-21T06:21:31Z

pkg/webhook/pod/mutating/persistent_pod_state.go

 	ref := metav1.GetControllerOf(pod)
-	if ref == nil || ref.Kind != "StatefulSet" {
+	if ref == nil || (ref.Kind != "StatefulSet" && !whiteList.ValidateAPIVersionAndKind(ref.APIVersion, ref.Kind)) {


If Custom Kind StatefulSet but not in whitelist, i think should skip the webhook.

veophi · 2022-11-11T06:44:12Z

pkg/controller/persistentpodstate/persistent_pod_state_controller.go

@@ -23,6 +23,10 @@ import (
 	"strconv"
 	"strings"

+	"github.com/openkruise/kruise/pkg/util/configuration"
+


plz format import

veophi · 2022-11-11T06:46:27Z

pkg/controller/persistentpodstate/persistent_pod_state_event_handler.go

@@ -20,16 +20,20 @@ import (
 	"context"
 	"fmt"

+	"github.com/openkruise/kruise/pkg/util/configuration"
+
+	"k8s.io/klog/v2"


plz format imports

veophi · 2022-11-11T06:51:34Z

pkg/controller/util/watch.go

+
+var watcherMap = sync.Map{}
+
+func DiscoverGVK(gvk schema.GroupVersionKind) bool {


this func has been defined in [pkg/util/discovery/discovery.go](https://github.com/openkruise/kruise/blob/14e21f5bcfd40790861e6db3dc75655c9c37b189/pkg/util/discovery/discovery.go)

veophi · 2022-11-11T06:53:18Z

pkg/util/configuration/configuration.go

@@ -49,12 +51,30 @@ func GetSidecarSetPatchMetadataWhiteList(client client.Client) (*SidecarSetPatch
 	return whiteList, nil
 }

+func GetPPSWatchWatchCustomWorkloadWhiteList(client client.Client) (*PPSWatchWatchCustomWorkloadWhiteList, error) {
+	whiteList := &PPSWatchWatchCustomWorkloadWhiteList{Workloads: make([]schema.GroupVersionKind, 0)}
+	data, err := getKruiseConfiguration(client)


Maybe, we can just initialize the whiteList in a init function at the moment of kruise starting?

veophi · 2022-11-11T06:56:14Z

Very awesome work, thanks! @baxiaoshi

Signed-off-by: peng.xin <[email protected]>

zmberg · 2022-12-09T07:07:31Z

/lgtm

furykerry · 2022-12-09T07:14:16Z

/approve

kruise-bot · 2022-12-09T07:14:23Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furykerry

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [furykerry]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Co-authored-by: peng.xin <[email protected]>

kruise-bot requested review from Fei-Guo and furykerry August 24, 2022 01:44

kruise-bot added the size/L size/L: 100-499 label Aug 24, 2022

furykerry reviewed Aug 24, 2022

View reviewed changes

furykerry reviewed Aug 30, 2022

View reviewed changes

kruise-bot assigned furykerry Aug 30, 2022

kruise-bot added lgtm and removed lgtm labels Aug 30, 2022

baxiaoshi force-pushed the master branch from cd5524d to 62b230e Compare September 20, 2022 09:13

kruise-bot added size/XL size/XL: 500-999 and removed size/L size/L: 100-499 labels Sep 20, 2022

sonatype-lift bot reviewed Sep 20, 2022

View reviewed changes

veophi reviewed Sep 21, 2022

View reviewed changes

sonatype-lift bot reviewed Sep 27, 2022

View reviewed changes

baxiaoshi force-pushed the master branch 2 times, most recently from c6625e5 to 5a0f954 Compare September 28, 2022 02:57

sonatype-lift bot reviewed Oct 4, 2022

View reviewed changes

sonatype-lift bot reviewed Oct 5, 2022

View reviewed changes

sonatype-lift bot reviewed Oct 11, 2022

View reviewed changes

zmberg reviewed Oct 17, 2022

View reviewed changes

zmberg reviewed Oct 21, 2022

View reviewed changes

kruise-bot added size/XXL and removed size/XL size/XL: 500-999 labels Nov 9, 2022

veophi reviewed Nov 11, 2022

View reviewed changes

baxiaoshi force-pushed the master branch 2 times, most recently from 6033887 to 0f47468 Compare November 21, 2022 09:11

baxiaoshi force-pushed the master branch from 0f47468 to 0fd6509 Compare December 7, 2022 13:14

feat: add PersistentPodState custom workload support

77f2d1e

Signed-off-by: peng.xin <[email protected]>

baxiaoshi force-pushed the master branch from 0fd6509 to 77f2d1e Compare December 8, 2022 07:07

kruise-bot assigned zmberg Dec 9, 2022

kruise-bot added the lgtm label Dec 9, 2022

kruise-bot added the approved label Dec 9, 2022

kruise-bot merged commit cdb3b02 into openkruise:master Dec 9, 2022

zmberg added this to the v1.4 milestone Feb 14, 2023

zmberg added the kind/enhancement New feature or request label Feb 14, 2023

ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024

feat: add PersistentPodState custom workload support (openkruise#1063)

31f6f9d

Co-authored-by: peng.xin <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add PersistentPodState custom workload support #1063

feat: add PersistentPodState custom workload support #1063

baxiaoshi commented Aug 24, 2022

kruise-bot commented Aug 24, 2022

codecov-commenter commented Aug 24, 2022 •

edited

Loading

furykerry Aug 24, 2022

baxiaoshi Aug 25, 2022

furykerry left a comment

sonatype-lift bot Sep 20, 2022

sonatype-lift bot Sep 20, 2022

sonatype-lift bot Sep 20, 2022

sonatype-lift bot Sep 20, 2022

sonatype-lift bot Sep 20, 2022

veophi Sep 21, 2022

sonatype-lift bot Sep 27, 2022

sonatype-lift bot Sep 27, 2022

sonatype-lift bot Oct 4, 2022

sonatype-lift bot Oct 4, 2022

sonatype-lift bot Oct 5, 2022

sonatype-lift bot Oct 11, 2022

zmberg Oct 17, 2022 •

edited

Loading

zmberg Oct 21, 2022

zmberg Oct 21, 2022

zmberg Oct 21, 2022

zmberg Oct 21, 2022

zmberg Oct 21, 2022

zmberg Oct 21, 2022

zmberg Oct 21, 2022

veophi Nov 11, 2022

veophi Nov 11, 2022

veophi Nov 11, 2022

veophi Nov 11, 2022

veophi commented Nov 11, 2022 •

edited

Loading

zmberg commented Dec 9, 2022

furykerry commented Dec 9, 2022

kruise-bot commented Dec 9, 2022

Command	Usage
`@sonatype-lift ignore`	Leave out the above finding from this PR
`@sonatype-lift ignoreall`	Leave out all the existing findings from this PR
`@sonatype-lift exclude <file\|issue\|path\|tool>`	Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file

		@@ -90,6 +92,22 @@
		UID types.UID `json:"uid" protobuf:"bytes,4,opt,name=uid,casttype=k8s.io/apimachinery/pkg/types.UID"`
		}


		var watcherMap = sync.Map{}

		func DiscoverGVK(gvk schema.GroupVersionKind) bool {

feat: add PersistentPodState custom workload support #1063

feat: add PersistentPodState custom workload support #1063

Conversation

baxiaoshi commented Aug 24, 2022

Ⅰ. Describe what this PR does

kruise-bot commented Aug 24, 2022

codecov-commenter commented Aug 24, 2022 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

furykerry left a comment

Choose a reason for hiding this comment

sonatype-lift bot Sep 20, 2022

Choose a reason for hiding this comment

sonatype-lift bot Sep 20, 2022

Choose a reason for hiding this comment

sonatype-lift bot Sep 20, 2022

Choose a reason for hiding this comment

sonatype-lift bot Sep 20, 2022

Choose a reason for hiding this comment

sonatype-lift bot Sep 20, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonatype-lift bot Sep 27, 2022

Choose a reason for hiding this comment

sonatype-lift bot Sep 27, 2022

Choose a reason for hiding this comment

sonatype-lift bot Oct 4, 2022

Choose a reason for hiding this comment

sonatype-lift bot Oct 4, 2022

Choose a reason for hiding this comment

sonatype-lift bot Oct 5, 2022

Choose a reason for hiding this comment

sonatype-lift bot Oct 11, 2022

Choose a reason for hiding this comment

zmberg Oct 17, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

veophi commented Nov 11, 2022 • edited Loading

zmberg commented Dec 9, 2022

furykerry commented Dec 9, 2022

kruise-bot commented Dec 9, 2022

codecov-commenter commented Aug 24, 2022 •

edited

Loading

zmberg Oct 17, 2022 •

edited

Loading

veophi commented Nov 11, 2022 •

edited

Loading