Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize Dockerfile for multi-arch #1052

Merged

Conversation

FillZpp
Copy link
Member

@FillZpp FillZpp commented Aug 8, 2022

Signed-off-by: FillZpp [email protected]

Ⅰ. Describe what this PR does

Optimize Dockerfile for multi-arch

Ⅱ. Does this pull request fix one issue?

fixes #970

@kruise-bot kruise-bot requested review from Fei-Guo and furykerry August 8, 2022 07:11
@kruise-bot kruise-bot added the size/S size/S 10-29 label Aug 8, 2022
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
@FillZpp FillZpp force-pushed the optimize-dockerfile-for-multi-arch branch from 73adc0f to 715062a Compare August 8, 2022 07:27
@kruise-bot kruise-bot added size/M size/M: 30-99 and removed size/S size/S 10-29 labels Aug 8, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1052 (715062a) into master (4263a74) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1052      +/-   ##
==========================================
+ Coverage   49.30%   49.32%   +0.01%     
==========================================
  Files         125      125              
  Lines       12355    12355              
==========================================
+ Hits         6092     6094       +2     
+ Misses       5322     5321       -1     
+ Partials      941      940       -1     
Flag Coverage Δ
unittests 49.32% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/controller/cloneset/cloneset_status.go 90.00% <0.00%> (+5.00%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Member

@furykerry furykerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@furykerry
Copy link
Member

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furykerry

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit 2319654 into openkruise:master Aug 9, 2022
diannaowa pushed a commit to diannaowa/kruise that referenced this pull request Sep 14, 2022
ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

能否在hub仓库中提供下ppc64le架构的镜像
4 participants