WorkloadSpread support StatefulSet #1042
Conversation
Signed-off-by: mingzhou.swx <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
| gomega.Expect(replicasForSubsetB).To(gomega.Equal(int32(3))) | ||
|
|
||
| ginkgo.By("List pods of cloneset and check their patch...") | ||
| pods, err := tester.GetSelectorPods(ns, statefulSet.Spec.Selector) |
There was a problem hiding this comment.
SA4006: this value of err is never used
Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.
When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
|
@veophi: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
duplicate with #1056? |
Signed-off-by: mingzhou.swx [email protected]
Ⅰ. Describe what this PR does