SidecarSet inject history revision #1021

veophi · 2022-07-14T04:17:32Z

Signed-off-by: mingzhou.swx [email protected]

Ⅰ. Describe what this PR does

Allow SidecarSet inject specific history sidecar to Pods.
issue: #783

Ⅱ. Does this pull request fix one issue?

fixes #710

sonatype-lift · 2022-07-14T04:32:59Z

pkg/webhook/pod/mutating/sidecarset_test.go

+	podIn := pod1.DeepCopy()
+	podOut := podIn.DeepCopy()
+	decoder, _ := admission.NewDecoder(scheme.Scheme)
+	client := fake.NewFakeClient(env...)


SA1019: fake.NewFakeClient is deprecated: Please use NewClientBuilder instead.

Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-07-14T04:33:00Z

pkg/webhook/sidecarset/validating/sidecarset_validating_test.go

 	}

 	for name, sidecarSet := range errorCases {
-		allErrs := validateSidecarSetSpec(&sidecarSet, field.NewPath("spec"))
+		fakeClient := fake.NewFakeClientWithScheme(testScheme, SidecarSetRevisions...)


SA1019: fake.NewFakeClientWithScheme is deprecated: Please use NewClientBuilder instead.

Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-07-14T04:33:02Z

pkg/webhook/pod/mutating/sidecarset.go

@@ -20,19 +20,20 @@
 	"context"
 	"encoding/json"
 	"fmt"


goimports: File is not goimports-ed

Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

codecov-commenter · 2022-07-14T08:10:10Z

Codecov Report

Merging #1021 (d7f3fa3) into master (c29b0c1) will decrease coverage by 0.48%.
The diff coverage is 18.71%.

@@            Coverage Diff             @@
##           master    #1021      +/-   ##
==========================================
- Coverage   49.63%   49.15%   -0.49%     
==========================================
  Files         124      124              
  Lines       12078    12253     +175     
==========================================
+ Hits         5995     6023      +28     
- Misses       5167     5306     +139     
- Partials      916      924       +8

Flag	Coverage Δ
unittests	`49.15% <18.71%> (-0.49%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/control/sidecarcontrol/hash.go	`0.00% <0.00%> (ø)`
pkg/control/sidecarcontrol/history_control.go	`0.00% <0.00%> (ø)`
pkg/control/sidecarcontrol/util.go	`49.03% <ø> (ø)`
...troller/sidecarset/sidecarset_pod_event_handler.go	`63.15% <0.00%> (-3.51%)`	⬇️
pkg/controller/sidecarset/sidecarset_processor.go	`65.67% <15.00%> (-4.33%)`	⬇️
pkg/webhook/pod/mutating/sidecarset.go	`61.50% <22.80%> (-13.21%)`	⬇️
...set/validating/sidecarset_create_update_handler.go	`52.60% <63.63%> (+1.44%)`	⬆️
...arset/mutating/sidecarset_create_update_handler.go	`23.33% <100.00%> (ø)`
pkg/controller/uniteddeployment/revision.go	`66.41% <0.00%> (-1.53%)`	⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c29b0c1...d7f3fa3. Read the comment docs.

zmberg · 2022-07-14T08:07:59Z

apis/apps/defaults/v1alpha1.go

+
+func SetDefaultInjectRevision(strategy *v1alpha1.SidecarSetInjectionStrategy) {
+	if strategy.Revision != nil {
+		if len(strategy.Revision.Policy) == 0 {


if strategy.Revision.Policy == “”

apis/apps/defaults/v1alpha1.go

pkg/controller/sidecarset/sidecarset_processor.go

pkg/webhook/pod/mutating/sidecarset.go

pkg/control/sidecarcontrol/history_control.go

veophi · 2022-07-15T03:51:27Z

/cc @pigletfly

kruise-bot · 2022-07-15T03:51:29Z

@veophi: GitHub didn't allow me to request PR reviews from the following users: pigletfly.

Note that only openkruise members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @pigletfly

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

veophi · 2022-07-15T03:52:22Z

/cc @willise

kruise-bot · 2022-07-15T03:52:23Z

@veophi: GitHub didn't allow me to request PR reviews from the following users: willise.

Note that only openkruise members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @willise

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

apis/apps/v1alpha1/sidecarset_types.go

pkg/control/sidecarcontrol/hash.go

pkg/control/sidecarcontrol/util.go

pkg/controller/sidecarset/sidecarset_processor.go

pkg/control/sidecarcontrol/history_control.go

FillZpp · 2022-07-19T06:34:57Z

/lgtm

pkg/webhook/pod/mutating/sidecarset.go

Signed-off-by: mingzhou.swx <[email protected]>

zmberg · 2022-07-19T07:03:42Z

/lgtm

furykerry · 2022-07-22T08:58:17Z

/approve

kruise-bot · 2022-07-22T08:58:26Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furykerry

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [furykerry]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: mingzhou.swx <[email protected]> Co-authored-by: mingzhou.swx <[email protected]> Signed-off-by: Liu Zhenwei <[email protected]>

Co-authored-by: mingzhou.swx <[email protected]>

kruise-bot requested review from FillZpp and zmberg July 14, 2022 04:17

kruise-bot added the size/XL size/XL: 500-999 label Jul 14, 2022

sonatype-lift bot reviewed Jul 14, 2022

View reviewed changes

veophi force-pushed the revision branch 2 times, most recently from 0fff9e3 to 3f73b49 Compare July 14, 2022 07:55

veophi force-pushed the revision branch from 3f73b49 to aa6e8fb Compare July 14, 2022 08:22

zmberg reviewed Jul 14, 2022

View reviewed changes

veophi force-pushed the revision branch 2 times, most recently from b06bdcf to 00f4d80 Compare July 14, 2022 12:52

sonatype-lift bot reviewed Jul 14, 2022

View reviewed changes

pkg/control/sidecarcontrol/history_control.go Outdated Show resolved Hide resolved

sonatype-lift bot reviewed Jul 14, 2022

View reviewed changes

pkg/control/sidecarcontrol/history_control.go Outdated Show resolved Hide resolved

sonatype-lift bot reviewed Jul 14, 2022

View reviewed changes

pkg/control/sidecarcontrol/history_control.go Show resolved Hide resolved

veophi force-pushed the revision branch 3 times, most recently from d433066 to 3a4bfd9 Compare July 15, 2022 03:11

veophi force-pushed the revision branch 2 times, most recently from 364e6f6 to d7f3fa3 Compare July 18, 2022 04:39

FillZpp reviewed Jul 18, 2022

View reviewed changes

veophi force-pushed the revision branch 4 times, most recently from 9a5e279 to bd59872 Compare July 18, 2022 12:43

veophi force-pushed the revision branch from bd59872 to d872790 Compare July 19, 2022 02:50

FillZpp reviewed Jul 19, 2022

View reviewed changes

pkg/control/sidecarcontrol/history_control.go Outdated Show resolved Hide resolved

veophi force-pushed the revision branch from d872790 to 73fe18c Compare July 19, 2022 06:05

kruise-bot assigned FillZpp Jul 19, 2022

kruise-bot added the lgtm label Jul 19, 2022

zmberg reviewed Jul 19, 2022

View reviewed changes

pkg/webhook/pod/mutating/sidecarset.go Show resolved Hide resolved

sidecarset inject history revision

11e9484

Signed-off-by: mingzhou.swx <[email protected]>

veophi force-pushed the revision branch from 73fe18c to 11e9484 Compare July 19, 2022 06:59

kruise-bot removed the lgtm label Jul 19, 2022

kruise-bot assigned zmberg Jul 19, 2022

kruise-bot added the lgtm label Jul 19, 2022

FillZpp added this to the v1.3.0 milestone Jul 21, 2022

kruise-bot added the approved label Jul 22, 2022

kruise-bot merged commit fa8abc4 into openkruise:master Jul 22, 2022

zmberg mentioned this pull request Sep 29, 2022

[feature request] Support SidecarSet update strategy when pod recreate or inject #783

Closed

ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024

sidecarset inject history revision (openkruise#1021)

2514c1e

Co-authored-by: mingzhou.swx <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SidecarSet inject history revision #1021

SidecarSet inject history revision #1021

veophi commented Jul 14, 2022 •

edited by zmberg

Loading

sonatype-lift bot Jul 14, 2022

sonatype-lift bot Jul 14, 2022

sonatype-lift bot Jul 14, 2022

codecov-commenter commented Jul 14, 2022 •

edited

Loading

zmberg Jul 14, 2022

veophi commented Jul 15, 2022

kruise-bot commented Jul 15, 2022

veophi commented Jul 15, 2022

kruise-bot commented Jul 15, 2022

FillZpp commented Jul 19, 2022

zmberg commented Jul 19, 2022

furykerry commented Jul 22, 2022

kruise-bot commented Jul 22, 2022

SidecarSet inject history revision #1021

SidecarSet inject history revision #1021

Conversation

veophi commented Jul 14, 2022 • edited by zmberg Loading

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

sonatype-lift bot Jul 14, 2022

Choose a reason for hiding this comment

sonatype-lift bot Jul 14, 2022

Choose a reason for hiding this comment

sonatype-lift bot Jul 14, 2022

Choose a reason for hiding this comment

codecov-commenter commented Jul 14, 2022 • edited Loading

Codecov Report

zmberg Jul 14, 2022

Choose a reason for hiding this comment

veophi commented Jul 15, 2022

kruise-bot commented Jul 15, 2022

veophi commented Jul 15, 2022

kruise-bot commented Jul 15, 2022

FillZpp commented Jul 19, 2022

zmberg commented Jul 19, 2022

furykerry commented Jul 22, 2022

kruise-bot commented Jul 22, 2022

veophi commented Jul 14, 2022 •

edited by zmberg

Loading

codecov-commenter commented Jul 14, 2022 •

edited

Loading