Fix nil panic in cloneset validating webhook (#1678)

Signed-off-by: Spground <[email protected]> Co-authored-by: Spground <[email protected]>
openkruise · Jul 31, 2024 · 61ee5bc · 61ee5bc
1 parent 11e5ac0
commit 61ee5bc
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/pkg/webhook/cloneset/validating/validation.go b/pkg/webhook/cloneset/validating/validation.go
@@ -116,7 +116,7 @@ func (h *CloneSetCreateUpdateHandler) validateScaleStrategy(strategy, oldStrateg
 			allErrs = append(allErrs, field.Invalid(fldPath.Child("podsToDelete"), podName, fmt.Sprintf("find pod %s failed: %v", podName, err)))
 		} else if pod.DeletionTimestamp != nil {
 			allErrs = append(allErrs, field.Invalid(fldPath.Child("podsToDelete"), podName, fmt.Sprintf("find pod %s already terminating", podName)))
-		} else if owner := metav1.GetControllerOf(pod); owner.UID != metadata.UID {
+		} else if owner := metav1.GetControllerOf(pod); owner == nil || owner.UID != metadata.UID {
 			allErrs = append(allErrs, field.Invalid(fldPath.Child("podsToDelete"), podName, fmt.Sprintf("find pod %s owner is not this CloneSet", podName)))
 		}
 	}