break the loop when we find the current revision (#887)

Signed-off-by: shiyan2016 <[email protected]>
openkruise · Jan 13, 2022 · 2eece61 · 2eece61
1 parent 580a944
commit 2eece61
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 0 deletions.
diff --git a/pkg/controller/cloneset/cloneset_controller.go b/pkg/controller/cloneset/cloneset_controller.go
@@ -439,6 +439,7 @@ func (r *ReconcileCloneSet) getActiveRevisions(cs *appsv1alpha1.CloneSet, revisi
 	for i := range revisions {
 		if revisions[i].Name == cs.Status.CurrentRevision {
 			currentRevision = revisions[i]
+			break
 		}
 	}
 

diff --git a/pkg/controller/statefulset/stateful_set_control.go b/pkg/controller/statefulset/stateful_set_control.go
@@ -263,6 +263,7 @@ func (ssc *defaultStatefulSetControl) getStatefulSetRevisions(
 	for i := range revisions {
 		if revisions[i].Name == set.Status.CurrentRevision {
 			currentRevision = revisions[i]
+			break
 		}
 	}
 

diff --git a/pkg/controller/uniteddeployment/revision.go b/pkg/controller/uniteddeployment/revision.go
@@ -131,6 +131,7 @@ func (r *ReconcileUnitedDeployment) constructUnitedDeploymentRevisions(ud *appsa
 	for i := range revisions {
 		if revisions[i].Name == ud.Status.CurrentRevision {
 			currentRevision = revisions[i]
+			break
 		}
 	}
-Original file line number
+Diff line change
@@ Expand Up @@
     	for i := range revisions {
     		if revisions[i].Name == cs.Status.CurrentRevision {
     			currentRevision = revisions[i]
+    			break
     		}
     	}
@@ Expand Down @@