Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: optimize create element and create text node. #952

Merged
merged 26 commits into from
Dec 14, 2021
Merged

feat: optimize create element and create text node. #952

merged 26 commits into from
Dec 14, 2021

Conversation

andycall
Copy link
Member

@andycall andycall commented Dec 8, 2021 •
edited
Loading

  1. 将 Node 和 Element 上的 Getter 和 Setter 移动到原型链上，避免每次创建 Element 和 Node 都要初始化一遍属性。

@andycall andycall force-pushed the feat/optimize-create-element branch from ef6ce2e to 168841f Compare December 8, 2021 04:58
@yuanyan
Copy link
Contributor

yuanyan commented Dec 8, 2021

缺少 TextNode 的重构

@andycall andycall force-pushed the feat/optimize-create-element branch from bf81dc6 to 6fa8be7 Compare December 9, 2021 07:34
@andycall andycall force-pushed the feat/optimize-create-element branch from b700388 to fb92107 Compare December 9, 2021 09:24
@andycall andycall force-pushed the feat/optimize-create-element branch from 896f62e to 6b43f30 Compare December 9, 2021 15:44
@andycall andycall force-pushed the feat/optimize-create-element branch from 35e4fab to da84c1b Compare December 10, 2021 04:14
@andycall andycall force-pushed the feat/optimize-create-element branch from d640537 to 519c7d4 Compare December 10, 2021 16:29
@andycall andycall merged commit 2b9a788 into main Dec 14, 2021
@andycall andycall deleted the feat/optimize-create-element branch December 14, 2021 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuanyan yuanyan yuanyan left review comments

@answershuto answershuto answershuto approved these changes

@wssgcg1213 wssgcg1213 wssgcg1213 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andycall @yuanyan @wssgcg1213 @answershuto