Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix document.createElement in multiple context #935

Merged
merged 2 commits into from
Dec 1, 2021
Merged

fix: fix document.createElement in multiple context #935

merged 2 commits into from
Dec 1, 2021

Conversation

andycall
Copy link
Member

@andycall andycall commented Nov 30, 2021 •
edited
Loading

Fixed #931

由于 Element 构造函数没有按照 JSContext 进行分离，所以存在其中一个页面销毁的同时，销毁所有 Context 共享的公共构造函数。

修复方案：每个 Context 都有独立的 Element 构造函数，相互之间不影响。

@andycall andycall mentioned this pull request Nov 30, 2021
Closed
@answershuto answershuto merged commit 7fdbfc0 into main Dec 1, 2021
@answershuto answershuto deleted the fix/create_element_multiple_context branch December 1, 2021 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@answershuto answershuto answershuto approved these changes

@yuanyan yuanyan yuanyan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed to execute 'appendChild' on 'Node': first arguments should be an Node type.
3 participants
@andycall @yuanyan @answershuto