fix: fix weak reference between style and element. #895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuanyan
reviewed
Nov 23, 2021
yuanyan
reviewed
Nov 23, 2021
wssgcg1213
force-pushed
the
fix/weak_element_style
branch
from
e9b862a to
71020d2
Compare
wssgcg1213
force-pushed
the
fix/weak_element_style
branch
from
3f509a0 to
89228e7
Compare
wssgcg1213
approved these changes
Nov 25, 2021
yuanyan
approved these changes
Nov 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
解除 style 和 Element 之间的弱引用关系，避免 Element 提前被释放导致 style 继续访问导致 crash