Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/http cache should not intercept multi times #619

Merged
merged 7 commits into from
Aug 24, 2021
Merged

Fix/http cache should not intercept multi times #619

merged 7 commits into from
Aug 24, 2021

Conversation

wssgcg1213
Copy link
Member

  • 修复缓存文件在命中缓存的情况下, 再去写入导致文件大于 2*64K 的时候, 会被截断的问题

@wssgcg1213 wssgcg1213 requested a review from yuanyan August 23, 2021 08:11
@wssgcg1213 wssgcg1213 force-pushed the fix/http-cache-should-not-intercept-multi-times branch from abdfb92 to c98f400 Compare August 23, 2021 08:27
@wssgcg1213 wssgcg1213 requested a review from tylorvan August 23, 2021 08:42
@andycall
Copy link
Member

这个有测试用例吗？

answershuto
answershuto reviewed Aug 24, 2021
View reviewed changes
kraken/lib/src/foundation/http_cache_object.dart Outdated
import 'package:path/path.dart' as path;

import 'http_client_response.dart';

const String HttpHeadersCacheHits = 'cache-hits';
const String HttpCacheHit = 'HIT';
const String HttpCacheMiss = 'MISS';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

字符串常量大写下划线分割。

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://dart.dev/guides/language/effective-dart/style#prefer-using-lowercamelcase-for-constant-names

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JS 之所以习惯于 SCREAMING_CAPS 是因为早期 var 的声明方式无法给 identifier 标识常量。对于有 const 修饰符的语言就无此必要了

@andycall andycall merged commit f695090 into main Aug 24, 2021
@andycall andycall deleted the fix/http-cache-should-not-intercept-multi-times branch August 24, 2021 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@answershuto answershuto answershuto approved these changes

@andycall andycall andycall approved these changes

@tylorvan tylorvan Awaiting requested review from tylorvan

@yuanyan yuanyan Awaiting requested review from yuanyan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wssgcg1213 @andycall @yuanyan @answershuto