fix: fix scroll event crash #1209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
answershuto
previously approved these changes
Mar 10, 2022
wssgcg1213
previously approved these changes
Mar 10, 2022
|
Wait ci |
andycall
force-pushed
the
fix/scroll_event_crash
branch
from
a3cc576 to
64e2bae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
之前从 JSC 迁移 QJS 的时候，遗留了一些 bad practice，在 JSC 的 JS 对象 GC 回收回调中，需要手动 Free 一次当前对象，而 QuickJS 会帮助你做这个事情。所以 HostClass 中遗留的 Free 就会在一些特定情况下导致二次释放。