fix: fix exception leak cause globalObject not fully freed. #1117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
answershuto
previously approved these changes
Jan 19, 2022
|
看懂了, 对应测试还是需要补一下 |
|
之后如果还有问题，我就直接fork master出来，把test案例集成到kraken/example，方便大家测试吧 |
andycall
force-pushed
the
fix/exception_leak
branch
from
6e4a6ca to
4625c6c
Compare
andycall
force-pushed
the
fix/exception_leak
branch
from
eb39e4b to
eded882
Compare
andycall
force-pushed
the
fix/exception_leak
branch
from
bd2c843 to
057125e
Compare
yuanyan
reviewed
Jan 19, 2022
andycall
force-pushed
the
fix/exception_leak
branch
from
85cf092 to
b5d4a69
Compare
yuanyan
approved these changes
Jan 19, 2022
answershuto
approved these changes
Jan 20, 2022
|
已测试，完美 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #1099
没有释放的 Exception 会导致 globalObject 没有被释放，globalObject 没有释放会导致 GC Tracker 没有释放，GC tracker 没有释放会导致当销毁一个 ExecutionContext 时，基于 JSContext 所创建的对象并没有完全被清空，依然会残留在 GC 的队列里。
待下次执行 GC 的时候，就从没有被回收的对象访问到已经被释放的 JSContext，导致 Crash。
TODO: test