fix: fix page reload. #1109
Merged
fix: fix page reload. #1109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
wssgcg1213
reviewed
Jan 17, 2022
| @@ -111,6 +111,8 @@ class KrakenViewController | |||
| this.navigationDelegate, | |||
| this.gestureListener, | |||
| this.widgetDelegate, | |||
| // Viewport won't change when kraken page reload, should reuse previous page's viewportBox. | |||
| RenderViewportBox? originalViewport | |||
There was a problem hiding this comment.
不能用 this.viewport，已经有这个变量了
answershuto
previously approved these changes
Jan 17, 2022
answershuto
approved these changes
Jan 17, 2022
wssgcg1213
approved these changes
Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修复页面刷新，RenderViewport 的挂载问题。
Kraken 刷新页面，不会触发 Kraken 外层 Flutter Widget 树的更新。因此需要保留上一个页面 RenderViewportBox，把内部的 RenderObject 都删除，待页面刷新完成，再将新的页面内容，挂载到原先的 RenderViewportBox 下面。
缺乏测试基建，暂时无法写测试，测试基建搭建 @andycall