Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

creates directory for project resources per #445 #456

Merged
merged 2 commits into from
Feb 11, 2020
Merged

creates directory for project resources per #445 #456

merged 2 commits into from
Feb 11, 2020

Conversation

jorydotcom
Copy link
Contributor

@mcollina
Copy link
Member

Would you mind to add a link to the README to the travel fund document? Moving it in a folder reduce discoverability.

joesepi
joesepi approved these changes Jan 30, 2020
View reviewed changes
Copy link
Member

@joesepi joesepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I agree with @mcollina that links in the repo's README would be a good idea.

mhdawson
mhdawson approved these changes Jan 30, 2020
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joesepi joesepi merged commit 2bb3e99 into openjs-foundation:master Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joesepi joesepi joesepi approved these changes

@mhdawson mhdawson mhdawson approved these changes

@codeekage codeekage codeekage approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Meta: Where shall certain resources live?
5 participants
@jorydotcom @mcollina @joesepi @mhdawson @codeekage