-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PRE REVIEW]: Pore2Chip: All-in-One Python Tool for Soil Microstructure Analysis and Micromodel Design #7546
Comments
Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
Software report:
Commit count by author:
|
Paper file info: 📄 Wordcount for ✅ The paper includes a |
License info: 🟡 License found: |
|
Five most similar historical JOSS papers: PXO (Poly-XTAL Operations): MATLAB Codebase to Generate, Analyse and Export Complex 2D Spatio-Temporally Gradient Grain Structures Nanomesh: A Python workflow tool for generating meshes from image data TauFactor 2: A GPU accelerated python tool for microstructural analysis PiSCAT: A Python Package for Interferometric Scattering Microscopy PyLithics: A Python package for stone tool analysis |
Hi @aramyxt and thanks for your submission! I am looking for some specific items to make sure your submission fits our requirements at a high level (not at the more detailed review level) before moving on to finding an editor or putting this on our waitlist if no relevant editors are available. I'll comment over time as I have a chance to go through them:
In the meantime, please take a look at the comments above ⬆️ from the editorialbot to address any DOI, license, or paper issues if you're able (there may not be any), or suggest reviewers. For reviewers, please suggest 5 reviewers from the database listed above or your own (non-conflicted) extended network. Their github handles are most useful to receive but please don't use "@" to reference them since it will prematurely ping them. |
@aramyxt I consulted with a license expert from our editorial team about your license and was told:
Note that having an OSI-approved license is a requirement for JOSS to review your submission. |
Thank you for the response! I will talk to my team about the license issue. |
@kthyng, can you please give us a couple of days to discuss this with our team and potentially change it to an MIT license? |
@aramyxt, @maruti-iitm Yes, no problem. |
@kthyng We have removed the disclaimer and have updated the Please see the updated license here: https://github.com/EMSL-Computing/Pore2Chip/blob/main/LICENSE.md Let me know if you need further information on the |
@editorialbot and @kthyng incorporated these inputs in the latest |
Potential/Suggested reviewers:
Additional Suggested Reviewers:
|
@kthyng, do you have any input or feedback on the next steps? Please advise. |
@editorialbot check repository |
Software report:
Commit count by author:
|
Paper file info: 📄 Wordcount for ✅ The paper includes a |
License info: 🟡 License found: |
@maruti-iit, @aramyxt The license still isn't following just one license. It has three clauses and the text above the clauses is mostly borrowed from MIT, not any of the BSD licenses. Is there something preventing you from adopting a single license type? |
@kthyng, we just got approval to change it to an MIT license. Here is the updated license text in the repo: https://github.com/EMSL-Computing/Pore2Chip/blob/main/LICENSE.md |
@aramyxt @maruti-iitm ok thanks. Do you have documentation outside of the readme file for guiding users? |
@kthyng current documentation includes a readme file along with extensive Jupyter Notebooks and a video tutorial: https://www.youtube.com/watch?v=_DTLtYBAZSo Additional resources for Pore2Chip users to develop lab-on-chip using the software and other user-related applications are here: https://www.emsl.pnnl.gov/science/instruments-resources/terraforms-pore2chip These are all in the Pore2Chip readme file. |
|
@cheginit Can you edit this? They need to fix up their paper but then it would be ready to review. |
@editorialbot invite @cheginit as editor |
Invitation to edit this submission sent! |
@kthyng Yes, I can. 👋🏼 @maruti-iitm @aramyxt, I will be the editor for your submission. Once you addressed the issues with the paper, please let me know so I can go ahead with finding reviewers. |
@editorialbot assign @cheginit as editor |
Assigned! @cheginit is now the editor |
@editorialbot check repository |
Software report:
Commit count by author:
|
Paper file info: 📄 Wordcount for ✅ The paper includes a |
License info: ✅ License found: |
@editorialbot check repository |
Software report:
Commit count by author:
|
Paper file info: 📄 Wordcount for ✅ The paper includes a |
License info: ✅ License found: |
@cheginit @kthyng @maruti-iitm Hello, I have reduced the wordcount of the paper to 935 words and also fixed the strange formatting error with one of the references. Please reach out to me if there are any more changes that I need to make to be compliant with JOSS formatting requirements. Thank you! |
@editorialbot generate pdf |
Five most similar historical JOSS papers: Ciclope: micro Computed Tomography to Finite Elements CRNPy: An Open-Source Python Library for Cosmic-Ray Neutron Probe Data Processing pyDeltaRCM: a flexible numerical delta model GroundwaterDupuitPercolator: A Landlab component for groundwater flow Simmate: a framework for materials science |
👋🏼 @maruti-iitm @aramyxt thanks for addressing the issue with the paper. I went through the list of potential reviewers that you provided, but unfortunately none of them appear to work in a related field and have experience with Python. Also, please note that they should have a GitHub account and have no the conflict of interest, e.g., working in the same institution as yours. You can review JOSS's policy on this here. You can use JOSS' tool to search for reviewers in addition to other people in your own network that have the required expertise. |
Hi @cheginit, Thank you so much! Happy New Year! The potential reviewers suggested here are not co-authors (in any of our previous research work/papers): #7546 (comment) They have experience with software-based experimental design and Python programming (e.g., Pratanu Roy and Habiba Akter). @aramyxt can correct me if I am wrong. Sure, moving forward, we will use the JOSS tool to search for additional reviewers and get back to you as soon as we can. Is that okay? |
Submitting author: @aramyxt (Aramy Truong)
Repository: https://github.com/EMSL-Computing/Pore2Chip
Branch with paper.md (empty if default branch):
Version: 0.1.0
Editor: @cheginit
Reviewers: Pending
Managing EiC: Kristen Thyng
Status
Status badge code:
Author instructions
Thanks for submitting your paper to JOSS @aramyxt. Currently, there isn't a JOSS editor assigned to your paper.
@aramyxt if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.
Editor instructions
The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:
The text was updated successfully, but these errors were encountered: