-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: biopixR: Extracting Insights from Biological Images #7074
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Software report:
Commit count by author:
|
Paper file info: 📄 Wordcount for ✅ The paper includes a |
License info: 🟡 License found: |
hi @tijeco & @ColemanRHarris, this is the review thread for the paper. All of our communications will happen here from now on. As a reviewer, the first step is to create a checklist for your review by entering
as the top of a new comment in this thread. These checklists contain the JOSS requirements. As you go over the submission, please check any items that you feel have been satisfied. The first comment in this thread also contains links to the JOSS reviewer guidelines. The JOSS review is different from most other journals. Our goal is to work with the authors to help them meet our criteria instead of merely passing judgment on the submission. As such, the reviewers are encouraged to submit issues and pull requests on the software repository. When doing so, please mention We aim for reviews to be completed within about 2-4 weeks. Please let me know if any of you require some more time. We can also use EditorialBot (our bot) to set automatic reminders if you know you'll be away for a known period of time. Please feel free to ping me (@fabian-s) if you have any questions/concerns. |
Review checklist for @tijecoConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@Brauckhoff |
@editorialbot generate pdf |
Dear @fabian-s, thanks for pointing out the issue with the DOIs. We are eager to cite everything we use or refer to with state-of-the-art technologies. Therefore, we fixed most missing DOIs shortly after submission during the PRE REVIEW. It appears, that we missed a DOI for RMarkown, which I just added. However, we fear, there is little we can do for the others, since these items have no DOI. For example:
Is this acceptable, or do you see another solution to this? |
@editorialbot generate pdf |
Review checklist for @ColemanRHarrisConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@devSJR |
Just a short note. We have added a new function to the package, which didn't end up in a branch but in main. Sorry for that, we will fix that. The package submitted for review is the stable version 1.x after bug fixes (→ 1.1.0). |
Dear @fabian-s, @tijeco and @ColemanRHarris, we forgot to mention that we already moved our latest commit, which caused a problem:
For the moment being, we decided to halt all pending commits of experimental new functions and new data sets, since we haven't tested them intensively in our current research. We decided it is also better not to submit anything until the review process is finished. Better than saying, “Let's commit. What could possibly go wrong?”, in my humble opinion. I hope you consent with this approach. |
@fabian-s , for clarity, we should be reviewing https://github.com/Brauckhoff/biopixR/tree/1880095c8bca6701b5363857f1cf4bba9738379b, corresponding to their release 1.1.0? |
@devSJR Could you provide clarification about contribution and authorship? The authors in the manuscript are Tim Brauckhoff, Coline Kieffer, and Stefan Rödiger. The first and last authors appear to have made contributions in the commit history. I don't see the middle author's contribution. Also, it looks like Michael Chirico contributed to the software via pull request, but I don't see them in the manuscript. |
Dear @tijeco, sure, I can do that. Tim does the main programming and documentation of biopixR. I lead this project (active project direction) and usually review the code (sometimes we even did paired programming), make contributions, fixes, and help with the documentation. Coline Kieffer contributes the various datasets that are central to the package. For this, she prepared wet lab samples, did the imaging and subsequent insight into the data jointly with us. So to speak, she provided the oil. She also, raised issues (albeit personally in the lab or by decentralized digital messaging) and reflects part of the target audience (biologists in the wet lab). We also specifically mention her in the supplement to this paper https://zenodo.org/doi/10.5281/zenodo.12744222 on page 78 (this supplement is referenced as Brauckhoff, T., & Rödiger, S. (2024). biopixR: Extracting insights from biological images. https://doi.org/10.5281/ZENODO.12744222). You will certainly notice that there are more people mentioned. However, considering invested time and dedication, Coline certainly contributed significantly. Michael Chirico contributed, indeed a software pull request. But truth to be told, I don't know if we should/must include him. @fabian-s, would you be so kind and tell me how to deal with this? I hope this answers your question. |
that's how i understood @devSJR 's remark, too. |
At this point could you:
I can then move forward with recommending acceptance of the submission. |
@fabian-s The DOI for the archived version is: 10.5281/zenodo.13899162 (https://doi.org/10.5281/zenodo.13899162) |
@editorialbot set 10.5281/zenodo.13899162 as archive |
Done! archive is now 10.5281/zenodo.13899162 |
@editorialbot set v1.2.0 as version |
Done! version is now v1.2.0 |
@editorialbot recommend-accept |
|
👋 @openjournals/bcm-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5975, then you can now move forward with accepting the submission by compiling again with the command |
|
I have checked the proof and think it is correct. |
@fabian-s is it our task to move forward with the command |
nah, @bcm-eics need to look this over and give their thumbs up |
Thanks for the rapid feedback. |
@devSJR @Brauckhoff as AEiC for JOSS I will now help to process this submission for acceptance in JOSS. I will now process some final checks: Checks on repository
Checks on review issue
Checks on archive
Checks on paper
|
@editorialbot set 1.2.0 as version |
Done! version is now 1.2.0 |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🦋🦋🦋 👉 Bluesky post for this paper 👈 🦋🦋🦋 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
@Brauckhoff congratulations on this JOSS publication. Thanks for editing @fabian-s !! And a special thank you to the reviewers: @ColemanRHarris, @tijeco !!! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @Brauckhoff (Tim Brauckhoff)
Repository: https://github.com/Brauckhoff/biopixR
Branch with paper.md (empty if default branch):
Version: 1.2.0
Editor: @fabian-s
Reviewers: @ColemanRHarris, @tijeco
Archive: 10.5281/zenodo.13899162
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@ColemanRHarris & @tijeco, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @fabian-s know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @tijeco
📝 Checklist for @ColemanRHarris
The text was updated successfully, but these errors were encountered: