-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: weatherOz: An API Client for Australian Weather and Climate Data Resources in R #6717
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
Software report:
Commit count by author:
|
|
Paper file info: 📄 Wordcount for ✅ The paper includes a |
License info: 🟡 License found: |
Thank you @arfon for moving our submission to review. Also, much appreciated @JanLauGe & @rogerssam for your time to 'continue' the review process here. I am linking issue #67 in the target repository that will contain replies and lengthier discussions from the review process. I have also added the 'under review' badge to the README. |
@bozaah – please take a look at the compiled PDF linked above and make fixes where you can. There are a number of issues with formatting and some of the references not rendering properly (likely a mis-match between your BibTeX keys in the You can check if things are fixed by asking @editorialbot for a new draft with |
@JanLauGe – thanks for your enthusiasm here, but as I mentioned in the pre-review thread, there's no need to do an additional review here (JOSS accepts the rOpenSci review). I'm currently just waiting on @bozaah's response to this comment to proceed. |
Thanks @arfon for moving our review process quickly. I am away from office on holidays until the 14th May and I will attend to the issues with the references and submit the editorial check. Much appreciated. |
@editorialbot generate pdf |
@editorialbot check references |
|
@editorialbot generate pdf |
@bozaah – this all looks good now. The only issue I can see now is that all of the software names that are wrapped in
|
Thanks @arfon, we have updated the manuscript to have the package names use backticks and removed the |
@editorialbot generate pdf |
@editorialbot recommend-accept |
Paper is not ready for acceptance yet, the archive is missing |
@editorialbot set 10.5281/zenodo.8191283 as archive |
Done! archive is now 10.5281/zenodo.8191283 |
@editorialbot recommend-accept |
|
|
Element isbn: [facet 'minLength'] The value has a length of '9'; this underruns the allowed minimum length of '10'. |
@bozaah – can you merge this PR please? It should fix the XML validation above: ropensci/weatherOz#76 |
I’ve merged it, thanks @arfon |
@editorialbot recommend-accept |
|
|
👋 @openjournals/dsais-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5464, then you can now move forward with accepting the submission by compiling again with the command |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
@JanLauGe, @rogerssam – many thanks for your reviews here! JOSS (and rOpenSci) relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you ✨ @bozaah – your paper is now accepted and published in JOSS ⚡🚀💥 |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @bozaah (Rodrigo Pires)
Repository: https://github.com/ropensci/weatherOz
Branch with paper.md (empty if default branch): paper
Version: v0.0.1
Editor: @arfon
Reviewers: @JanLauGe, @rogerssam
Archive: 10.5281/zenodo.8191283
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@JanLauGe & @rogerssam, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @arfon know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @JanLauGe
The text was updated successfully, but these errors were encountered: