-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: Benchmarking Hierarchical Reasoning with HierarchyCraft #6468
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
Software report:
Commit count by author:
|
Paper file info: 📄 Wordcount for ✅ The paper includes a |
License info: 🟡 License found: |
|
@lwu9 and @Christopher-Henry-UM, thanks for agreeing to review this submission. In case you didn't receive the notification from editorialbot, please visit this issue on GitHub and review the Reviewer Instructions at the top of the thread. Let me know if you have any questions about the review process. |
Thanks for the reminder Tristan! I will get to the review this week. |
Thanks, Tristan!
…On Mon, 18 Mar 2024 at 19:36, Christopher-Henry-UM ***@***.***> wrote:
Thanks for the reminder Tristan! I will get to the review this week.
—
Reply to this email directly, view it on GitHub
<#6468 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AG4SWUJB5OYO22SM6DDXE33YY527XAVCNFSM6AAAAABERATZ6CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBVGI4TSNBQG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I just heard from Chris Henry that he won't be able to start his review for a few more days yet. But don't let that stop you, @lwu9, from starting your review once you're ready. |
Hey there @lwu9 and @Christopher-Henry-UM! I just wanted to ping you to ask whether you'll be able to start your reviews of this submission soon. |
Thanks for the reminder. I plan to work on it this weekend.
Best,
Lili
…On Mon, Apr 8, 2024 at 6:55 PM Tristan Miller ***@***.***> wrote:
Hey there @lwu9 <https://github.com/lwu9> and @Christopher-Henry-UM
<https://github.com/Christopher-Henry-UM>! I just wanted to ping you to
ask whether you'll be able to start your reviews of this submission soon.
—
Reply to this email directly, view it on GitHub
<#6468 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AG4SWUJ3JV5QNQ6FP3CPVMLY4MN57AVCNFSM6AAAAABERATZ6CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBTG43DSOBRGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Thank you for bearing with me. I will get to it this week. |
Review checklist for @Christopher-Henry-UMConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Review checklist for @lwu9Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
|
@lwu9 Thanks for the review so far. Is your second issue blocking you from performing other steps in the review? @MathisFederico, perhaps you could comment on the three issues? |
I have performed most of the review except I am not comfortable checking the Functionality or the Performance boxes. The software is used to create arbitrary hierarchical environments that are compatible with the OpenAI Gym Reinforcement Learning framework or the AIPlan4EU Unified Planning Framework. This library enables users to easily create complex hierarchical structures that can be used to test and develop various reinforcement learning or planning algorithms. While I am familiar with the concept of reinforcement learning, I do not have the experience with the type of programming this library was created for. As a result, I have no way to test it other than to carry out the Quickstart steps listed in the documentation. |
Thanks, @Christopher-Henry-UM. @MathisFederico, are there any further reviewers you could nominate with the requisite knowledge of OpenAI Gym Reinforcement Learning or AIPlan4EU Unified Planning Framework to evaluate the functional claims of your submission? Also, could you please respond to my query upthread concerning the issues raised by @lwu9? |
Thanks for the reviews so far ! Sorry @logological for being long to answer, it has been two very busy weeks... About @lwu9 issues:
I was not sure if I could add @SWang848 and @liyuxuan-academic because most of their contributions where non-code ones (testing, reviewing documentation, discussing ideas, ...) but re-reading JOSS authorship guidelines it seems that I could indeed ! I asked them if they want to be added as author (and not just being in acknowledgments as now) and will update according to their answers.
When using human actions, the program will pause and wait for the action of the human, meaning you ! You can select action be either using arrows and pressing enter, or by just clicking on available actions.
There was a CONTRIBUTING.md file but the readme didn't mention it indeed ! It is now added ! About @Christopher-Henry-UM issues:There are tests that checks those facts automatically both for planning (see planning tests) and for gym API (see gym tests) also for the gym compatibility this library has been heavily used with stable-baselines3 that requires the gym API to be valid. I still asked around in the planning community to know if someone would like to review, I will update here if I find someone ! |
After their approval, I've added both non-code co-authors @logological Need any help regarding issue 2 @lwu9 ? |
I'm sorry I'm currently overcommitted. :-( I think it's the same for @roeger. But perhaps you can recommend someone from the AIPlan4EU contributors, Gabi? |
@alvalentini @arbimo @mikand Would you be willing and able to review this submission for the Journal of Open Source Software? We're particularly looking for a reviewer who has familiarity with the OpenAI Gym or AIPlan4EU platforms. |
@hstairs Would you be willing and able to review this submission for the Journal of Open Source Software? We're particularly looking for a reviewer who has familiarity with the OpenAI Gym or AIPlan4EU platforms. |
@MathisFederico Thanks for your continued patience. I have been continuing to reach out to potential reviewers by e-mail, and will see if I can contact a few more today through GitHub. Hopefully we will get someone to accept soon. |
@inpefess @lutzhamel Would you be willing and able to review this submission for the Journal of Open Source Software? We're particularly looking for a reviewer who has familiarity with the OpenAI Gym or AIPlan4EU platforms. |
I'm not in a hurry no problem, Thanks for doing what you do. I have to fix the AI4Plan compatibility with their last breaking changes anyway and adding the Hierarchical Task Network conversion is something that I have to finish up. I guess software is always evolving anyway and I intend to maintain this repo as long as the question "How do we quantify the hierarchicality of a behavior, task and environment" remains open, and it is still wide open today. |
@madmage Would you be willing and able to review this submission for the Journal of Open Source Software? We're particularly looking for a reviewer who has familiarity with the OpenAI Gym or AIPlan4EU platforms. |
Yes, it would be a pleasure for me to review this submission. I don't know anything about AIPlan4EU yet, but I have relveant experience in creating and using OpenAI Gym environments. |
Dear Tristan Miller, is there any deadline for this review? I would like to
participate, but I would not have time in the next weeks.
…On Sat, 3 Aug 2024 at 23:59, Tristan Miller ***@***.***> wrote:
@madmage <https://github.com/madmage> Would you be willing and able to
review this submission for the Journal of Open Source Software? We're
particularly looking for a reviewer who has familiarity with the OpenAI Gym
or AIPlan4EU platforms.
—
Reply to this email directly, view it on GitHub
<#6468 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEKVBMWKWBPOMETRYJLDRLZPVHFVAVCNFSM6AAAAABERATZ6CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRXGE3TCMJWGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Daniele Calisi
|
@inpefess Thanks so much! We'd be delighted to have your review for this submission. I'll have our editorial bot prepare a review checklist for you and you can get to work on it at your convenience (though we'd ask that you try to submit your review in two to three weeks if possible.) You should receive a GitHub notification once the checklist is ready for you. |
@madmage It seems that another potential reviewer gave a positive response to my call a couple hours before you did, and so we wouldn't need your review after all. Nonetheless thanks for getting back to me, and I hope you might consider reviewing for JOSS in the future! |
@editorialbot add @inpefess as reviewer |
@inpefess added to the reviewers list! |
@inpefess I've added you as a reviewer, but it seems I may have been mistaken about being able to generate the review checklist for you. I think that you will need to do this yourself: please post a comment in this issue with the text |
Review checklist for @inpefessConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@MathisFederico Thank you for developing HierarchyCraft! It's really cool! I added several issues related to my check-list to your repository (linked to this one), please have a look at them when you have time. |
@inpefess Thank you for your review ! Lots of very good issues ! I'm currently in the process of making my research packages uploaded on nixpkgs for better reproducibility. |
@inpefess I've (hopefully) fixed the issues you raised code-wise, I'll get to the paper issue in the following week probably. |
@MathisFederico I see that all the issues raised by @inpefess except for IRLL/HierarchyCraft#45 are now closed, and that a commit referencing the latter issue was applied a few days ago, though the commit message doesn't speak to every comment raised in that issue. Will you be continuing to revise the paper to address the remaining comments in that issue? (Not that I am trying to rush you—I'm just trying to keep track of the progress so that it doesn't stall.) |
Yes I will, sorry this past month has been filled with a lot of new things (new place, new job, ...) |
Hey there @MathisFederico – just wanted to check in with you once again to confirm that you still intend to complete the remaining revisions. If you haven't had the time to do any work so far, please let me know when I should ping you again for an update. |
Hey @logological ! Yeah crazy rush those past weeks, but this is still in my backlog ! I hope to do it by then end of november at best tbh ... |
@MathisFederico How are you coming along with the remaining revisions? Do you have an expected timeline for completion? |
Any update for me, @MathisFederico? I haven't heard from you since October 26—please let me know if you're still interested in seeing this submission through to publication. |
Hey @logological, sorry I missed your last message, we are currently working on the last issues and I will do a small code update then we will be good to go again ! |
Submitting author: @MathisFederico (Mathis Federico)
Repository: https://github.com/IRLL/HierarchyCraft
Branch with paper.md (empty if default branch):
Version: v1.2.4
Editor: @logological
Reviewers: @lwu9, @Christopher-Henry-UM, @inpefess
Archive: Pending
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@lwu9 & @Christopher-Henry-UM, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @logological know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @lwu9
📝 Checklist for @Christopher-Henry-UM
📝 Checklist for @inpefess
The text was updated successfully, but these errors were encountered: