Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: HealpixMPI.jl: an MPI-parallel implementation of the Healpix tessellation scheme in Julia #6324

Closed
editorialbot opened this issue Feb 5, 2024 · 43 comments
Assignees
Labels
Julia pre-review TeX Track: 7 (CSISM) Computer science, Information Science, and Mathematics

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Feb 5, 2024

Submitting author: @LeeoBianchi (Leo Alessandro Bianchi)
Repository: https://github.com/LeeoBianchi/HealpixMPI.jl
Branch with paper.md (empty if default branch): JOSS-paper
Version: v1.0.0
Editor: @prashjha
Reviewers: @marcobonici, @baxmittens
Managing EiC: Daniel S. Katz

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/f012d3aa6c7cd644b8b9ecbe2c5a0aef"><img src="https://joss.theoj.org/papers/f012d3aa6c7cd644b8b9ecbe2c5a0aef/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/f012d3aa6c7cd644b8b9ecbe2c5a0aef/status.svg)](https://joss.theoj.org/papers/f012d3aa6c7cd644b8b9ecbe2c5a0aef)

Author instructions

Thanks for submitting your paper to JOSS @LeeoBianchi. Currently, there isn't a JOSS editor assigned to your paper.

@LeeoBianchi if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 7 (CSISM) Computer science, Information Science, and Mathematics labels Feb 5, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.03 s (1480.6 files/s, 131581.0 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Julia                           22            399            121           1797
Markdown                         8            187              0            626
YAML                             5              8             12            106
TeX                              1              7              0             83
TOML                             2              6              0             25
-------------------------------------------------------------------------------
SUM:                            38            607            133           2637
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 1462

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1051/0004-6361/202346414 is OK
- 10.1086/427976 is OK
- 10.1086/425219 is OK
- 10.1051/0004-6361/201321494 is OK
- 10.21105/jcon.00068 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

MPIFiles.jl: A Julia Package for Magnetic Particle Imaging Files
Submitting author: @tknopp
Handling editor: @brainstorm (Retired)
Reviewers: @IgorBaratta
Similarity score: 0.8385

GridapDistributed: a massively parallel finite element toolbox in Julia
Submitting author: @amartinhuertas
Handling editor: @Kevin-Mattheus-Moerman (Active)
Reviewers: @PetrKryslUCSD, @Leticia-maria, @jedbrown
Similarity score: 0.8216

ParticleScattering: Solving and optimizing multiple-scattering problems in Julia
Submitting author: @bblankrot
Handling editor: @Kevin-Mattheus-Moerman (Active)
Reviewers: @ziotom78, @ysimillides
Similarity score: 0.8185

DistributedSparseGrids.jl: A Julia library implementing an Adaptive Sparse Grid collocation method
Submitting author: @baxmittens
Handling editor: @drvinceknight (Active)
Reviewers: @ericneiva, @matt-graham
Similarity score: 0.8154

WaveletsExt.jl: Extending the boundaries of wavelets in Julia
Submitting author: @ShozenD
Handling editor: @bmcfee (Active)
Reviewers: @lostanlen, @malmaud
Similarity score: 0.8105

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@danielskatz
Copy link

👋 @prashjha - would you be willing to edit this submission?

@danielskatz
Copy link

@editorialbot invite @prashjha as editor

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@danielskatz
Copy link

👋 @LeeoBianchi - thanks for your submission. As you can see, the next step is for me to find an editor, who will then find reviewers and get the review started. If you have any suggestions for potential reviewers, then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

@dfm
Copy link

dfm commented Feb 5, 2024

@danielskatz mentioned this review to me and I wanted to list some possible reviewers with expertise in healpix and parallelization (although I'm not sure about Julia experience):

  • The authors of healpy, e.g. @zonca
  • The authors of s2fft, e.g. @CosmoMatt or @jasonmcewen

@LeeoBianchi
Copy link

Thank you @danielskatz. I have looked at the list you provided, there are many options and I don't think I know anyone in there. For example Yufeng Luo is the only one that comes up when cross searching for Julia and parallel computing.

@LeeoBianchi
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

MPIFiles.jl: A Julia Package for Magnetic Particle Imaging Files
Submitting author: @tknopp
Handling editor: @brainstorm (Retired)
Reviewers: @IgorBaratta
Similarity score: 0.8385

GridapDistributed: a massively parallel finite element toolbox in Julia
Submitting author: @amartinhuertas
Handling editor: @Kevin-Mattheus-Moerman (Active)
Reviewers: @PetrKryslUCSD, @Leticia-maria, @jedbrown
Similarity score: 0.8217

ParticleScattering: Solving and optimizing multiple-scattering problems in Julia
Submitting author: @bblankrot
Handling editor: @Kevin-Mattheus-Moerman (Active)
Reviewers: @ziotom78, @ysimillides
Similarity score: 0.8186

DistributedSparseGrids.jl: A Julia library implementing an Adaptive Sparse Grid collocation method
Submitting author: @baxmittens
Handling editor: @drvinceknight (Active)
Reviewers: @ericneiva, @matt-graham
Similarity score: 0.8155

WaveletsExt.jl: Extending the boundaries of wavelets in Julia
Submitting author: @ShozenD
Handling editor: @bmcfee (Active)
Reviewers: @lostanlen, @malmaud
Similarity score: 0.8106

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@danielskatz
Copy link

Thank you @danielskatz. I have looked at the list you provided, there are many options and I don't think I know anyone in there. For example Yufeng Luo is the only one that comes up when cross searching for Julia and parallel computing.

There's no reason just to suggest people you know. Anyone who seems like a potentially good reviewer based on what information available would be good to suggest, and would help the editor.

@LeeoBianchi
Copy link

LeeoBianchi commented Feb 6, 2024

Thank you @danielskatz. I have looked at the list you provided, there are many options and I don't think I know anyone in there. For example Yufeng Luo is the only one that comes up when cross searching for Julia and parallel computing.

There's no reason just to suggest people you know. Anyone who seems like a potentially good reviewer based on what information available would be good to suggest, and would help the editor.

Then I'd say, besides Yufeng Luo, RobertRosca, Rohit Goswami, Michael Schlottke-Lakemper, Uwe Hernandez Acosta and Manuel Behrendt might be a good match.

@danielskatz
Copy link

👋 @prashjha - a ping on the editor invitation to you... I'm not trying to bug you, but since you are often very quickly responsive, I thought I would try again to see if this just slipped by you.

@prashjha
Copy link

@danielskatz, happy to edit this. Thank you and sorry for the delay.

@editorialbot
Copy link
Collaborator Author

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@editorialbot commands

@prashjha
Copy link

@editorialbot commands

@editorialbot
Copy link
Collaborator Author

Hello @prashjha, here are the things you can ask me to do:


# List all available commands
@editorialbot commands

# Add to this issue's reviewers list
@editorialbot add @username as reviewer

# Remove from this issue's reviewers list
@editorialbot remove @username from reviewers

# Get a list of all editors's GitHub handles
@editorialbot list editors

# Assign a user as the editor of this submission
@editorialbot assign @username as editor

# Remove the editor assigned to this submission
@editorialbot remove editor

# Remind an author, a reviewer or the editor to return to a review after a 
# certain period of time (supported units days and weeks)
@editorialbot remind @reviewer in 2 weeks

# Check the references of the paper for missing DOIs
@editorialbot check references

# Perform checks on the repository
@editorialbot check repository

# Adds a checklist for the reviewer using this command
@editorialbot generate my checklist

# Set a value for version
@editorialbot set v1.0.0 as version

# Set a value for branch
@editorialbot set joss-paper as branch

# Set a value for repository
@editorialbot set https://github.com/organization/repo as repository

# Set a value for the archive DOI
@editorialbot set set 10.5281/zenodo.6861996 as archive

# Mention the EiCs for the correct track
@editorialbot ping track-eic

# Generates the pdf paper
@editorialbot generate pdf

# Recommends the submission for acceptance
@editorialbot recommend-accept

# Generates a LaTeX preprint file
@editorialbot generate preprint

# Flag submission with questionable scope
@editorialbot query scope

# Get a link to the complete list of reviewers
@editorialbot list reviewers

# Creates a post-review checklist with editor and authors tasks
@editorialbot create post-review checklist

# Open the review issue
@editorialbot start review

@editorialbot
Copy link
Collaborator Author

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@editorialbot commands

@prashjha
Copy link

@editorialbot assign me as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @prashjha is now the editor

@LeeoBianchi
Copy link

@prashjha thank you for undertaking this review as an editor. Let me know if you have any comment or question on my work.

@prashjha
Copy link

prashjha commented Mar 9, 2024

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@prashjha
Copy link

prashjha commented Mar 9, 2024

Hi @amartinhuertas, @baxmittens, @sloede, @ManuelBehrendt, @crbinz, @marcobonici, would you be interested in reviewing the JOSS submission above (pdf link)? The corresponding software is at this link.

This link covers almost everything about the review process; I will be happy to help with more information.

Please let me know if you are interested. Thank you!

@marcobonici
Copy link

Sure, happy to get involved!

@prashjha
Copy link

prashjha commented Mar 9, 2024

@marcobonici great! Adding you as a reviewer.

@prashjha
Copy link

prashjha commented Mar 9, 2024

@editorialbot add @marcobonici as reviewer

@editorialbot
Copy link
Collaborator Author

@marcobonici added to the reviewers list!

@baxmittens
Copy link

Do you need more reviewers? I have never done this before.

@prashjha
Copy link

Hi @baxmittens, we need two reviewers and I only got one so far. Let me know if you are up for it.

Review process is quite straightforward and is done in github (new issue will be created for review). It is explained in the link I shared earlier. I can also help with more details as we go along.

@baxmittens
Copy link

Then I will gladly join in.

@sloede
Copy link

sloede commented Mar 11, 2024

Due to multiple other obligations, I will definitely not be able to start a thorough review before the second week of April. If this is not too late, I'd be happy to do the review though!

@prashjha
Copy link

@baxmittens, great. I am adding you as a reviewer.

@prashjha
Copy link

@editorialbot add @baxmittens as reviewer

@editorialbot
Copy link
Collaborator Author

@baxmittens added to the reviewers list!

@prashjha
Copy link

@sloede, thank you for your response. We have two reviewers so I will not trouble you. :)

@prashjha
Copy link

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #6467.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Julia pre-review TeX Track: 7 (CSISM) Computer science, Information Science, and Mathematics
Projects
None yet
Development

No branches or pull requests

8 participants