-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: plotastic: Bridging Plotting and Statistics in Python #6304
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
|
Wordcount for |
@gmrandazzo and @SunnyXu, let me know if you have any questions about how to get your reviews started! |
Review checklist for @SunnyXuConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@rkurchin @markur4
|
@markur4 Thanks for the improvement. I like your improvement regarding issue 3 and issue 6 especially. |
@SunnyXu, are you satisfied on the community guidelines point? If so, please check off that last box. If not, please leave any additional comments/feedback necessary. @gmrandazzo, do you think you'll be able to start your review fairly soon? |
@rkurchin Thanks for the reminder. I am satisfied and checked the last box. I do not have additional comments regarding. |
I'm sorry @gmrandazzo, I'm afraid I can't do that. That's something only editors are allowed to do. |
Review checklist for @gmrandazzoConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@markur4 Ah last comment. Please clean the package directory from .vscode and .DS_Store and other garbage files. Add them to the .gitignore |
Thank you very much for the valuable feedback! 1.That's a good point, I included the rationale in the last sentence of the summary: Before: [...]This approach streamlines the process, translating After: [...] This approach streamlines the process, translating 2.I haven't tested plotastic on any other version than 3.11. I revised pyproject.toml to reduce confusion:
Please let me know if testing on older python versions is required to pass the review. 3.Interesting, I have never executed plotastic in a shell. Here's what I did:
Summary:
4.The screenshots do not refer to the correct documentation, but preliminary experiments with sphinx. I git removed them completely to prevent confusion. Please use the documentations and examples found in the README.md as a guide to use plotastic. Let me know if they are clear! 5.Thanks for pointing out the garbage files! I git removed them from src, if you find any more, let me know! |
Ok, I'm happy that it's working! Also, I've added a requirements section to the README.md! |
Post-Review Checklist for Editor and AuthorsAdditional Author Tasks After Review is Complete
Editor Tasks Prior to Acceptance
|
Thanks again reviewers! @markur4, you can see above a few things you'll need to do (and in some cases, send me info in a comment here) to finalize this submission. I'll do a read over the manuscript itself and send any editorial comments shortly! |
@editorialbot check references |
|
@editorialbot generate pdf |
@editorialbot set 0.1.1 as version |
Done! version is now 0.1.1 |
@editorialbot set 10.5281/zenodo.10775033 as archive |
Done! archive is now 10.5281/zenodo.10775033 |
Apologies that this took a little while! Editorial comments:
|
No problem, thanks for the feedback! I made these revisions, let me know if I missed something!
I removed the "a"
I agree, the point that I wanted to convey doesn't come across at all. Before: The library systematically groups the data according to the needs of statistical tests and plots, conducts visualisation, analyses and supports extensive customization options. In essence, plotastic establishes a protocol for configuring statical analyses through plotting parameters. This approach streamlines the process, translating seaborn parameters into statistical terms, After: Hence, statistics and plotting are performed on the same set of parameters, so that the strength of
I removed unnecessary newlines
Done
Done
It's python syntax that allows for methods to be chained in newlines. Without parentheses, the methods need to be in one line and that becomes unreadable very quickly.
It's a ', but I rephrased it to prevent confusion: Before: After:
Done
Done
Done
Done
Done
Done |
@editorialbot generate pdf |
@editorialbot recommend-accept |
|
|
👋 @openjournals/dsais-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5105, then you can now move forward with accepting the submission by compiling again with the command |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
@gmrandazzo, @SunnyXu – many thanks for your reviews here and to @rkurchin for editing this submission! JOSS relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you ✨ @markur4 – your paper is now accepted and published in JOSS ⚡🚀💥 |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @markur4 (Martin Kuric)
Repository: https://github.com/markur4/plotastic
Branch with paper.md (empty if default branch):
Version: 0.1.1
Editor: @rkurchin
Reviewers: @gmrandazzo, @SunnyXu
Archive: 10.5281/zenodo.10775033
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@gmrandazzo & @SunnyXu, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @rkurchin know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @SunnyXu
📝 Checklist for @gmrandazzo
The text was updated successfully, but these errors were encountered: