-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: Paicos: A Python package for analysis of (cosmological) simulations performed with Arepo #6296
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
@editorialbot generate pdf |
|
1 similar comment
Hi @tberlok, it looks like there is still an issue with a missing DOI for the paper. Also, it may be worth me mentioning that the latest information on how to cite the SWIFT code is available here: https://swift.strw.leidenuniv.nl/docs/CitingSWIFT/index.html. |
@editorialbot generate pdf |
Review checklist for @ttriccoConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Hi @ttricco and @kyleaoman, I hope the review is progressing nicely. Please, if you can, try to wrap up the review in the next couple of weeks; let me know if you have any questions! |
Review checklist for @kyleaomanConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
I've completed most of my review and have left a number of github issues open for the authors. My checklist above reflects which areas I feel need a little bit of work (but overall the package is in a good state). The exception is the "Performance" item - I should still try to check the functionality of the GPU-accelerated features. My laptop doesn't have a suitable GPU, but I should be able to test this on our local compute cluster. Will try to do this asap. |
Alright added one last issue around the GPU interactive features. My review is complete, so I leave it with the authors to address the github issues that I've opened to their satisfaction. Happy to iterate on things as needed, just let me know if you (authors/editors) need anything from me in the meantime. |
Hi @kyleaoman, thank you so much! Is it possible for you to reference this review thread in those issues, or do that here, so they are linked together automatically by GitHub? This way we can keep track of progress. |
@JBorrow that works I think? |
Yes, thank you! |
Just to update on my progress, I have worked through most of the review items, and tested the non-GPU code (various ways to install, unit tests, core functionality, etc). The biggest outstanding items for me are around testing the functionality and performance of the GPU versions of the code, which I'll get to in the next couple of days. |
Fantastic, thanks both. @tberlok, do you have any estimate of on what timescale you will be able to address the reviewer's comments? |
I have had a look at the reviewers comments, which I will start to address in detail tomorrow. I expect/hope to be done at some point next week. |
|
|
👋 @openjournals/aass-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5254, then you can now move forward with accepting the submission by compiling again with the command |
@tberlok, I'm recommending this paper for acceptance. An Editor in Chief will come in and do the final checks, but from me, that's it! Thank you for your work on this, and thanks again to @ttricco and @kyleaoman for reviewing. |
@JBorrow That's amazing, thank you! |
@editorialbot generate preprint |
📄 Preprint file created: Find it here in the Artifacts list 📄 |
@editorialbot generate pdf |
@editorialbot recommend-accept |
|
|
👋 @openjournals/aass-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5257, then you can now move forward with accepting the submission by compiling again with the command |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Many thanks to @ttricco and @kyleaoman for reviewing and to @JBorrow for editing! JOSS relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you!! @tberlok — Your paper is now accepted and published in JOSS! ⚡🚀💥 |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
@dfm Thank you for making the final edits and closing this off and thanks to @JBorrow, @ttricco and @kyleaoman for the help getting Paicos ready for publication! |
@editorialbot generate preprint |
📄 Preprint file created: Find it here in the Artifacts list 📄 |
Submitting author: @tberlok (Thomas Berlok)
Repository: https://github.com/tberlok/paicos
Branch with paper.md (empty if default branch): paper
Version: v0.1.14
Editor: @JBorrow
Reviewers: @ttricco, @kyleaoman
Archive: 10.5281/zenodo.10994256
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@ttricco & @kyleaoman, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @JBorrow know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @ttricco
📝 Checklist for @kyleaoman
The text was updated successfully, but these errors were encountered: