Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: nimbleHMC: An R package for Hamiltonian Monte Carlo sampling in nimble #6237

Closed
editorialbot opened this issue Jan 18, 2024 · 47 comments
Assignees
Labels
pre-review R TeX Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Jan 18, 2024

Submitting author: @danielturek (Daniel Turek)
Repository: https://github.com/nimble-dev/nimbleHMC
Branch with paper.md (empty if default branch): joss
Version: v0.2.0
Editor: @likeajumprope
Reviewers: @matt-graham, @larryshamalama
Managing EiC: Arfon Smith

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/bf9656c1941893cc3eef176efc1af6ae"><img src="https://joss.theoj.org/papers/bf9656c1941893cc3eef176efc1af6ae/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/bf9656c1941893cc3eef176efc1af6ae/status.svg)](https://joss.theoj.org/papers/bf9656c1941893cc3eef176efc1af6ae)

Author instructions

Thanks for submitting your paper to JOSS @danielturek. Currently, there isn't a JOSS editor assigned to your paper.

@danielturek if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning labels Jan 18, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.02 s (677.9 files/s, 198333.8 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
R                                7            176            675           1922
Markdown                         4            200              0            762
TeX                              1             49              0            201
YAML                             2             20              7             84
-------------------------------------------------------------------------------
SUM:                            14            445            682           2969
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 1415

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.21105/joss.03844 is OK
- 10.1080/10618600.2016.1172487 is OK
- 10.18637/jss.v076.i01 is OK
- 10.1214/aos/1056562461 is OK
- 10.1214/16-BA1008 is OK
- 10.1002/ece3.6053 is OK
- 10.1080/10618600.2013.791193 is OK
- 10.2307/2937171 is OK
- 10.1007/s10651-016-0353-z is OK

MISSING DOIs

- None

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@arfon arfon added the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Jan 18, 2024
@arfon
Copy link
Member

arfon commented Jan 18, 2024

@danielturek - thanks for your submission to JOSS. We're currently managing a large backlog of submissions and the editor most appropriate for your area is already rather busy.

For now, we will need to waitlist this paper and process it as the queue reduces. Thanks for your patience!

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

compareMCMCs: An R package for studying MCMC efficiency
Submitting author: @perrydv
Handling editor: @fabian-s (Active)
Reviewers: @rowlandseymour, @tbrown122387
Similarity score: 0.8513

flowMC: Normalizing flow enhanced sampling package for probabilistic inference in JAX
Submitting author: @kazewong
Handling editor: @rkurchin (Active)
Reviewers: @matt-graham, @Daniel-Dodd
Similarity score: 0.8200

SGMCMCJax: a lightweight JAX library for stochastic gradient Markov chain Monte Carlo algorithms
Submitting author: @jeremiecoullon
Handling editor: @dfm (Active)
Reviewers: @canyon289, @ColCarroll
Similarity score: 0.8137

greta: simple and scalable statistical modelling in R
Submitting author: @goldingn
Handling editor: @terrytangyuan (Retired)
Reviewers: @lionel68, @joethorley, @lionel68
Similarity score: 0.8093

ParaMonte: A high-performance serial/parallel Monte Carlo simulation library for C, C++, Fortran
Submitting author: @shahmoradi
Handling editor: @VivianePons (Retired)
Reviewers: @milancurcic, @williamfgc
Similarity score: 0.8064

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@danielturek
Copy link

@danielskatz Asked me to reference previous submission of this article in PR #5636 .

This submission was closed for additional updates to the manuscript, which have now been completed.

@arfon
Copy link
Member

arfon commented Jan 25, 2024

@editorialbot invite @jromanowska as editor

👋 @jromanowska – would you be willing to edit this submission for JOSS?

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@jromanowska
Copy link

@arfon - sorry, I'm not an expert in this topic! I hope you can find another editor to handle that one.

@likeajumprope
Copy link

I can take this one - I work with pyMC and Stan a lot

@likeajumprope
Copy link

@editorialbot assign @likeajumprope as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @likeajumprope is now the editor

@likeajumprope
Copy link

Hi @danielturek - while I am looking for reviewers, do you maybe have some suggestions?

@danielturek
Copy link

danielturek commented Feb 1, 2024

@likeajumprope Yes, perhaps (GitHub usernames, taken from the list of JOSS reviewers):

  • larryshamalama (possible in April 2024)
  • thomaspinder
  • tbrown122387
  • Volkerschmid
  • braniii

@likeajumprope
Copy link

👋 @larryshamalama @thomaspinder @tbrown122387 @volkerschmid could you maybe help us out with reviewing this one?

@tbrown122387
Copy link

Hey @likeajumprope @danielturek: unfortunately I'm strapped for time at the moment, and I'm already reviewing another JOSS paper. I appreciate the invite though

@larryshamalama
Copy link

👋 @larryshamalama @thomaspinder @tbrown122387 @volkerschmid could you maybe help us out with reviewing this one?

Unfortunately, I am busy for the next month or so. If you are okay if I do this revision in early April, I would be happy to do it then.

@likeajumprope
Copy link

Hi @braniii, could you help with this one maybe?

@braniii
Copy link

braniii commented Mar 7, 2024

Hi @likeajumprope, thx for the invitation. The project sounds very exciting, but unfortunately I have no experience in R and only basic knowledge of HMC. So it probably makes more sense to have someone else review it.

@likeajumprope
Copy link

Hi @likeajumprope, thx for the invitation. The project sounds very exciting, but unfortunately I have no experience in R and only basic knowledge of HMC. So it probably makes more sense to have someone else review it.

Thanks for letting me know!

@danielturek
Copy link

@likeajumprope Is there anything I can do to help the review process get started?

Thanks!

@likeajumprope
Copy link

likeajumprope commented Mar 15, 2024

@likeajumprope Is there anything I can do to help the review process get started?

Thanks!

The search for reviewers has been quite hard, both on an off github. Do you maybe have some more suggestions?

@danielturek
Copy link

@likeajumprope Perhaps either goldingn or njtierney ?

@arfon arfon removed the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Mar 24, 2024
@arfon
Copy link
Member

arfon commented Mar 24, 2024

@likeajumprope – just checking to see if any of the automated recommendations from @editorialbot have been checked here too?#6237 (comment)

@oliviaguest
Copy link
Member

@likeajumprope have you tried to email people who have ignored your tag on github? 😊

@danielturek
Copy link

Thanks for the suggestions @oliviaguest

@likeajumprope please let me know if I can help facilitate the process, I'm keen to see it move forward.

@likeajumprope
Copy link

likeajumprope commented Mar 24, 2024

Hi all, I sent out 4 additional invitations per email on Friday - hopefully we'll have some replies soon. It has been quite hard to find reviewers tbh.

@matt-graham
Copy link

I received an invite to review this by email. I'd be happy to do so, but just wanted to note I'm not an R expert. I do however know Hamiltonian Monte Carlo well so happy to review on that basis. I'm also currently reviewing another JOSS paper and will be not working over Easter so wouldn't be able to start on reviewing this till a couple of weeks.

@likeajumprope
Copy link

I received an invite to review this by email. I'd be happy to do so, but just wanted to note I'm not an R expert. I do however know Hamiltonian Monte Carlo well so happy to review on that basis. I'm also currently reviewing another JOSS paper and will be not working over Easter so wouldn't be able to start on reviewing this till a couple of weeks.

Yes that would be fine, thanks @matt-graham!

@likeajumprope
Copy link

@editorialbot add @matt-graham as reviewer

@editorialbot
Copy link
Collaborator Author

@matt-graham added to the reviewers list!

@danielturek
Copy link

@matt-graham Much obliged!

@likeajumprope
Copy link

I had two more rejections per email, but I also sent out three more requests today, so fingers crossed! Apologies this has been taking a while @danielturek

@likeajumprope
Copy link

just to give an update: I have been writing to 5 more potential reviewers behind the scenes, with no luck so far. Will continue and keep you posted

@danielturek
Copy link

@likeajumprope Thanks much for the update. Please let me know if I can assist, which I'd be happy to do.

@larryshamalama
Copy link

👋 @larryshamalama @thomaspinder @tbrown122387 @volkerschmid could you maybe help us out with reviewing this one?

Unfortunately, I am busy for the next month or so. If you are okay if I do this revision in early April, I would be happy to do it then.

@likeajumprope @danielturek I'm back from holidays and have a bit more capacity these days. If you are still looking for a reviewer, you can assign me

@danielturek
Copy link

@likeajumprope I'll please let you perform any official actions, but it seems like we have 2 willing reviewers (@matt-graham and @larryshamalama). Is that the number required?

@crvernon
Copy link

crvernon commented May 7, 2024

👋 @likeajumprope - just checking in to see if you saw the above. Let me know if you need anything to help get this one started. Thanks for all the work finding reviewers!

@danielturek
Copy link

@likeajumprope @danielskatz @crvernon @matt-graham @larryshamalama @editorialbot

Is there anything I can (please) do to help get this review process started?

I believe we have two reviewers identified (@matt-graham @larryshamalama).

@crvernon
Copy link

👋 @danielturek I am the AEiC for this track of submissions. I am trying to get in touch with your editor now. If I cannot, I'll take your submission on myself. In the meantime, let's go ahead and get this review started.

@crvernon
Copy link

@editorialbot add @larryshamalama as reviewer

@editorialbot
Copy link
Collaborator Author

@larryshamalama added to the reviewers list!

@crvernon
Copy link

@editorialbot start review

👋 - Alright @danielturek, @matt-graham, and @larryshamalama - I am going to close this Pre-Review and kick off the full review which you should receive a notification for. Thanks!

And thank you @matt-graham and @larryshamalama for agreeing to review!

cc. @likeajumprope

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #6745.

@danielturek
Copy link

@crvernon Thanks for taking this on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-review R TeX Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning
Projects
None yet
Development

No branches or pull requests