Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: fABBA: A Python library for the fast symbolic approximation of time series #6132

Closed
editorialbot opened this issue Dec 9, 2023 · 33 comments
Assignees
Labels
C++ Cython pre-review Python TeX Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Dec 9, 2023

Submitting author: @chenxinye (Xinye Chen)
Repository: https://github.com/nla-group/fABBA
Branch with paper.md (empty if default branch): master
Version: v1.1.0
Editor: @lrnv
Reviewers: @Karangupta1994, @allie-tatarian
Managing EiC: Arfon Smith

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/bd028bbee6f04f9ec2ad0b1034997c61"><img src="https://joss.theoj.org/papers/bd028bbee6f04f9ec2ad0b1034997c61/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/bd028bbee6f04f9ec2ad0b1034997c61/status.svg)](https://joss.theoj.org/papers/bd028bbee6f04f9ec2ad0b1034997c61)

Author instructions

Thanks for submitting your paper to JOSS @chenxinye. Currently, there isn't a JOSS editor assigned to your paper.

@chenxinye if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning labels Dec 9, 2023
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.98 s (115.9 files/s, 360946.2 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
C                               12          16359          74932         195162
Python                          28           1607           2641           3161
Jupyter Notebook                18              0          50227           2514
C++                              7            171            294            772
C/C++ Header                     9            202            299            622
Cython                          12            346            537            562
Markdown                         7            137              0            342
reStructuredText                 9            244            236            152
TeX                              1             14              0            109
YAML                             4             40             24             83
CSS                              1             18             15             57
DOS Batch                        1              8              1             26
Bourne Shell                     1              2              0             18
make                             1              4              7              9
TOML                             1              0              0              3
SWIG                             1              0              2              0
-------------------------------------------------------------------------------
SUM:                           113          19152         129215         203592
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 875

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- None

MISSING DOIs

- 10.1007/s10618-020-00689-6 may be a valid DOI for title: ABBA: adaptive Brownian bridge-based symbolic aggregation of time series
- 10.1109/tit.1982.1056489 may be a valid DOI for title: Least squares quantization in PCM
- 10.1145/882082.882086 may be a valid DOI for title: A symbolic representation of time series, with implications for streaming algorithms
- 10.1145/3532622 may be a valid DOI for title: An efficient aggregation method for the symbolic representation of temporal data
- 10.1016/j.is.2023.102294 may be a valid DOI for title: ECG classification with learning ensemble based on symbolic discretization
- 10.1007/978-3-031-24378-3_4 may be a valid DOI for title: Fast Time Series Classification with Random Symbolic Subsequences
- 10.1007/s10618-007-0064-z may be a valid DOI for title: Experiencing SAX: a novel symbolic representation of time series
- 10.1109/seed55351.2022.00016 may be a valid DOI for title: Foreseer: Efficiently Forecasting Malware Event Series with Long Short-Term Memory
- 10.1016/j.ress.2023.109123 may be a valid DOI for title: Data-driven prognostics based on time-frequency analysis and symbolic recurrent neural network for fuel cells under dynamic load
- 10.1145/3448672 may be a valid DOI for title: A Framework for Generating Summaries from Temporal Personal Health Data

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

dfba: Software for efficient simulation of dynamic flux-balance analysis models in Python
Submitting author: @davidtourigny
Handling editor: @marcosvital (Active)
Reviewers: @jdbrunner, @pstjohn, @synchon
Similarity score: 0.8218

pyFBS: A Python package for Frequency Based Substructuring
Submitting author: @tb93
Handling editor: @kyleniemeyer (Active)
Reviewers: @ngoiz, @LolloCappo, @Gunnstein
Similarity score: 0.8105

FreqAI: generalizing adaptive modeling for chaotic time-series market forecasts
Submitting author: @robcaulk
Handling editor: @Fei-Tao (Active)
Reviewers: @ady00, @shagunsodhani
Similarity score: 0.8055

BATMAN: Statistical analysis for expensive computer codes made easy
Submitting author: @tupui
Handling editor: @katyhuff (Retired)
Reviewers: @mikeckennedy
Similarity score: 0.8026

ECabc: A feature tuning program focused on Artificial Neural Network hyperparameters
Submitting author: @sanskriti-s
Handling editor: @arokem (Retired)
Reviewers: @annoviko
Similarity score: 0.8014

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@arfon
Copy link
Member

arfon commented Dec 9, 2023

@chenxinye – thanks for your submission to JOSS. When including the C code, this looks to be a very large submission. Could you clarify which aspects of this submission you are asking the JOSS reviewers to review?

Also, we're currently managing a large backlog of submissions and the editor most appropriate for your area is already rather busy.

For now, we will need to waitlist this paper and process it as the queue reduces. Thanks for your patience!

@arfon arfon added the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Dec 9, 2023
@chenxinye
Copy link

chenxinye commented Dec 11, 2023

@arfon Thanks! fABBA is a native Python library and is completely driven by Python code, which has no reliance on C++ at all, so we just hope JOSS reviewers can help to review the Python code, on which our fABBA library is based.

We provide native C++ implementation just for C++ users for reference.

@chenxinye
Copy link

chenxinye commented Dec 11, 2023

@arfon, I just removed the C++ code to for clarifying. Please let us know if you have any questions! Many thanks

@arfon
Copy link
Member

arfon commented Dec 12, 2023

@editorialbot check repository

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.94 s (103.5 files/s, 372887.6 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
C                               12          16359          74932         195162
Python                          28           1607           2641           3161
Jupyter Notebook                18              0          50227           2514
Cython                          12            346            537            562
Markdown                         7            136              0            346
reStructuredText                 9            244            236            152
TeX                              2             14              0            128
YAML                             4             40             24             83
CSS                              1             18             15             57
DOS Batch                        1              8              1             26
Bourne Shell                     1              2              0             18
make                             1              4              7              9
TOML                             1              0              0              3
-------------------------------------------------------------------------------
SUM:                            97          18778         128620         202221
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 875

@arfon
Copy link
Member

arfon commented Dec 12, 2023

@arfon Thanks! fABBA is a native Python library and is completely driven by Python code, which has no reliance on C++ at all, so we just hope JOSS reviewers can help to review the Python code, on which our fABBA library is based.

Thanks for clarifying. Just to confirm, the C code doesn't need reviewing either?

@chenxinye
Copy link

Yes @arfon, many thanks!

@arfon
Copy link
Member

arfon commented Jan 20, 2024

@editorialbot invite @lrnv as editor

👋 @lrnv – would you be willing to edit this submission for JOSS?

/ cc @vissarion for visibility.

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@lrnv
Copy link

lrnv commented Jan 20, 2024

@editorialbot assign me as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @lrnv is now the editor

@lrnv
Copy link

lrnv commented Jan 20, 2024

@chenxinye Hey !

Would you please take a look at the list of reviewers to potentially identify a few that would be suitable to review this submission ?

@chenxinye
Copy link

chenxinye commented Jan 21, 2024

Hi @lrnv ,

I suggest @allie-tatarian @@Karangupta1994 @djmannion @dgerosa @wmvanvliet? It would be nice if you can refer to some more.

Many thanks,
Xinye

@vissarion vissarion removed the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Jan 22, 2024
@lrnv
Copy link

lrnv commented Jan 22, 2024

👋 @allie-tatarian @@Karangupta1994 @djmannion @dgerosa @wmvanvliet, would any of you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

@wmvanvliet
Copy link

I'm a bit too busy at the moment to be a reviewer for this one. Project looks good though!

@Karangupta1994
Copy link

Karangupta1994 commented Jan 22, 2024 via email

@lrnv
Copy link

lrnv commented Jan 22, 2024

@Karangupta1994 Ok great ! Basically instructions will come later when we identified at least another reviewer.

@lrnv
Copy link

lrnv commented Jan 22, 2024

@editorialbot add @Karangupta1994 as reviewer

@editorialbot
Copy link
Collaborator Author

@Karangupta1994 added to the reviewers list!

@allie-tatarian
Copy link

Hi, I can help review this paper. Thanks!

@lrnv
Copy link

lrnv commented Jan 22, 2024

@allie-tatarian Great thanks ! I'll add you up and we will wait a bit more in case a third invited person manifests.

@lrnv
Copy link

lrnv commented Jan 22, 2024

@editorialbot add @allie-tatarian as reviewer

@editorialbot
Copy link
Collaborator Author

@allie-tatarian added to the reviewers list!

@djmannion
Copy link

Apologies, but I won't be able to be a reviewer for this paper.

@lrnv
Copy link

lrnv commented Jan 29, 2024

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #6294.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ Cython pre-review Python TeX Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning
Projects
None yet
Development

No branches or pull requests

9 participants