-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: The Kestrel software for simulations of morphodynamic Earth-surface flows #6079
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
|
👋 @jakelangham, @mdpiper, and @jatkinson1000 - This is the review thread for the paper. All of our communications will happen here from now on. Please read the "Reviewer instructions & questions" in the first comment above. Both reviewers have checklists at the top of this thread (in that first comment) with the JOSS requirements. As you go over the submission, please check any items that you feel have been satisfied. There are also links to the JOSS reviewer guidelines. The JOSS review is different from most other journals. Our goal is to work with the authors to help them meet our criteria instead of merely passing judgment on the submission. As such, the reviewers are encouraged to submit issues and pull requests on the software repository. When doing so, please mention #6079 so that a link is created to this thread (and I can keep an eye on what is happening). Please also feel free to comment and ask questions on this thread. In my experience, it is better to post comments/questions/suggestions as you come across them instead of waiting until you've reviewed the entire package. We aim for the review process to be completed within about 4-6 weeks but please make a start well ahead of this as JOSS reviews are by their nature iterative and any early feedback you may be able to provide to the author will be very helpful in meeting this schedule. |
Review checklist for @jatkinson1000Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Review checklist for @mdpiperConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@jakelangham a couple of points as I work through this:
I'll now read the paper in more detail and follow up with related comments. |
@jatkinson1000 I'll work through these in due course. I actually didn't realise a statement of need was required for the docs, but it makes complete sense. Regarding API documentation, it would be good to clarify this before proceeding much further and to get your opinion. We thought about this issue before submission and came to the view that an independent auto-generated API documentation was a bit too heavy duty for our purposes. While it is a sizeable codebase, the control flow is pretty linear and the routines that are 'library-like' in their design are probably in the minority. This is my own prejudice, but I have seen a fair few research codes where the auto-generated API docs were totally unhelpful compared with just reading the source code. I remember reading somewhere in the JOSS docs that for Fortran/C++ codes, having separate API documentation was optional (but encouraged), provided that the source code was well commented. So at the time we made the decision to concentrate on improving our source, since that seemed like a more obvious benefit to us, rather than spending time on a more formal API. We were aiming to make sure every module had a explanatory header + each of the most important routines, so hopefully you should find that this is the case. Let me know whether you think this is sufficient. |
@jakelangham with regards to the paper:
Overall I think this is well-written and organised software, and it is clearly a significant piece of work. I am more than happy to recommend publication in JOSS subject to resolving the minor issues raised above, the points which I believe will strengthen the paper, and any comments from @mdpiper. |
@jakelangham Yep, I agree, and I don't think it is necessary to add full API documentation here to satisfy review. That said, it is indeed encouraged, useful as projects/collaborators grow (speaking from experience with large climate models...), and easier to get on top of the sooner you start! I also feel when done well for appropriate routines/functions it can be a useful tool, but like many things it can be done badly! So do perhaps consider it in the future 😃 |
@jatkinson1000 A few updates...
jakelangham/kestrel@4a3799b fixes this I believe.
Done, in jakelangham/kestrel@f80a288
Done, in jakelangham/kestrel@7a7c83c |
@jatkinson1000 We have updated the github README.md now and added some tags to address this suggestion. |
@jatkinson1000 See replies below...
There isn't really a scientific reason for the name choice. But it's typical to view simulation data from a bird's-eye perspective. Kestrels spend a lot of time hovering in place when they're hunting so it felt appropriate to me, amongst other choices. Not sure I want to include that in the paper though.
Should be fixed by jakelangham/kestrel@ec77d54.
jakelangham/kestrel@ee06349 removes the 2014- part. This is one of several website references I included when citing alternative codes and to be honest, I don't know what the right convention is for the year of publication. Listing them all as 2023 doesn't feel quite right when some codes have been around for a decade or so.
I've tried to address this in jakelangham/kestrel@61aa2b3. My inclination was to preserve the 'line 91' paragraph as is, since it follows the description of the equations, but highlight up front earlier that the model framework and scheme are new. It is difficult to go in to much more detail without making things very technical, which I think is better suited to the companion article that we refer to.
It's meant to follow directly on from (2) in the last sentence. Perhaps jakelangham/kestrel@776da5a makes it easier to scan?
Done - jakelangham/kestrel@7ec1577
I've reworded things a bit here and there to try and address this - for example in jakelangham/kestrel@32ea8c5 and elsewhere - see what you think. The only additional comment to address is the inclusion of the schematic figure from the docs. The figure itself would need to be modified a little to align it with the paper. I'm not against this in principle, assuming it doesn't conflict with any length requirements, but would prefer to wait for @mdpiper's review before doing this. |
Thanks @jakelangham, that's looking good.
Right, I follow. My understanding is that you cite the 'date accessed' for web resources. Ideally there would be a JOSS/GMD paper or repository with a DOI you could also cite, but these are not common for older (and indeed many current 😢) codes. Here I would go with 2014 if it hasn't changed since then, or 2023 if it has. Looking at avaflow it has release numbers, so I would add that to the citation with date 2023 to be clear what you are comparing this work to.
I personally feel it would greatly improve the readability of the paper, but happy to wait for @mdpiper 's opinion.
I agree with not being too technical early on, but my issue at the moment is that when reading the paper it comes across that the principal reason for developing |
@jatkinson1000 Ok, I take the point - it should be possible to rewrite closer to what you're suggesting, with the caveat that its difficult to compare all these codes directly. The phrase about documentation could even be removed to be honest. Like the figure issue, I think I'll park this for now and come to it with a fresh perspective when addressing the next round of review comments. |
@editorialbot generate pdf |
@crvernon I've done as you suggested and checked the pdf draft over. Hopefully this fixes things? |
@editorialbot recommend-accept |
|
|
👋 @openjournals/ese-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#4909, then you can now move forward with accepting the submission by compiling again with the command |
@jakelangham that did the trick! Thanks! |
@jakelangham I've just read through the proof, and all looks good to me. |
I will be unavailable from Jan. 17-29. An EiC will make the final pass on this shortly so you should be good to go from here. I will check in when I come back to make sure everything is OK if you don't already have a published paper by then! Thanks! |
Thanks, very much appreciated indeed. |
I'll take over from here. Here are my steps:
|
@jakelangham Kudos on a really nicely written paper! Just a small fix here: jakelangham/kestrel#17 |
@kthyng Thanks, please note that I have taken the liberty of modifying your pull request to include an additional reference that was published recently, see jakelangham/kestrel@f0b9310 |
@editorialbot generate pdf |
Ok ready to go! |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Congrats on your new publication @jakelangham! Many thanks to editor @crvernon and reviewers @mdpiper and @jatkinson1000 for your time, hard work, and expertise!! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @jakelangham (Jake Langham)
Repository: https://github.com/jakelangham/kestrel/
Branch with paper.md (empty if default branch):
Version: v1.0.0
Editor: @crvernon
Reviewers: @mdpiper, @jatkinson1000
Archive: 10.5281/zenodo.10477693
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@mdpiper & @jatkinson1000, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @crvernon know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @jatkinson1000
📝 Checklist for @mdpiper
The text was updated successfully, but these errors were encountered: