-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: xeofs: Comprehensive EOF analysis in Python with xarray #6060
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
|
@DamienIrving, @malmans2 this is our review thread - we track main issues and your checklist in here, following the instructions above. Any issues you encounter or changes to make during your review you can raise as issues in the software repository directly, and feel free to link back here. |
Review checklist for @DamienIrvingConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Hi @DamienIrving, @malmans2! How are your reviews coming along? |
I'm all done - sorry for the delay! The authors have done a really excellent job with the package and associated documentation. The only very minor issue I found was a broken link to the contributing guide, for which I've submitted a pull request to fix: xarray-contrib/xeofs#129 |
That's great, thanks @DamienIrving |
Review checklist for @malmans2Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Hi all, sorry about the delay! I glanced through the repository and |
Hi everyone! I'm done with my review. Great package, and it's 100% in line with JOSS standards. I opened 2 minor issues:
I suggest to open a PR in xarray and add |
Suggestion to include [xeofs](https://github.com/nicrie/xeofs) in the xarray ecosystem documentation. xeofs enables fully multidimensional PCA / EOF analysis and related techniques with large datasets, thanks to the integration of xarray and dask. References: - [Github repository](https://github.com/nicrie/xeofs) - [Documentation](https://xeofs.readthedocs.io/en/latest/) - [JOSS review](openjournals/joss-reviews#6060)
Hi, many thanks @DamienIrving and @malmans2 for the reviews and the suggestions for improvement. We have incorporated the feedback and opened a PR for the xarray documentation here. |
Suggestion to include [xeofs](https://github.com/nicrie/xeofs) in the xarray ecosystem documentation. xeofs enables fully multidimensional PCA / EOF analysis and related techniques with large datasets, thanks to the integration of xarray and dask. References: - [Github repository](https://github.com/nicrie/xeofs) - [Documentation](https://xeofs.readthedocs.io/en/latest/) - [JOSS review](openjournals/joss-reviews#6060)
Hi @DamienIrving and @malmans2 I can see you've ticked everything off. Can you confirm you are happy with the changes made and there are no outstanding concerns please? |
|
@editorialbot generate pdf |
Great! @nicrie thanks for the great work you have done on this package - I am happy to recommend acceptance and pass it over to the EiCs. |
@editorialbot recommend-accept |
|
|
👋 @openjournals/ese-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#4868, then you can now move forward with accepting the submission by compiling again with the command |
My steps:
|
Paper comments:
|
Thank you for the comments @kthyng, both points should be addressed now by the recent commits. |
@editorialbot generate pdf |
Ok ready to go! |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Congrats on your new publication to @nicrie! Many thanks to editor @samhforbes and reviewers @DamienIrving, and @malmans2 for your time, hard work, and expertise!! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Wonderful! Also from our side many thanks for reviewing and editing the publication! :) |
Submitting author: @nicrie (Niclas Rieger)
Repository: https://github.com/nicrie/xeofs
Branch with paper.md (empty if default branch): joss-submission
Version: v2.2.4
Editor: @samhforbes
Reviewers: @DamienIrving, @malmans2
Archive: 10.5281/zenodo.10428233
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@DamienIrving & @malmans2, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @samhforbes know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @DamienIrving
📝 Checklist for @malmans2
The text was updated successfully, but these errors were encountered: