Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: AeroAcoustics.jl: A julia package for aeroacoustics #5912

Closed
editorialbot opened this issue Oct 1, 2023 · 36 comments
Closed

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Oct 1, 2023

Submitting author: @1oly (Oliver Lylloff)
Repository: https://github.com/1oly/AeroAcoustics.jl
Branch with paper.md (empty if default branch): paper
Version: v0.2.3
Editor: @faroit
Reviewers: @nantonel, @thejasvibr
Managing EiC: Kyle Niemeyer

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/9e20f1ec29f69e94bf0c9f1d2c22fa0d"><img src="https://joss.theoj.org/papers/9e20f1ec29f69e94bf0c9f1d2c22fa0d/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/9e20f1ec29f69e94bf0c9f1d2c22fa0d/status.svg)](https://joss.theoj.org/papers/9e20f1ec29f69e94bf0c9f1d2c22fa0d)

Author instructions

Thanks for submitting your paper to JOSS @1oly. Currently, there isn't a JOSS editor assigned to your paper.

@1oly if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 3 (PE) Physics and Engineering labels Oct 1, 2023
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.02 s (1803.1 files/s, 124522.2 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Julia                           19            146             61           1023
Markdown                         5             40              0            228
TeX                              1             15              0            189
YAML                             3              2             10            105
Jupyter Notebook                 1              0            334             69
TOML                             3              5              0             41
make                             1              3              0              8
-------------------------------------------------------------------------------
SUM:                            33            211            405           1663
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 884

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1137/141000671 is OK
- 10.2514/6.2017-3718 is OK
- 10.2514/6.2017-3719 is OK
- 10.1016/j.apacoust.2016.09.015 is OK
- 10.1007/978-3-662-05058-3 is OK
- 10.11581/dtu:00000102 is OK
- 10.1121/1.4922516 is OK
- 10.2514/1.J056113 is OK
- 10.1016/j.jsv.2005.12.046 is OK
- 10.1260/147547207783359459 is OK
- 10.1088/1742-6596/2265/2/022103 is OK
- 10.2514/1.J062313 is OK
- 10.2514/6.2022-2981 is OK
- 10.21105/joss.03349 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@kyleniemeyer
Copy link

@editorialbot invite @faroit as editor

Hi @faroit, could you handle this submission? I know you already have a few, and it would be ok to wait until one of those wraps up.

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

RHEOS.jl -- A Julia Package for Rheology Data Analysis
Submitting author: @akabla
Handling editor: @jedbrown (Active)
Reviewers: @adambeall, @gbruer15, @HaoZeke
Similarity score: 0.8071

Oceananigans.jl: Fast and friendly geophysical fluid dynamics on GPUs
Submitting author: @ali-ramadhan
Handling editor: @kthyng (Active)
Reviewers: @funsim, @mancellin
Similarity score: 0.8060

GeophysicalFlows.jl: Solvers for geophysical fluid dynamics problems in periodic domains on CPUs & GPUs
Submitting author: @navidcy
Handling editor: @pdebuyl (Active)
Reviewers: @ranocha, @eviatarbach
Similarity score: 0.8052

vSmartMOM.jl: an Open-Source Julia Package for Atmospheric Radiative Transfer and Remote Sensing Tools
Submitting author: @RupeshJey
Handling editor: @pdebuyl (Active)
Reviewers: @jimmielin, @arjunsavel
Similarity score: 0.8028

NuclearToolkit.jl: A Julia package for nuclear structure calculations
Submitting author: @SotaYoshida
Handling editor: @rkurchin (Active)
Reviewers: @mdavezac, @villaa
Similarity score: 0.8011

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before before considering asking the reviewers of these papers to review again for JOSS.

@1oly
Copy link

1oly commented Oct 3, 2023

Thank you for starting the pre-review. I understand that many of you are busy, and appreciate your time and effort! I've looked at potential reviewers in your list, and the following looks like very capable candidates:
@svchb and
@thejasvibr (if willing to review julia code)

Potential reviewers, that have not signed up (yet), but would be really good:
@ssfrr, @jfsantos, @nantonel
If willing to review julia-code: @fhchl, @gherold.

@faroit
Copy link

faroit commented Oct 10, 2023

@kyleniemeyer i'm not an expert on Julia and also not very proficient in acoustics but I can take this once I have capacity (should be in the next 2 weeks)

@kyleniemeyer
Copy link

@faroit ok, thanks! I'll assign this but then put it on the waitlist.

@1oly thanks for your patience—this will get moving soon.

@kyleniemeyer
Copy link

@editorialbot assign @faroit as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @faroit is now the editor

@kyleniemeyer kyleniemeyer added the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Oct 10, 2023
@1oly
Copy link

1oly commented Dec 12, 2023

Hi all, just checking in since some time has passed. Do you have an estimation on when this can move forward? I understand that your effort is on voluntary basis, so thank you for doing it 🥇

@kyleniemeyer
Copy link

Hello @faroit - are you able to get this moving on this review now?

@faroit
Copy link

faroit commented Dec 14, 2023

Hi @1oly thanks for waiting so long. I now have free capacity and will start the process of finding reviewers.

@faroit faroit removed the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Dec 14, 2023
@faroit
Copy link

faroit commented Jan 26, 2024

Hi @1oly sorry again for the long waiting time 🙇

Thank you already for providing a list of reviewers with domain knowledge. In addition to your proposal in #5912 (comment) I would also like to ask the following julia audio devs:

  • jongwook
  • martinholters
  • gummif

Can you please check all of them are ok wrt the JOSS COI policy?

@faroit
Copy link

faroit commented Jan 26, 2024

👋 @thejasvibr @svchb @ssfrr @jfsantos @nantonel - would any of you be willing to review this submission for JOSS? The JOSS review process takes place on GitHub and focuses on the software and a short paper. We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html

The software under review is a julia package https://github.com/1oly/AeroAcoustics.jl

This issue is a "pre-review" issue in which reviewers are assigned. Once sufficient reviewers are recruited we will open a dedicated review issue where the review will take place.

@svchb
Copy link

svchb commented Jan 26, 2024

@faroit You seem to have the packages mixed up??

But I would be willing to review https://github.com/1oly/AeroAcoustics.jl

@thejasvibr
Copy link

thejasvibr commented Jan 26, 2024 via email

@faroit
Copy link

faroit commented Jan 27, 2024

@svchb I linked the wrong submission. Sorry for that. Can you confirm that you could review https://github.com/1oly/AeroAcoustics.jl ? Thank you

@thejasvibr
Copy link

thejasvibr commented Jan 27, 2024 via email

@nantonel
Copy link

happy to contribute to the review!

@1oly
Copy link

1oly commented Jan 28, 2024

Hi @faroit. Thanks for handling this 👍

I can confirm there's no conflict of interest.

Hi @1oly sorry again for the long waiting time 🙇

Thank you already for providing a list of reviewers with domain knowledge. In addition to your proposal in #5912 (comment) I would also like to ask the following julia audio devs:

  • jongwook
  • martinholters
  • gummif

Can you please check all of them are ok wrt the JOSS COI policy?

@svchb
Copy link

svchb commented Jan 28, 2024

@svchb I linked the wrong submission. Sorry for that. Can you confirm that you could review https://github.com/1oly/AeroAcoustics.jl ? Thank you

yes i can

@faroit
Copy link

faroit commented Feb 7, 2024

👋 @jongwook @martinholters @gummif - would any of you be willing to review this submission for JOSS? The JOSS review process takes place on GitHub and focuses on the software and a short paper. We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html

The software under review is the following julia package https://github.com/1oly/AeroAcoustics.jl

This issue is a "pre-review" issue in which reviewers are assigned. Once sufficient reviewers are recruited we will open a dedicated review issue where the review will take place.

@faroit
Copy link

faroit commented Feb 7, 2024

@1oly Just some explanation on the process: I took some time to go through the submitted package to better understand it. As I'm not an expert in Julia myself, I realized its best to have at least someone with a lot of experience in julia packaging. So I am picking nanotel as the first reviewer. I will wait for the responses from above before picking the second one. I think the review process can then start soon.

@faroit
Copy link

faroit commented Feb 7, 2024

@editorialbot add @nantonel as reviewer

@editorialbot
Copy link
Collaborator Author

@nantonel added to the reviewers list!

@nantonel
Copy link

Thanks, will try to go through the package the soonest. Could you please let me know an approximate ETA for this? Thank you!

@faroit
Copy link

faroit commented Feb 11, 2024

@nantonel The review process will start in a separate issue when we have a second reviewer. I am going to assign one by next week. After that, the reviews are expected to be completed in about 2-4 weeks.

Thanks a lot for helping JOSS!

@faroit
Copy link

faroit commented Feb 21, 2024

@editorialbot add @thejasvibr as reviewer

@editorialbot
Copy link
Collaborator Author

@thejasvibr added to the reviewers list!

@faroit
Copy link

faroit commented Feb 21, 2024

@1oly after reading the paper myself, i feel confident that @thejasvibr would be a good pick as a second reviewer due to number of audio related techniques in AeroAcoustics. Happy that we can kick of the review phase now.

@faroit
Copy link

faroit commented Feb 21, 2024

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #6390.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants