-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PRE REVIEW]: AeroAcoustics.jl: A julia package for aeroacoustics #5912
Comments
Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
|
@editorialbot invite @faroit as editor Hi @faroit, could you handle this submission? I know you already have a few, and it would be ok to wait until one of those wraps up. |
Invitation to edit this submission sent! |
Five most similar historical JOSS papers: RHEOS.jl -- A Julia Package for Rheology Data Analysis Oceananigans.jl: Fast and friendly geophysical fluid dynamics on GPUs GeophysicalFlows.jl: Solvers for geophysical fluid dynamics problems in periodic domains on CPUs & GPUs vSmartMOM.jl: an Open-Source Julia Package for Atmospheric Radiative Transfer and Remote Sensing Tools NuclearToolkit.jl: A Julia package for nuclear structure calculations |
Thank you for starting the pre-review. I understand that many of you are busy, and appreciate your time and effort! I've looked at potential reviewers in your list, and the following looks like very capable candidates: Potential reviewers, that have not signed up (yet), but would be really good: |
@kyleniemeyer i'm not an expert on Julia and also not very proficient in acoustics but I can take this once I have capacity (should be in the next 2 weeks) |
@editorialbot assign @faroit as editor |
Assigned! @faroit is now the editor |
Hi all, just checking in since some time has passed. Do you have an estimation on when this can move forward? I understand that your effort is on voluntary basis, so thank you for doing it 🥇 |
Hello @faroit - are you able to get this moving on this review now? |
Hi @1oly thanks for waiting so long. I now have free capacity and will start the process of finding reviewers. |
Hi @1oly sorry again for the long waiting time 🙇 Thank you already for providing a list of reviewers with domain knowledge. In addition to your proposal in #5912 (comment) I would also like to ask the following julia audio devs:
Can you please check all of them are ok wrt the JOSS COI policy? |
👋 @thejasvibr @svchb @ssfrr @jfsantos @nantonel - would any of you be willing to review this submission for JOSS? The JOSS review process takes place on GitHub and focuses on the software and a short paper. We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html The software under review is a julia package https://github.com/1oly/AeroAcoustics.jl This issue is a "pre-review" issue in which reviewers are assigned. Once sufficient reviewers are recruited we will open a dedicated review issue where the review will take place. |
@faroit You seem to have the packages mixed up?? But I would be willing to review https://github.com/1oly/AeroAcoustics.jl |
Sounds very interesting. I'd be happy to be a reviewer for this package.
…On Fri, Jan 26, 2024, 11:31 PM Fabian-Robert Stöter < ***@***.***> wrote:
👋 @thejasvibr <https://github.com/thejasvibr> @svchb
<https://github.com/svchb> @ssfrr <https://github.com/ssfrr> @jfsantos
<https://github.com/jfsantos> @nantonel <https://github.com/nantonel> -
would any of you be willing to review this submission for JOSS? The JOSS
review process takes place on GitHub and focuses on the software and a
short paper. We carry out our checklist-driven reviews here in GitHub
issues and follow these guidelines:
https://joss.readthedocs.io/en/latest/reviewer_guidelines.html
The software under review is a julia package
https://github.com/mei-friend/mei-friend
<https://github.com/openjournals/joss-reviews/issues/mei-friend>
This issue is a "pre-review" issue in which reviewers are assigned. Once
sufficient reviewers are recruited we will open a dedicated review issue
where the review will take place.
—
Reply to this email directly, view it on GitHub
<#5912 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC657MITUWTZYOH7B2XOE5LYQQVE3AVCNFSM6AAAAAA5OS4THSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJSG44DCNJUGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@svchb I linked the wrong submission. Sorry for that. Can you confirm that you could review https://github.com/1oly/AeroAcoustics.jl ? Thank you |
Can confirm i'd be happy to review the Aeroacoustics package
…On Sat, Jan 27, 2024, 11:25 AM Fabian-Robert Stöter < ***@***.***> wrote:
@svchb <https://github.com/svchb> I linked the wrong submission. Sorry
for that. Can you confirm that you could review
https://github.com/1oly/AeroAcoustics.jl ? Thank you
—
Reply to this email directly, view it on GitHub
<#5912 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC657MK5HVFNK6EKYF2P3X3YQTIZFAVCNFSM6AAAAAA5OS4THSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJTGEYDQMBYGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
happy to contribute to the review! |
Hi @faroit. Thanks for handling this 👍 I can confirm there's no conflict of interest.
|
yes i can |
👋 @jongwook @martinholters @gummif - would any of you be willing to review this submission for JOSS? The JOSS review process takes place on GitHub and focuses on the software and a short paper. We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html The software under review is the following julia package https://github.com/1oly/AeroAcoustics.jl This issue is a "pre-review" issue in which reviewers are assigned. Once sufficient reviewers are recruited we will open a dedicated review issue where the review will take place. |
@1oly Just some explanation on the process: I took some time to go through the submitted package to better understand it. As I'm not an expert in Julia myself, I realized its best to have at least someone with a lot of experience in julia packaging. So I am picking |
@editorialbot add @nantonel as reviewer |
@nantonel added to the reviewers list! |
Thanks, will try to go through the package the soonest. Could you please let me know an approximate ETA for this? Thank you! |
@nantonel The review process will start in a separate issue when we have a second reviewer. I am going to assign one by next week. After that, the reviews are expected to be completed in about 2-4 weeks. Thanks a lot for helping JOSS! |
@editorialbot add @thejasvibr as reviewer |
@thejasvibr added to the reviewers list! |
@1oly after reading the paper myself, i feel confident that @thejasvibr would be a good pick as a second reviewer due to number of audio related techniques in AeroAcoustics. Happy that we can kick of the review phase now. |
@editorialbot start review |
OK, I've started the review over in #6390. |
Submitting author: @1oly (Oliver Lylloff)
Repository: https://github.com/1oly/AeroAcoustics.jl
Branch with paper.md (empty if default branch): paper
Version: v0.2.3
Editor: @faroit
Reviewers: @nantonel, @thejasvibr
Managing EiC: Kyle Niemeyer
Status
Status badge code:
Author instructions
Thanks for submitting your paper to JOSS @1oly. Currently, there isn't a JOSS editor assigned to your paper.
@1oly if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.
Editor instructions
The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:
The text was updated successfully, but these errors were encountered: