Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: HiddenMarkovModels.jl: generic, fast and reliable state space modeling #5874

Closed
editorialbot opened this issue Sep 25, 2023 · 49 comments
Assignees
Labels
Julia pre-review TeX Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning waitlisted Submissions in the JOSS backlog due to reduced service mode.

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Sep 25, 2023

Submitting author: @gdalle (Guillaume Dalle)
Repository: https://github.com/gdalle/HiddenMarkovModels.jl
Branch with paper.md (empty if default branch): joss
Version: v0.3.0
Editor: @jbytecode
Reviewers: @DanielRivasMD, @dmbates
Managing EiC: Arfon Smith

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/02568a7d960824132102d42439434b66"><img src="https://joss.theoj.org/papers/02568a7d960824132102d42439434b66/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/02568a7d960824132102d42439434b66/status.svg)](https://joss.theoj.org/papers/02568a7d960824132102d42439434b66)

Author instructions

Thanks for submitting your paper to JOSS @gdalle. Currently, there isn't a JOSS editor assigned to your paper.

@gdalle if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning labels Sep 25, 2023
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.04 s (2145.6 files/s, 172655.5 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Julia                           44            401             31           2035
TOML                             7            376              2           1677
Markdown                        11            226              0            637
SVG                              8              0              0            562
TeX                              2             15              0            225
YAML                             6              0             10            159
JSON                             1              0              0              1
-------------------------------------------------------------------------------
SUM:                            79           1018             43           5296
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 1014

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.5281/zenodo.4454565 is OK
- 10.18637/jss.v098.i16 is OK
- 10.1137/141000671 is OK
- 10.1007/0-387-28982-8 is OK
- 10.1016/S0006-3495(00)76441-1 is OK
- 10/cswph2 is OK
- 10.5281/ZENODO.4754896 is OK

MISSING DOIs

- 10.1109/icassp43922.2022.9746824 may be a valid DOI for title: GPU-Accelerated Forward-Backward Algorithm with Application to Lattic-Free MMI

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

Agents.jl: agent-based modeling framework in Julia
Reviewers: @Datseris, @mozhgan-kch
Similarity score: 0.8199

CategoricalTimeSeries.jl: A toolbox for categorical time-series analysis
Reviewers: @bkamins, @felixcremer
Similarity score: 0.8194

BoltzMM: an R package for maximum pseudolikelihood estimation of fully-visible Boltzmann machines
Reviewers: @ja-thomas, @schalkdaniel
Similarity score: 0.8161

MLJ: A Julia package for composable machine learning
Reviewers: @degleris1, @henrykironde
Similarity score: 0.8151

VBLinLogit: Variational Bayesian linear and logistic regression
Reviewers: @ManuelaS, @usethedata
Similarity score: 0.8140

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before before considering asking the reviewers of these papers to review again for JOSS.

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@arfon arfon added the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Sep 28, 2023
@arfon
Copy link
Member

arfon commented Sep 28, 2023

@gdalle - thanks for your submission to JOSS. We're currently managing a large backlog of submissions and the editor most appropriate for your area is already rather busy.

For now, we will need to waitlist this paper and process it as the queue reduces. Thanks for your patience!

@gdalle
Copy link

gdalle commented Sep 29, 2023

No worries

@arfon
Copy link
Member

arfon commented Nov 24, 2023

@editorialbot invite @jbytecode as editor

👋 @jbytecode, would you be willing to edit this submission for JOSS?

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@gdalle
Copy link

gdalle commented Nov 24, 2023

Hi! Since the submission was in the backlog, I took the opportunity to revamp the package significantly, and as a result the paper and benchmarks are outdated. Can we maybe put this submission on hold? Or is it easier for your logistics if I withdraw and resubmit later?

@jbytecode
Copy link

@editorialbot assign me as editor

@arfon - of course, gladly!

@editorialbot
Copy link
Collaborator Author

Assigned! @jbytecode is now the editor

@jbytecode
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@jbytecode
Copy link

@gdalle - How much time do you need to reach the final version of the manuscript?

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

CategoricalTimeSeries.jl: A toolbox for categorical time-series analysis
Submitting author: @johncwok
Handling editor: @jbytecode (Active)
Reviewers: @bkamins, @felixcremer
Similarity score: 0.8208

Agents.jl: agent-based modeling framework in Julia
Submitting author: @kavir1698
Handling editor: @jedbrown (Active)
Reviewers: @Datseris, @mozhgan-kch
Similarity score: 0.8166

MLJ: A Julia package for composable machine learning
Submitting author: @ablaom
Handling editor: @terrytangyuan (Retired)
Reviewers: @degleris1, @henrykironde
Similarity score: 0.8142

BoltzMM: an R package for maximum pseudolikelihood estimation of fully-visible Boltzmann machines
Submitting author: @andrewthomasjones
Handling editor: @yochannah (Retired)
Reviewers: @ja-thomas, @schalkdaniel
Similarity score: 0.8128

VBLinLogit: Variational Bayesian linear and logistic regression
Submitting author: @jdrugo
Handling editor: @usethedata (Retired)
Reviewers: @ManuelaS, @usethedata
Similarity score: 0.8108

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@gdalle
Copy link

gdalle commented Nov 24, 2023

@jbytecode I'm a bit swamped these days so I wanna play it safe and say early January

@jbytecode
Copy link

@arfon - ☝️ What to do for this issue? Set as paused or something else?

@gdalle
Copy link

gdalle commented Nov 24, 2023

I'm sorry for the inconvenience

@gdalle
Copy link

gdalle commented Nov 24, 2023

@editorialbot commands

@editorialbot
Copy link
Collaborator Author

Hello @gdalle, here are the things you can ask me to do:


# List all available commands
@editorialbot commands

# Get a list of all editors's GitHub handles
@editorialbot list editors

# Check the references of the paper for missing DOIs
@editorialbot check references

# Perform checks on the repository
@editorialbot check repository

# Adds a checklist for the reviewer using this command
@editorialbot generate my checklist

# Set a value for branch
@editorialbot set joss-paper as branch

# Generates the pdf paper
@editorialbot generate pdf

# Generates a LaTeX preprint file
@editorialbot generate preprint

# Get a link to the complete list of reviewers
@editorialbot list reviewers

@gdalle
Copy link

gdalle commented Nov 29, 2023

@editorialbot set joss as branch

@editorialbot
Copy link
Collaborator Author

Done! branch is now joss

@jbytecode
Copy link

@gdalle - Ping me when you're ready. Thank you in advance.

@gdalle
Copy link

gdalle commented Dec 26, 2023

I will, so sorry for the delay. The package will be infinitely more generic and interesting as a result 😊

@jbytecode
Copy link

@gdalle - could you please update your status?

@gdalle
Copy link

gdalle commented Feb 9, 2024

I've been making progress on the benchmarks, I'll have it ready this month

@gdalle
Copy link

gdalle commented Feb 22, 2024

I have released a new version with everything I want in it, cleaned up the benchmark set and revamped the paper, which has everything but the benchmark plots.
I only have doubts on the performance of the latest Python competitor, so I have asked its devs for feedback on my benchmark code in order to be as fair as possible. If they don't answer within a week I'll just add my current plots to the paper and submit for good.

See the issue:

@gdalle
Copy link

gdalle commented Feb 22, 2024

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@gdalle
Copy link

gdalle commented Feb 22, 2024

this article proof is still incomplete but only the benchmark section is missing

@jbytecode
Copy link

@gdalle - thank you for updating your status.

@gdalle
Copy link

gdalle commented Feb 29, 2024

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@gdalle
Copy link

gdalle commented Feb 29, 2024

@jbytecode the paper and package are ready for review, sorry for the delay

@gdalle
Copy link

gdalle commented Feb 29, 2024

I also would like to change the title to

HiddenMarkovModels.jl: generic, fast and reliable state space modeling

if that's not a problem

@jbytecode jbytecode changed the title [PRE REVIEW]: HiddenMarkovModels.jl: generic, fast and reliable latent variable modeling [PRE REVIEW]: HiddenMarkovModels.jl: generic, fast and reliable state space modeling Feb 29, 2024
@jbytecode
Copy link

@gdalle - Do you have any suggestions for potential reviewers? You can use the reviewers system link provided at the top of this page. Please don't use the @ character when you mention their GitHub account names. Thank you in advance.

@jbytecode
Copy link

👋👋👋 Dear @dmbates, @DanielRivasMD 👋👋👋

Would you be willing to assist in reviewing this submission for JOSS (Journal of Open Source Software)?

JOSS publishes articles about open source research software. The submission I'd like you to review is titled:

HiddenMarkovModels.jl: generic, fast and reliable state space modeling

You can find more information at the top of this Github issue (#5874).

The review process at JOSS is unique: it takes place in a GitHub issue, is open, and author-reviewer-editor conversations are encouraged. If you have any questions please let me know.

This is the pre-review issue. After setting at least 2 reviewers we will start the review process in a separate thread. In that thread, there will be 23 check items for each single reviewer.

Thank you in advance!

@DanielRivasMD
Copy link

DanielRivasMD commented Feb 29, 2024 via email

@jbytecode
Copy link

@editorialbot add @DanielRivasMD as reviewer

@DanielRivasMD - Thank you for accepting our invitation. Whenever we assign at least one more reviewers, the review will start in a separate thread. I will present the instructions there.

@editorialbot
Copy link
Collaborator Author

@DanielRivasMD added to the reviewers list!

@dmbates
Copy link

dmbates commented Mar 1, 2024

I too am happy to serve as a reviewer.

@jbytecode
Copy link

@editorialbot add @dmbates as reviewer

@dmbates - Thank you for accepting our invitation.

@dmbates, @DanielRivasMD - I am now starting the review in a separate thread. See you there!

@editorialbot
Copy link
Collaborator Author

@dmbates added to the reviewers list!

@jbytecode
Copy link

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #6436.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Julia pre-review TeX Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning waitlisted Submissions in the JOSS backlog due to reduced service mode.
Projects
None yet
Development

No branches or pull requests

6 participants