Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: pygwb: a Python-based library for gravitational-wave background searches #5333

Closed
editorialbot opened this issue Apr 3, 2023 · 31 comments
Assignees
Labels
AAS Papers being published together with a AAS submission Jupyter Notebook pre-review Python TeX Track: 1 (AASS) Astronomy, Astrophysics, and Space Sciences

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Apr 3, 2023

Submitting author: @a-renzini (Arianna Renzini)
Repository: https://github.com/a-renzini/pygwb/
Branch with paper.md (empty if default branch): joss_submission
Version: v1.0.0
Editor: @plaplant
Reviewers: @Sbozzolo
Managing EiC: Dan Foreman-Mackey

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/29911164eb1698ada6d2c9a3ee585590"><img src="https://joss.theoj.org/papers/29911164eb1698ada6d2c9a3ee585590/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/29911164eb1698ada6d2c9a3ee585590/status.svg)](https://joss.theoj.org/papers/29911164eb1698ada6d2c9a3ee585590)

Author instructions

Thanks for submitting your paper to JOSS @a-renzini. Currently, there isn't a JOSS editor assigned to your paper.

@a-renzini if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 1 (AASS) Astronomy, Astrophysics, and Space Sciences labels Apr 3, 2023
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

@dfm
Copy link

dfm commented Apr 3, 2023

@a-renzini — Thanks for your submission! All the suitable editors are currently working at capacity so I'm going to need to wait list this review for now and update you as soon as an editor is available.

In the meantime, the paper is failing to generate since it has an invalid ORCID. Can you check all the ORCIDs and update the paper?

@a-renzini
Copy link

@editorialbot generate pdf

@a-renzini
Copy link

@a-renzini — Thanks for your submission! All the suitable editors are currently working at capacity so I'm going to need to wait list this review for now and update you as soon as an editor is available.

In the meantime, the paper is failing to generate since it has an invalid ORCID. Can you check all the ORCIDs and update the paper?

Thank you! I have now updated the .md and hopefully the generation will go through. It was already succeeding on my side so I am not entirely sure whether I fixed the issue, so I tried using the editorial bot generation command.

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@dfm dfm added the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Apr 4, 2023
@dfm
Copy link

dfm commented Apr 4, 2023

@editorialbot check repository

@dfm
Copy link

dfm commented Apr 4, 2023

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.31 s (265.8 files/s, 70588.4 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          43           1821           2609           8277
Jupyter Notebook                13              0           5565           1462
INI                              7             16             99            316
Markdown                         5            112              0            293
TeX                              1             31              0            193
YAML                             3             20             15            171
reStructuredText                 8            212            374            164
make                             1              4              6             10
TOML                             1              2              0              6
-------------------------------------------------------------------------------
SUM:                            82           2218           8668          10892
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 1579

@editorialbot
Copy link
Collaborator Author

Failed to discover a Statement of need section in paper

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/j.softx.2021.100657 is OK
- 10.3847/1538-4365/ab06fc is OK
- 10.1093/mnras/staa278 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.1109/MCSE.2007.55 is OK
- 10.1038/s41592-019-0686-2 is OK
- 10.1103/physrevd.104.022004 is OK
- 10.3847/1538-4357/ac7c74 is OK
- 10.1051/0004-6361/201833910 is OK
- 10.1007/s41114-017-0004-1 is OK
- 10.3390/galaxies10010034 is OK
- 10.1103/PhysRevD.59.102001 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@dfm
Copy link

dfm commented Apr 4, 2023

@a-renzini — Thanks! As the bot has requested, we require an explicit "Statement of need" section title in the manuscript. Please add that - otherwise it's looking good.

@dfm
Copy link

dfm commented Apr 4, 2023

I should also add - is it true that none of the other authors have ORCIDs? Please ask your co-authors to add or tell you their ORCIDs. That field should only be left blank in cases where the author truly doesn't have one!

@a-renzini
Copy link

I should also add - is it true that none of the other authors have ORCIDs? Please ask your co-authors to add or tell you their ORCIDs. That field should only be left blank in cases where the author truly doesn't have one!

Thanks - we are collecting the author ORCIDs and adding in the missing section. We'll refresh the submission soon!

@dfm
Copy link

dfm commented Apr 10, 2023

@a-renzini — Another quick clarification: I believe that this submission is made in parallel with a AAS publication - is that right? If so, we need to remember to make reviewers aware of our JOSS collaboration with AAS publishing, and that as part of this collaboration, AAS publishing makes a small donation to the running costs of JOSS.

@dfm dfm added the AAS Papers being published together with a AAS submission label Apr 10, 2023
@a-renzini
Copy link

@dfm that's right - the AAS submission is currently under review (submissions were made roughly at the same time).

@a-renzini
Copy link

ORCIDs and statement of need have been added!

@editorialbot generate pdf

@dfm
Copy link

dfm commented Apr 11, 2023

@editorialbot generate pdf

The message to the bot always needs to be the first part of the comment!

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@a-renzini
Copy link

Hello! just checking in to ask whether a reviewer has been assigned to this? Thanks!

@dfm
Copy link

dfm commented Apr 28, 2023

@a-renzini — Thanks for checking in! Unfortunately all the editors are working at capacity still. I'll try to get someone assigned ASAP and keep you posted. Thanks for your patience!

@plaplant
Copy link

plaplant commented May 5, 2023

@editorialbot assign @plaplant as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @plaplant is now the editor

@dfm dfm removed the waitlisted Submissions in the JOSS backlog due to reduced service mode. label May 5, 2023
@plaplant
Copy link

plaplant commented May 5, 2023

@a-renzini thanks for your patience! I'll be editing the submission, so please let me know if you have any questions.

The next step is for me to find two reviewers. I will reach out to folks, but if you have suggestions for people who you know might be a good fit, then please let me know. I'll reply to this thread as I find good candidates. Once we have two reviewers, we'll move on to the review stage.

@plaplant
Copy link

plaplant commented May 8, 2023

@editorialbot add @Sbozzolo as reviewer

@editorialbot
Copy link
Collaborator Author

@Sbozzolo added to the reviewers list!

@a-renzini
Copy link

@a-renzini thanks for your patience! I'll be editing the submission, so please let me know if you have any questions.

The next step is for me to find two reviewers. I will reach out to folks, but if you have suggestions for people who you know might be a good fit, then please let me know. I'll reply to this thread as I find good candidates. Once we have two reviewers, we'll move on to the review stage.

Great, thanks! I will reach out if I come up with a potential second reviewer.

@plaplant
Copy link

plaplant commented May 8, 2023

@a-renzini I'm still looking for a second reviewer, but I'm going to go ahead and start the main review thread. @Sbozzolo will be traveling soon, and I wanted to make sure there was a chance to post initial feedback. When I find a second reviewer, I will add them to the review thread as well.

@plaplant
Copy link

plaplant commented May 8, 2023

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #5454.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AAS Papers being published together with a AAS submission Jupyter Notebook pre-review Python TeX Track: 1 (AASS) Astronomy, Astrophysics, and Space Sciences
Projects
None yet
Development

No branches or pull requests

4 participants