-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: Sarracen: a Python package for analysis and visualization of smoothed particle hydrodynamics data #5263
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
|
@hlim88 & @JBorrow, thanks again for agreeing to review. This is the review thread for the paper. All of our correspondence will now happen here. Please read the "Reviewer instructions & questions" in the first comment above, and generate your checklists by commenting The JOSS review is different from most other journals. We aim to work with the authors to help them meet our criteria instead of merely passing judgment on the submission. We also encourage reviewers to submit issues and pull requests on the software repository. When doing so, please mention We aim for the review process to be completed within about 4-6 weeks but start whenever you can. JOSS reviews are iterative and the authors can start responding while you continue to review other parts of the submission. |
Thanks, looking forward to it! I will review formally shortly, but for now I would strongly suggest the authors check out this relevant paper: https://ui.adsabs.harvard.edu/abs/2021arXiv210605281B/abstract |
Review checklist for @hlim88Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Review checklist for @JBorrowConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@ttricco the only thing missing for me now is a clear set of contribution/community guidelines within the software repository. |
@warrickball as I noted above just waiting on a contributing guide/community guidelines then we're good to go. |
@warrickball Sorry I was busy on recent weeks for travels and others. Finalizing the review and also has same comment as @JBorrow about contributing guide/community guide line |
Sorry for the delay on this last piece about contributing / community guide lines -- have been on vacation. We will address this once I'm back in the office next week. |
Excellent, congrats! I am now happy with the package. Thanks Terrence & Andrew! |
Hi @hlim88, it looks we're now only waiting for your review. I can see you've already worked through some items, so if there's anything you'd like the authors to work on, you can mention it right away so they can work on it while you finish your review. |
Sorry I will finalize today only thing I need to check is the software paper which will be short to review |
@warrickball Finish to review the software paper. @ttricco only one minor comment is you may want to mention/compare general visualization software such as Paraview and Visit (of course these are not targeting to visualize SPH data but it is well-known and widely used, also used for SPH data too). Other than that, I think this is ready to be out! Thanks @ttricco I am also looking forward to using Sarracen too! |
@hlim88 @warrickball Done. References have been added for Paraview and Visit in the paper. Thanks. |
@editorialbot generate pdf |
Hi @ttricco, if you're happy with the code, the last step is to create a tagged release and archive and upload it to an archiving service like Zenodo or Figshare, then post the version number and archive DOI here so I can attach them to our metadata. You're welcome to do it however you like but when I once published in JOSS, I followed instructions like these to publish from GitHub to Zenodo. I've never tried it (nor read these docs) but something similar looks possible with Figshare. |
@warrickball I've archived Sarracen onto Zenodo. The version is 1.2.1 and archive DOI 10.5281/zenodo.8034448. Thanks for working through this, and for the time of the two reviewers! |
Post-Review Checklist for Editor and AuthorsAdditional Author Tasks After Review is Complete
Editor Tasks Prior to Acceptance
|
Thanks, @ttricco. I notice that the first author in the Zenodo archive is "AndrewHarris709", rather than Andrew Harris as in the JOSS paper. Can you update this in the Zenodo archive? |
@editorialbot set v1.2.1 as version |
Done! version is now v1.2.1 |
@editorialbot set 10.5281/zenodo.8034448 as archive |
Done! archive is now 10.5281/zenodo.8034448 |
@warrickball Good catch. I've updated the author name (and other metadata) on the zenodo archive. |
Thanks! Sorry for the back and forth, but one more thing: could you update the license in the Zenodo archive too? Zenodo doesn't detect all possible LICENCE files. Along the way, I noticed the same issue affected my own JOSS submission about a year ago, which I've now fixed too. 🙃 |
I noticed that issue last night too when I was fixing the author names. The licence should be correct now. |
@editorialbot generate pdf |
@editorialbot recommend-accept |
|
|
👋 @openjournals/aass-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#4311, then you can now move forward with accepting the submission by compiling again with the command |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦 |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
@hlim88, @JBorrow – many thanks for your reviews here and to @warrickball for editing this submission! JOSS relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you ✨ @ttricco – your paper is now accepted and published in JOSS ⚡🚀💥 |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @ttricco (Terrence Tricco)
Repository: https://github.com/ttricco/sarracen
Branch with paper.md (empty if default branch):
Version: v1.2.1
Editor: @warrickball
Reviewers: @hlim88, @JBorrow
Archive: 10.5281/zenodo.8034448
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@hlim88 & @JBorrow, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @warrickball know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @hlim88
📝 Checklist for @JBorrow
The text was updated successfully, but these errors were encountered: