-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: DAPPER: Data Assimilation with Python: a Package for Experimental Research #5150
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
|
Wordcount for |
Review checklist for @sara-02Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Hi @Shreyas911, would you please generate your checklist at your convenience? Thanks for your time. |
Dear all, Thank you for agreeing to review this software. I await your comments and will try to be responsive! |
@Shreyas911 Thanks for your prompt response. Take your time. |
Review checklist for @Shreyas911Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Hi @sara-02 and @Shreyas911, any updates on the review? Please let us know if you need any help. Thanks again for your time. |
Hi @patnr, Sorry for the delay, here's what I think so far. I have not run the examples yet. Functionality
I get the following error when I create the conda environment dapper-env on our Linux machine for Python 3.16 as suggested in your README.
I tried my own conda environments with Python 3.10 or above and still had the same error. I guess mpl_tools needs to be specifically added to the environment
I will verify these soon if I can get this Documentation
The target audience is not explicitly specified in the documentation, I think.
A list of dependencies should be stated, including
This is not explicitly stated. I do see a dev section, however, it would be great to include in the README.md file explicitly how to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support. Software Paper
This section is missing from the paper. I do see it in the README, so maybe add that to the paper as well.
A few minor suggestions -
|
Thank you @Shreyas911 for the feedback. Concerning
The README states
Do you think its needs further clarification?
The dependencies, including
Done, thank you.
Done, thank you.
The 2nd occurrence of an item is supposed to reference the first (cause and effect), but I agree that it probably just comes off as confusing, so I removed it.
Done, thanks. Hopefully the following will update the paper.
|
@editorialbot generate pdf |
Sorry for the delay, I quite like the paper. I have checked all the boxes related to that. The Otherwise, thanks to your instructions, I was able to install and run the software. I think all the requirements are adequately satisfied. I am able to mark the review as complete. It is an amazing piece of Python code, and I personally learned a lot from its construction. Thanks for the opportunity to review such great software! :) |
Hi @Shreyas911 thanks for your time reviewing this submission. Appreciate it. |
Hi @sara-02, could you please start your review at your convenience? Please feel free to let me know if you need any help. Thanks in advance for your time. |
Dear @Shreyas911 , I added a section "Statement of need" as per your suggestion. |
@editorialbot generate pdf |
@editorialbot check references |
|
Hi @patnr, can you check the Post-Review Checklist above? Please Archive the release on Zenodo/figshare/etc and post the DOI here after you complete it. Thanks for your time. |
Thank you for the guidelines.
|
@editorialbot generate pdf |
@editorialbot set 10.5281/zenodo.10710355 as archive |
Done! archive is now 10.5281/zenodo.10710355 |
@editorialbot set v1.6.0 as version |
Done! version is now v1.6.0 |
@editorialbot recommend-accept |
|
|
👋 @openjournals/dsais-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5061, then you can now move forward with accepting the submission by compiling again with the command |
@sara-02 @Shreyas911 Thanks for your time for reviewing this submission. @openjournals/dsais-eics, this submission looks good to me now. Could you take it from here? Thanks. |
@patnr – one more thing, could you please add a section named |
@editorialbot generate pdf |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
@sara-02, @Shreyas911 – many thanks for your reviews here and to @Fei-Tao for editing this submission! JOSS relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you ✨ @patnr – your paper is now accepted and published in JOSS ⚡🚀💥 |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @patnr (Patrick Nima Raanes)
Repository: https://github.com/nansencenter/DAPPER
Branch with paper.md (empty if default branch): paper_joss
Version: v1.6.0
Editor: @Fei-Tao
Reviewers: @sara-02, @Shreyas911
Archive: 10.5281/zenodo.10710355
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@sara-02 & @Shreyas911, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @Fei-Tao know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @sara-02
📝 Checklist for @Shreyas911
The text was updated successfully, but these errors were encountered: