Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: Water Systems Integrated Modelling framework, WSIMOD: A Python package for integrated modelling of water quality and quantity across the water cycle #4918

Closed
editorialbot opened this issue Nov 8, 2022 · 26 comments
Assignees
Labels
pre-review Python Track: 6 (ESE) Earth Sciences and Ecology

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Nov 8, 2022

Submitting author: @barneydobson (Barnaby Dobson)
Repository: https://github.com/barneydobson/wsi
Branch with paper.md (empty if default branch):
Version: 0.2_joss_submission
Editor: @crvernon
Reviewers: @cheginit, @jlarsen-usgs
Managing EiC: Kristen Thyng

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/9df09dbd84388e336f911bb1d55c7a87"><img src="https://joss.theoj.org/papers/9df09dbd84388e336f911bb1d55c7a87/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/9df09dbd84388e336f911bb1d55c7a87/status.svg)](https://joss.theoj.org/papers/9df09dbd84388e336f911bb1d55c7a87)

Author instructions

Thanks for submitting your paper to JOSS @barneydobson. Currently, there isn't a JOSS editor assigned to your paper.

@barneydobson if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 6 (ESE) Earth Sciences and Ecology labels Nov 8, 2022
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.17 s (362.1 files/s, 107925.2 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          34           2504           4000           6899
SVG                              2              0              1           2355
XML                              1              0             52           1534
Markdown                        16             91              0            212
JSON                             3              0              0             76
TeX                              1              6              0             68
YAML                             2              7              4             47
CSS                              1              4              3             20
-------------------------------------------------------------------------------
SUM:                            60           2612           4060          11211
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 448

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- None

MISSING DOIs

- 10.31223/osf.io/64cvn may be a valid DOI for title: Protecting rivers by integrating supply-wastewater infrastructure planning and coordinating operational decisions
- 10.1016/j.scitotenv.2021.150642 may be a valid DOI for title: Hierarchical systems integration for coordinated urban-rural water quality management at a catchment scale
- 10.3389/frwa.2021.641462 may be a valid DOI for title: Integrated modelling to support analysis of COVID-19 impacts on London’s water system and in-river water quality
- 10.1002/essoar.10507590.1 may be a valid DOI for title: A reduced complexity model with graph partitioning for rapid hydraulic assessment of sewer networks
- 10.3389/frwa.2021.773974 may be a valid DOI for title: The value of aggregated city scale models to rapidly assess SuDS in combined sewer systems
- 10.1002/essoar.10511984.1 may be a valid DOI for title: Optimisation of Urban-Rural Nature-Based Solutions for Integrated Catchment Water Management

INVALID DOIs

- None

@barneydobson
Copy link

barneydobson commented Nov 8, 2022 via email

@kthyng
Copy link

kthyng commented Nov 8, 2022

Hi @barneydobson and thanks for your submission! Our relevant editors are currently full so I will need to put you on our waitlist. Thank you for your patience.

@kthyng kthyng added the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Nov 8, 2022
@kthyng
Copy link

kthyng commented Nov 8, 2022

In the meantime you could address those missing DOIs in your paper — they aren't always correct but please check them out.

@barneydobson
Copy link

barneydobson commented Nov 9, 2022 via email

@kthyng
Copy link

kthyng commented Dec 6, 2022

@crvernon Says he can handle this one!

@kthyng
Copy link

kthyng commented Dec 6, 2022

@editorialbot assign @crvernon as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @crvernon is now the editor

@kthyng kthyng removed the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Dec 6, 2022
@crvernon
Copy link

crvernon commented Dec 6, 2022

👋 @barneydobson - The first step in this pre-review is to find at least 2 reviewers. If you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

@barneydobson
Copy link

barneydobson commented Dec 6, 2022 via email

@crvernon
Copy link

crvernon commented Dec 7, 2022

@jlarsen-usgs are you game for another review? Let me know if so and I'll get you added. Thanks!

@crvernon
Copy link

crvernon commented Dec 7, 2022

👋 Hi there @cheginit! Are you up for reviewing this submission? As a reminder, we do checklist based reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

@cheginit
Copy link

cheginit commented Dec 7, 2022

@crvernon Yes, I can review this submission.

@jlarsen-usgs
Copy link

@crvernon Yes, I can review this submission

@crvernon
Copy link

crvernon commented Dec 8, 2022

Awesome @cheginit and @jlarsen-usgs! You two are great!

@crvernon
Copy link

crvernon commented Dec 8, 2022

@editorialbot add @cheginit as reviewer

@editorialbot
Copy link
Collaborator Author

@cheginit added to the reviewers list!

@crvernon
Copy link

crvernon commented Dec 8, 2022

@editorialbot add @jlarsen-usgs as reviewer

@editorialbot
Copy link
Collaborator Author

@jlarsen-usgs added to the reviewers list!

@crvernon
Copy link

crvernon commented Dec 8, 2022

👋 Alright @barneydobson @cheginit @jlarsen-usgs - I am going to close this Pre-Review and kick off the full review which you should receive a notification for. Thanks!

@crvernon
Copy link

crvernon commented Dec 8, 2022

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #4996.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-review Python Track: 6 (ESE) Earth Sciences and Ecology
Projects
None yet
Development

No branches or pull requests

6 participants