-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: ur-scape: harnessing data for stakeholder participation in city-making processes #4664
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
|
Review checklist for @winstonyymConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Review checklist for @cforgaciConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
I have completed a first pass of the software and tested the major functionalities. Overall, ur-scape is a beautifully designed software and has clear pragmatic implications for urban planning. It is easy to use and quite aesthetically pleasing. The focus on rapid urbanisation issues in Southeast Asia is indeed a critical and under-studied area. This is especially important given that more than 50% of urbanisation will happen in Asia over the next decade. Software would go a long way to helping planners and local decision makers in these cities. I have raised some minor issues for the authors to consider. |
I have completed my final pass of ur-scape and expanding testing of the main package functionalities. The authors have kindly addressed the raised issues and we have resolved them successfully. The package works really well, use cases are interesting as well. It was quite an amazing user experience and ur-scape will definitely benefit many city planners in Southeast Asia. |
Thank you @winstonyym for pointing out these overlooked issues of ur-scape and working with us during the review process. Much appreciated from the ur-scape team 🙏 |
Dear editor(s) @editorialbot @hugoledoux: the authors have addressed the comments from @winstonyym. Please advise our next step moving forward :) |
@luyuhao0326 I have seen yes. Now we need to wait for @cforgaci feedback, he promised me to do it this week. |
I have concluded my first review in which I tested the functionalities of ur-scape and examined the documentation. The software is a beautifully designed data visualization and analysis tool with a very accessible interface and considerable impact demonstrated with specific use cases. It would be great if the excellent video material and training data mentioned in UrbanRuralSystems/ur-scape#9 would be made more accessible in the documentation. I raised a couple of minor issues that should be easy to resolve. |
@hugoledoux, please consider my review concluded. @luyuhao0326, thank you for resolving the issues promptly and in full. ur-scape is clearly relevant, versatile, and impactful for the targeted use cases and geographic context. It was a pleasure reviewing it. |
@cforgaci thank you very much for the feedback -- they are meticulous and very helpful. It was a great experience working on this with you. |
@editorialbot generate pdf |
@editorialbot check references |
|
I see that the issues from the reviewers have been fixed (pretty quick!) and that the reviewers are happy. One thing we need to discuss however, and it's a not-so-nice topic: authorship. I see that only 3 of the six authors have contributed to the code, and JOSS works differently from academic. We don't allow the person funding a project to put their names because of the fact that they have the money. The rules are there: https://joss.readthedocs.io/en/latest/submitting.html?highlight=authorship#authorship You'll see that it's not only git commits that count, but since I can't see the contributions of 3 of the authors (especially the first one), could you please elaborate on their contributions to this package? Also, I went over your paper and fixed a few things, please accept this PR: UrbanRuralSystems/ur-scape#12 |
Thank you @hugoledoux for coordinating our submission. Your question on (co)authorship is critical and I will clarify the roles of each author below. As you may have noticed, ur-scape is relatively mature with its own UI/UX and a large (growing) body of users (and hopefully more developers with this submission at JOSS). One thing that I can be clear of is that none of the co-authors were included simply because of their "purely financial and organizational" roles in the ur-scape development. In general, ur-scape is supported by three categories of contributors: designers, scientists, and software engineers. Some of them are coders on Github, and some of them are not. Some of them work astride multiple categories, and some of them have a very focused work task given their expertise. In our submission, we included key contributors from each category to credit their work in the development of ur-scape. In addition, due to the nature and key audience of JOSS, we prioritized contributors with a more software development focus. The first three authors (Neudecker, Joos, and Zaol-kefli) are key contributors that translated ur-scape from a vision into usable software. Neudecker, in particular, with his expertise in UX/UI and excellent programming skills, not only created a smooth and intuitive user experience but also managed to help us overcome many technical obstacles (e.g. qgis importer). Lu and Mangal provided support in data management, GIS, and capacity building. ur-scape was never intended to compete with ESRI and QGIS as a mapping software. It however heavily relies on principles and techniques that are crucial to the accuracy and precision of the software. Even though these technicalities are often hidden behind the curtains in ur-scape, we need experts like Lu and Mangal to ensure the science and relevance to the GIS community. Mangal with her background in urban designing also contributes to bringing forth the tool to a range of users varying from experts to non-experts through engagements such as Charrettes and collaborative projects with City governments. She has also developed the capacity-building platform for ur-scape to facilitate an easy uptake of the software. Lu also contributed to the writing, submission, and revision of this submission. Cairns, the principal investigator of ur-scape, leads the team of software developers and scientists, as well as external designers and professionals to make sure that ur-scape is a piece of software that answers the needs of real-world planners and policy-makers. With his training in architecture, Cairns also pushes ur-scape in its pragmatic and aesthetic capabilities, two important qualities that made stakeholder engagement and idea exchange in ur-scape so effortless and pleasant. Cairns also contributed to the writing of this article. Ur-scape has also welcomed other developers and contributors in the past, which we have acknowledged on its Github homepage. The authors listed above are the current core team of ur-scape. |
@editorialbot recommend-accept |
|
👋 @openjournals/sbcs-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#3732, then you can now move forward with accepting the submission by compiling again with the command |
|
@luyuhao0326 – I found a few typos in your paper. Could you please merge this PR? UrbanRuralSystems/ur-scape#13 |
@editorialbot recommend-accept |
|
👋 @openjournals/sbcs-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#3734, then you can now move forward with accepting the submission by compiling again with the command |
|
@luyuhao0326 – apologies but I have one more fix. The references aren't rendering properly and this PR should fix it: UrbanRuralSystems/ur-scape#14 |
@arfon PR merged! And thanks for checking this for us. I should have done this myself first. Overall, this has been a very enjoyable and productive process with JOSS. Look forward to engaging with you, @hugoledoux, and other editors in the coming years. |
@editorialbot recommend-accept |
|
👋 @openjournals/sbcs-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#3737, then you can now move forward with accepting the submission by compiling again with the command |
|
@editorialbot accept |
|
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
@winstonyym, @cforgaci – many thanks for your reviews here and to @hugoledoux for editing this submission! JOSS relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you ✨ @luyuhao0326 – your paper is now accepted and published in JOSS ⚡🚀💥 |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @luyuhao0326 (Yuhao Lu)
Repository: https://github.com/UrbanRuralSystems/ur-scape
Branch with paper.md (empty if default branch): paper
Version: v0.9.96
Editor: @hugoledoux
Reviewers: @winstonyym, @cforgaci
Archive: 10.3929/ethz-b-000578490
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@winstonyym & @cforgaci, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @hugoledoux know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @winstonyym
📝 Checklist for @cforgaci
The text was updated successfully, but these errors were encountered: