Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: DART: Dynamic Animation and Robotics Toolkit #460

Closed
whedon opened this issue Nov 16, 2017 · 38 comments
Closed

[PRE REVIEW]: DART: Dynamic Animation and Robotics Toolkit #460

whedon opened this issue Nov 16, 2017 · 38 comments
Assignees

Comments

@whedon
Copy link

whedon commented Nov 16, 2017

Submitting author: @jslee02 (Jeongseok Lee)
Repository: https://github.com/dartsim/dart
Version: 6.3.0
Editor: @Kevin-Mattheus-Moerman
Reviewer: @bmagyar

Author instructions

Thanks for submitting your paper to JOSS @jslee02. The JOSS editor (shown at the top of this issue) will work with you on this issue to find a reviewer for your submission before creating the main review issue.

@jslee02 if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Nov 16, 2017

Hello human, I'm @whedon. I'm here to help you with some common editorial tasks. @labarba it looks like you're currently assigned as the editor for this paper 🎉

For a list of things I can do to help you, just type:

@whedon commands

@arfon
Copy link
Member

arfon commented Nov 16, 2017

👋 @labarba - the submitting author suggested you as the editor.

@jslee02
Copy link

jslee02 commented Nov 17, 2017

Thank you for initiating this process!

I have a question about ORCID and am asking the question here because I couldn't find an available email address to the editors of JOSS.

Unfortunately, we don't have the ORCID for one of the authors because he has passed away. What could we do in this case? We could make one for him, but I wonder if it would be preferred to just leaving it empty or 0000-0000-0000-0000.

@arfon
Copy link
Member

arfon commented Nov 17, 2017

@jslee02 - it's ok to omit the ORCID field for the author who has passed away.

@jslee02
Copy link

jslee02 commented Nov 17, 2017

@arfon Thanks! Will do so.

@jslee02
Copy link

jslee02 commented Nov 17, 2017

Potential reviewers: @mosteo, @katyhuff, @betatim, @pragyansmita, @kyleniemeyer

@betatim
Copy link
Member

betatim commented Nov 18, 2017

I'd be happy to look at this.

@Kevin-Mattheus-Moerman
Copy link
Member

I've also pinged my colleagues at MIT Biomechatronics

@Kevin-Mattheus-Moerman
Copy link
Member

I can be editor if @labarba can't take this one

@labarba
Copy link
Member

labarba commented Nov 18, 2017

Feel free to take it, @Kevin-Mattheus-Moerman.

@Kevin-Mattheus-Moerman
Copy link
Member

@whedon assign @Kevin-Mattheus-Moerman as editor

@Kevin-Mattheus-Moerman
Copy link
Member

@whedon assign @Kevin-Mattheus-Moerman as editor

@Kevin-Mattheus-Moerman
Copy link
Member

@arfon I'm trying to assign myself as editor. It seems whedon removed lorena but it does not look like it assigned me. Can you see what is going on?

@kyleniemeyer
Copy link

@Kevin-Mattheus-Moerman you are listed as editor above, no? it looks like @whedon just didn't assign you to the issue.

@Kevin-Mattheus-Moerman
Copy link
Member

@kyleniemeyer @arfon thanks yep it is all good

@arfon
Copy link
Member

arfon commented Nov 18, 2017

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Nov 18, 2017

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Nov 18, 2017

https://github.com/openjournals/joss-papers/blob/joss.00460/10.21105.joss.00460.pdf

@arfon
Copy link
Member

arfon commented Nov 18, 2017

☝️ @Kevin-Mattheus-Moerman - Whedon can now try and compile the PDF for you. Looks like this worked (I'm trying to catch errors with the papers before they even get to the review stage now).

@jslee02
Copy link

jslee02 commented Nov 29, 2017

There was a correction of the affiliations. Let me regenerate the PDF.

@jslee02
Copy link

jslee02 commented Nov 29, 2017

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Nov 29, 2017

Attempting PDF compilation. Reticulating splines etc...

@Kevin-Mattheus-Moerman
Copy link
Member

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Nov 29, 2017

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Nov 30, 2017

PDF failed to compile for issue #460 with the following error: 

 Can't find any papers to compile :-(

@arfon
Copy link
Member

arfon commented Nov 30, 2017

@whedon generate pdf

@openjournals openjournals deleted a comment from whedon Nov 30, 2017
@whedon
Copy link
Author

whedon commented Nov 30, 2017

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Nov 30, 2017

https://github.com/openjournals/joss-papers/blob/joss.00460/joss.00460/10.21105.joss.00460.pdf

@openjournals openjournals deleted a comment from whedon Nov 30, 2017
@whedon
Copy link
Author

whedon commented Nov 30, 2017

https://github.com/openjournals/joss-papers/blob/joss.00460/joss.00460/10.21105.joss.00460.pdf

@Kevin-Mattheus-Moerman
Copy link
Member

@bmagyar I know @danielskatz just pinged you to review over at #477,... but if this submission interests you as well it would be great if you could assist with review here too.

@jslee02
Copy link

jslee02 commented Dec 12, 2017

@Kevin-Mattheus-Moerman I'm not trying to involve in the reviewer matching process, but I just wonder if you saw @betatim's comment above that he's interested in looking at this submission.

@bmagyar
Copy link

bmagyar commented Dec 12, 2017 via email

@Kevin-Mattheus-Moerman
Copy link
Member

Great @bmagyar ! Starting over the holidays is fine.

@Kevin-Mattheus-Moerman
Copy link
Member

@jslee02 thanks for your inquiry. I was hoping to recruit more than 1 reviewer and also include a robotics specialist. It seems we have exactly that now so we are good to start. Both @bmagyar and @betatim will be reviewers.

@Kevin-Mattheus-Moerman
Copy link
Member

@whedon assign @bmagyar as reviewer

@whedon
Copy link
Author

whedon commented Dec 12, 2017

OK, the reviewer is @bmagyar

@Kevin-Mattheus-Moerman
Copy link
Member

@whedon start review magic-word=bananas

@whedon
Copy link
Author

whedon commented Dec 12, 2017

OK, I've started the review over in #500. Feel free to close this issue now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants