Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: OpenPelt: Python Framework for Thermoelectric Temperature Control System Development #4245

Closed
editorialbot opened this issue Mar 16, 2022 · 28 comments

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Mar 16, 2022

Submitting author: @gdetor (Georgios Detorakis)
Repository: https://github.com/thejackal360/OpenPelt-Public
Branch with paper.md (empty if default branch): master
Version: alpha
Editor: @rkurchin
Reviewers: @tpurcell90, @danaraujocr
Managing EiC: Kristen Thyng

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/3c5d7515f1ddddab6eb8aa5c658b51c0"><img src="https://joss.theoj.org/papers/3c5d7515f1ddddab6eb8aa5c658b51c0/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/3c5d7515f1ddddab6eb8aa5c658b51c0/status.svg)](https://joss.theoj.org/papers/3c5d7515f1ddddab6eb8aa5c658b51c0)

Author instructions

Thanks for submitting your paper to JOSS @gdetor. Currently, there isn't an JOSS editor assigned to your paper.

@gdetor if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1007/978-3-642-23099-8 is OK
- 10.1145/1731022.1731030 is OK
- 10.1109/IMTC.2000.848895 is OK

MISSING DOIs

- None

INVALID DOIs

- https://doi.org/10.1016/j.applthermaleng.2004.03.001 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1016/S0003-2670(03)00676-7 is INVALID because of 'https://doi.org/' prefix
- 10.1049/el20062442 is INVALID

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.26 s (85.2 files/s, 9066.8 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          17            275            311           1263
Markdown                         2             58              0            276
TeX                              1              7              0             81
Bourne Shell                     1              3              0             43
YAML                             1              1              4             18
-------------------------------------------------------------------------------
SUM:                            22            344            315           1681
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 1206

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@kthyng
Copy link

kthyng commented Mar 19, 2022

Hi @gdetor and thanks for your submission. It is a bit borderline on size so I am going to ping the greater editorial board to take a look and make sure it is in scope for JOSS. This process will take 1-2 weeks, thanks.

@kthyng
Copy link

kthyng commented Mar 19, 2022

@editorialbot query scope

@editorialbot
Copy link
Collaborator Author

Submission flagged for editorial review.

@editorialbot editorialbot added the query-scope Submissions of uncertain scope for JOSS label Mar 19, 2022
@Kevin-Mattheus-Moerman Kevin-Mattheus-Moerman removed the query-scope Submissions of uncertain scope for JOSS label Apr 6, 2022
@Kevin-Mattheus-Moerman
Copy link
Member

@gdetor I have just removed the query-scope label since this work was deemed as potentially in scope for JOSS. We will now proceed to find a handling editor.

@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot invite @rkurchin as editor

@rkurchin this may be somewhat out of your regular domain but do you think you can handle this submission?

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@rkurchin
Copy link

rkurchin commented Apr 6, 2022

@editorialbot add me as editor

Sure!

@editorialbot
Copy link
Collaborator Author

Assigned! @rkurchin is now the editor

@rkurchin
Copy link

rkurchin commented Apr 6, 2022

Hi @gdetor, nice to meet you! I'll work on finding some reviewers for this. In the meantime, whenever you get a moment, you can fix the DOI errors shown above...

@rkurchin
Copy link

rkurchin commented Apr 6, 2022

👋 Hi @danaraujocr and @tpurcell90, would you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@thejackal360
Copy link

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1049/el:20062442 is OK
- 10.1007/978-3-642-23099-8 is OK
- 10.1145/1731022.1731030 is OK
- 10.1109/IMTC.2000.848895 is OK

MISSING DOIs

- None

INVALID DOIs

- https://doi.org/10.1016/j.applthermaleng.2004.03.001 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1016/S0003-2670(03)00676-7 is INVALID because of 'https://doi.org/' prefix

@thejackal360
Copy link

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/j.applthermaleng.2004.03.001 is OK
- 10.1016/S0003-2670(03)00676-7 is OK
- 10.1049/el:20062442 is OK
- 10.1007/978-3-642-23099-8 is OK
- 10.1145/1731022.1731030 is OK
- 10.1109/IMTC.2000.848895 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@tpurcell90
Copy link

@rkurchin I can be a reviewer for this

@danaraujocr
Copy link

danaraujocr commented Apr 7, 2022 via email

@rkurchin
Copy link

rkurchin commented Apr 7, 2022

@editorialbot add @tpurcell90 as reviewer

@editorialbot
Copy link
Collaborator Author

@tpurcell90 added to the reviewers list!

@rkurchin
Copy link

rkurchin commented Apr 7, 2022

@editorialbot add @danaraujocr as reviewer

@editorialbot
Copy link
Collaborator Author

@danaraujocr added to the reviewers list!

@rkurchin
Copy link

rkurchin commented Apr 7, 2022

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #4306.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants