Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: GridapDistributed: a massively parallel finite element toolbox in Julia #4085

Closed
whedon opened this issue Jan 21, 2022 · 36 comments

Comments

@whedon
Copy link

whedon commented Jan 21, 2022

Submitting author: @amartinhuertas (Dr. Alberto F. Martin)
Repository: https://github.com/gridap/GridapDistributed.jl/
Version: v0.2.4
Editor: @Kevin-Mattheus-Moerman
Reviewers: @PetrKryslUCSD, @Leticia-maria, @jedbrown
Managing EiC: Kyle Niemeyer

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/3bd4bf42932beb69c49ebd4f88db45c2"><img src="https://joss.theoj.org/papers/3bd4bf42932beb69c49ebd4f88db45c2/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/3bd4bf42932beb69c49ebd4f88db45c2/status.svg)](https://joss.theoj.org/papers/3bd4bf42932beb69c49ebd4f88db45c2)

Author instructions

Thanks for submitting your paper to JOSS @amartinhuertas. Currently, there isn't an JOSS editor assigned to your paper.

The author's suggestion for the handling editor is @Kevin-Mattheus-Moerman.

@amartinhuertas if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Jan 21, 2022

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Jan 21, 2022

Software report (experimental):

github.com/AlDanial/cloc v 1.88  T=0.07 s (580.6 files/s, 53180.8 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Julia                           30            555            154           2572
TOML                             4             28              1            109
Markdown                         3             44              0            100
YAML                             2              0              1             93
Bourne Shell                     1              1              3              3
-------------------------------------------------------------------------------
SUM:                            40            628            159           2877
-------------------------------------------------------------------------------


Statistical information for the repository 'af68adb7bce61eef1e13bb4e' was
gathered on 2022/01/21.
No commited files with the specified extensions were found.

@whedon
Copy link
Author

whedon commented Jan 21, 2022

PDF failed to compile for issue #4085 with the following error:

 Can't find any papers to compile :-(

@kyleniemeyer
Copy link

@whedon generate pdf from branch joss_paper

@whedon
Copy link
Author

whedon commented Jan 21, 2022

Attempting PDF compilation from custom branch joss_paper. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Jan 21, 2022

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@kyleniemeyer
Copy link

@whedon check references from branch joss_paper

@whedon
Copy link
Author

whedon commented Jan 21, 2022

Attempting to check references... from custom branch joss_paper

@whedon
Copy link
Author

whedon commented Jan 21, 2022

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1137/141000671 is OK
- 10.21105/JOSS.02520 is OK
- 10.1137/20M1328786 is OK
- 10.1007/978-3-030-23957-2 is OK
- 10.5194/GMD-6-2099-2013 is OK
- 10.1137/100791634 is OK
- 10.1006/JCPH.1996.0047 is OK
- 10.3402/TELLUSA.V56I5.14436 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@kyleniemeyer
Copy link

@whedon invite @Kevin-Mattheus-Moerman as editor

👋 @Kevin-Mattheus-Moerman I hesitate slightly to ask you to edit this, since you've already got a solid workload, but it looks right in your wheelhouse...

@whedon
Copy link
Author

whedon commented Jan 21, 2022

@Kevin-Mattheus-Moerman has been invited to edit this submission.

@amartinhuertas
Copy link

@amartinhuertas if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @).

@kyleniemeyer, suggestions for reviewers:

  • PetrKryslUCSD
  • KristofferC
  • ranocha

@Kevin-Mattheus-Moerman
Copy link
Member

@whedon assign me as editor

@whedon
Copy link
Author

whedon commented Jan 28, 2022

OK, the editor is @Kevin-Mattheus-Moerman

@Kevin-Mattheus-Moerman
Copy link
Member

Kevin-Mattheus-Moerman commented Jan 31, 2022

@jedbrown @PetrKryslUCSD, @Leticia-maria, @TeroFrondelius, @KristofferC, @rouson, @tjhei, @chrisrichardson, @vijaysm, @likask would you be interesting in reviewing this software: "GridapDistributed: a massively parallel finite element toolbox in Julia" for JOSS?

Short paper: https://github.com/openjournals/joss-papers/blob/joss.04085/joss.04085/10.21105.joss.04085.pdf
Software: https://github.com/gridap/GridapDistributed.jl/

@Leticia-maria
Copy link

@jedbrown @PetrKryslUCSD, @Leticia-maria, @TeroFrondelius, @KristofferC, @rouson, @tjhei, @chrisrichardson, @vijaysm, @likask would you be interesting in reviewing this software: "GridapDistributed: a massively parallel finite element toolbox in Julia" for JOSS?

Short paper: https://github.com/openjournals/joss-papers/blob/joss.04085/joss.04085/10.21105.joss.04085.pdf
Software: https://github.com/gridap/GridapDistributed.jl/

Thank you for calling me. I will review and we can keep in contact😊

@Kevin-Mattheus-Moerman
Copy link
Member

@whedon assign @Leticia-maria as reviewer

@whedon
Copy link
Author

whedon commented Feb 1, 2022

OK, @Leticia-maria is now a reviewer

@vijaysm
Copy link

vijaysm commented Feb 1, 2022

I'm unfortunately swamped with many things at the moment and so won't be able to finish my review without delays. It's definitely an interesting project and I'll keep my eye out on this page to follow the review comments. If you still need someone in a few weeks, I definitely will be able to review it. Thanks @Kevin-Mattheus-Moerman

@jedbrown
Copy link
Member

jedbrown commented Feb 1, 2022

I'm also interested in the project, but can't accept new reviewing until my kids can return to childcare and I can finish my already-overdue reviews. You're welcome to ping if you still need a reviewer in a few weeks.

@likask
Copy link

likask commented Feb 1, 2022

It looks like a very interesting project. However, I have to decline the review. I have a teaching-intensive period, and could not fully commit to this work. @Kevin-Mattheus-Moerman

@PetrKryslUCSD
Copy link

Sure, happy to do it. @Kevin-Mattheus-Moerman

@Kevin-Mattheus-Moerman
Copy link
Member

@whedon assign @PetrKryslUCSD as reviewer

@whedon
Copy link
Author

whedon commented Feb 1, 2022

OK, @PetrKryslUCSD is now a reviewer

@rouson
Copy link

rouson commented Feb 2, 2022

@Kevin-Mattheus-Moerman I'm interested in the subject matter, but my lack of prior experience with Julia would preclude providing a timely review.

@Kevin-Mattheus-Moerman
Copy link
Member

@whedon add @Leticia-maria as reviewer

@whedon
Copy link
Author

whedon commented Feb 2, 2022

OK, @Leticia-maria is now a reviewer

@Kevin-Mattheus-Moerman
Copy link
Member

@Leticia-maria apologies I accidentally replaced you above with Petr, so had to add you again.

@Leticia-maria
Copy link

@Leticia-maria apologies I accidentally replaced you above with Petr, so had to add you again.

No problem @Kevin-Mattheus-Moerman. What's my deadline to review?

@Kevin-Mattheus-Moerman
Copy link
Member

@Leticia-maria we used to aim for about 2-3 weeks but we can be (and have to be) quite flexible as we've seen (and experienced personally) that most people are struggling to keep up with things during the pandemic. So if you could aim for ~3 weeks great, but if you need more time just let me know. Note we have not formally started the review yet since this is the pre-review issue. You may start already if you wish but you can also wait until we've opened the review issue.

@Kevin-Mattheus-Moerman
Copy link
Member

I'm also interested in the project, but can't accept new reviewing until my kids can return to childcare and I can finish my already-overdue reviews. You're welcome to ping if you still need a reviewer in a few weeks.

@jedbrown I was wondering if you'd be okay being assigned as a reviewer at this point. Note though you can take your time. We can give you all the time you need (terms and conditions apply 😉 ) but I think we could use your help.

@jedbrown
Copy link
Member

Okay, go ahead and assign me.

@Kevin-Mattheus-Moerman
Copy link
Member

@whedon add @jedbrown as reviewer

@whedon
Copy link
Author

whedon commented Feb 13, 2022

OK, @jedbrown is now a reviewer

@Kevin-Mattheus-Moerman
Copy link
Member

@whedon start review

@whedon
Copy link
Author

whedon commented Feb 13, 2022

OK, I've started the review over in #4157.

@whedon whedon closed this as completed Feb 13, 2022
@Leticia-maria Leticia-maria reopened this Mar 25, 2022
@arfon arfon closed this as completed Apr 24, 2022
@openjournals openjournals locked and limited conversation to collaborators Apr 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests